Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Pete Heist <pete@heistp.net>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: Cake List <cake@lists.bufferbloat.net>
Subject: Re: [Cake] the Cake stalemate
Date: Tue, 19 Jun 2018 14:26:56 +0200	[thread overview]
Message-ID: <6D5348AC-921E-49D3-B6D0-9CC30874B80D@heistp.net> (raw)
In-Reply-To: <877emvt2ij.fsf@toke.dk>


> On Jun 19, 2018, at 1:54 PM, Toke Høiland-Jørgensen <toke@toke.dk> wrote:
> 
> We also saw a bug on 32-bit MIPS where some combinations of 64-bit
> netlink attributes would cause stats display in tc to fail. However, I
> believe this is more a case of Cake exposing a latent bug somewhere in
> the tc or kernel netlink code (alignment issues, perhaps?), and so I'm
> not sure it is necessarily a blocker for merging Cake. However, if
> someone could take a look that would be very helpful. I forget if the
> current head of the cobalt branch exposes the bug, but I think it does.
> It's quite obvious when it happens: no stats output whatsoever...

I have a 32-bit MIPS in my ER-X, but it sounds like what I saw (outrageous refcnt values) was something different:

qdisc pfifo_fast 0: dev vtun1 root refcnt 23227372115329026 bands 3 priomap  1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1
 Sent 3696 bytes 44 pkt (dropped 0, overlimits 0 requeues 0) 
 backlog 0b 0p requeues 0
qdisc cake 800a: dev ifb4eth4 root refcnt 23227372115329026 bandwidth 30Mbit diffserv3 dual-dsthost nat ingress split-gso rtt 100.0ms raw overhead 0 
 Sent 41906985 bytes 41340 pkt (dropped 347, overlimits 57700 requeues 0)

This may be related to its old 3.10 kernel though (BTW, looks like Ubiquiti will move to 4.9 soon, alpha is out…).

However, if there’s a way I should try to reproduce something on this hardware to take a look, send any info you’ve got (how to add 64-bit netlink attributes?). I even have a spare ER-X on which I could put OpenWRT in case I need to be working with a more modern kernel…


  reply	other threads:[~2018-06-19 12:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-19  9:31 Pete Heist
2018-06-19  9:55 ` Toke Høiland-Jørgensen
2018-06-19 10:04   ` Pete Heist
2018-06-19 11:32   ` Jonathan Morton
2018-06-19 11:54     ` Toke Høiland-Jørgensen
2018-06-19 12:26       ` Pete Heist [this message]
2018-06-19 13:41         ` Kevin Darbyshire-Bryant
2018-06-19 14:48           ` Pete Heist
2018-06-19 16:24             ` Dave Taht
2018-06-19 20:14               ` Pete Heist
2018-06-19 20:35                 ` Jonathan Morton
2018-06-19 21:48                   ` Dave Taht
2018-06-19 23:41                     ` Sebastian Moeller
2018-06-19 22:34                   ` Pete Heist
2018-06-19 23:38                   ` Sebastian Moeller
2018-06-20  3:36                     ` Jonathan Morton
2018-06-20  4:34                       ` Sebastian Moeller
2018-06-19 12:08     ` Pete Heist

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6D5348AC-921E-49D3-B6D0-9CC30874B80D@heistp.net \
    --to=pete@heistp.net \
    --cc=cake@lists.bufferbloat.net \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox