From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 7B0D33CB43 for ; Wed, 7 Mar 2018 09:21:19 -0500 (EST) Received: from [172.16.10.189] ([134.76.241.253]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LeN3N-1eL1LL0Ixh-00qDAu; Wed, 07 Mar 2018 15:21:14 +0100 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) From: Sebastian Moeller In-Reply-To: <87h8psyraq.fsf@toke.dk> Date: Wed, 7 Mar 2018 15:21:11 +0100 Cc: Kevin Darbyshire-Bryant , "cake@lists.bufferbloat.net" Content-Transfer-Encoding: quoted-printable Message-Id: <70CC0AF0-1C86-4998-909A-503B65122E93@gmx.de> References: <20180127130542.25817-1-toke@toke.dk> <20180211172618.13297-1-toke@toke.dk> <20180211172618.13297-2-toke@toke.dk> <20180306075616.380a533c@xeon-e3> <87ina9m4up.fsf@toke.dk> <876068nccm.fsf@toke.dk> <0A156FD3-4816-462C-952B-7938EF8C0EA3@gmail.com> <87sh9cl15n.fsf@toke.dk> <879005B6-2334-4F46-9922-4BC2CACBF107@darbyshire-bryant.me.uk> <87vae8yy68.fsf@toke.dk> <87sh9cyxy9.fsf@toke.dk> <340269AF-2325-4657-8939-5E3195D1C0DC@darbyshire-bryant.me.uk> <87muzkyvj7.fsf@toke.dk> <11DDD9A0-BBD7-4DAA-ACE1-EB88CDC26E7C@darbyshire-bryant.me.uk> <87h8psyraq.fsf@toke.dk> To: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= X-Mailer: Apple Mail (2.3445.5.20) X-Provags-ID: V03:K0:Doa+JBwYnibSUGUqeKUXgu3XK82c2J0upQIHMTQQk8YlCN4aa0D 73CZPMlN4RgKeNXEjlgdT+vHs40pfw4RsuUOaIhB5l3CgxMziIs0DMIKGyOBvTqt2OI6Qjg dgVMapwUs5Y3f8UW1egLHnL9XKgSsAowaX4Fi8e59yVeuP1g/qVvu5VtV/dYWSosyPPo4cp giL83NLpvp5V5zAHwluNg== X-UI-Out-Filterresults: notjunk:1;V01:K0:p3bDB3zht60=:2CgJcAGk/TKdgUslBa5qX2 ILA31mdjxyWPnHjWozsKbim2kuaM18xMwL7Q/eMyi7Bvgegmek6oQvxMnf9R6Ec5U7PJdD1Uv saIEXxvl2AtZALOTcTE12mzzHGhauOJBv3yGIz8dOpJpgvTehO+ktB+2w5J3uPmgN94jc9aBr BNPYc010Q8KibTouwshKOKM99wSckCCFOAhKtCjk2ICRB7DROgac+21Xq/kwu1tUi3NsZXDe7 2CoEEa6cM7Ebj+BniAjVMSJjaUslloGfV0jUkRtWOMwNeNOAG2KurStWQry9tyGppI8PNKRpi HrWuwdWZkKr3mSb1z2B6no5vDVV0Xzid92o+TdYbbbIU6IK+PFSjzRCmYEgZOREXHPmVhrLiW 2JNQdkz4+hF8bVinaXFtS6sqDu/1vKBu/khevHkA0URzDB4YRMd89wMpFoCqMo31qN/hVD1Lk 1QzAX2x+laskdAymAbuuYSuqzbkdabw1Jf1TFXoWWOrmI4NhfqCAMng8/zU0DVFBac8TDp+rR V0Mef8xHVfHovfzzhO3+wZWbJQ0zCjexEXsc1+WZfFtEgWSSWtKz/wdBWjKiZsiTKsYEvsMAy jXotbaD7xaJrwUg0OfZnkh3O2pPaFk9A4dTFuYmjDdRXdkEEwvhvi44KQ8Xaz1sUejm1dKgmd uhd6SP9RBuVNs+kkBULVQvqHKgemZG0Jpuo04D3EAxFLkXvqjGxRWfOyHh2gLtZNt+fHKNOaB sTkSVlxiLRODuX9isrcBgGCPyeqhwPVEFo06OfjOuTgpPCUcNV1KdK4SE87EZ0RFEJebyUWgg /PpMj389Gdsg23P45QZ3msiwrwFx0JxyyFZ1/pcV7bkocNNWcE= Subject: Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 14:21:19 -0000 Hi Toke, > On Mar 7, 2018, at 13:59, Toke H=C3=B8iland-J=C3=B8rgensen = wrote: >=20 > Kevin Darbyshire-Bryant writes: >=20 >> I don=E2=80=99t the column alignment can be correct because the print = lines don=E2=80=99t include a leading space, so columns can run into = each other. >>=20 >> fprintf(f, "%12u", tst->unresponse_flows); >> v >> fprintf(f, " %12u", tst->unresponse_flows); >>=20 >> The header lines are probably wrong. Should be as per >> = https://github.com/ldir-EDB0/iproute2-cake-next/commit/172c116722e2902bdc6= 9824271303dac7249f379 >=20 > Ah, right; ported that change over to the tc-adv repo as well. Which > brings us down to the following diff: >=20 > diff --git a/tc/q_cake.c b/tc/q_cake.c > index e21552e8..95301b41 100644 > --- a/tc/q_cake.c > +++ b/tc/q_cake.c > @@ -243,12 +243,22 @@ static int cake_parse_opt(struct qdisc_util *qu, = int argc, char **argv, > /* Typical VDSL2 framing schemes, both over PTM */ > /* PTM has 64b/65b coding which absorbs some bandwidth = */ > } else if (strcmp(*argv, "pppoe-ptm") =3D=3D 0) { > + /* 2B PPP + 6B PPPoE + 6B dest MAC + 6B src = MAC > + * + 2B ethertype + 4B Frame Check Sequence > + * + 1B Start of Frame (S) + 1B End of Frame = (Ck) > + * + 2B TC-CRC (PTM-FCS) =3D 30B > + */ > atm =3D 2; > - overhead +=3D 27; > + overhead +=3D 30; > overhead_set =3D true; > } else if (strcmp(*argv, "bridged-ptm") =3D=3D 0) { > + /* 6B dest MAC + 6B src MAC + 2B ethertype > + * + 4B Frame Check Sequence > + * + 1B Start of Frame (S) + 1B End of Frame = (Ck) > + * + 2B TC-CRC (PTM-FCS) =3D 22B > + */ > atm =3D 2; > - overhead +=3D 19; > + overhead +=3D 22; > overhead_set =3D true; >=20 >=20 >=20 >=20 > I assume 30 and 22 are the correct values? Could someone confirm this? = :) As I made that change all I can confirm that at the current time = I am convinced that 30 and 22 are the correct values. I did look into = the ITU standard documents for VDSL and to the best of my knowledge = these agree. Best Regards Sebastian >=20 >> qdisc cake 8004: root refcnt 4486780 bandwidth 19900Kbit diffserv3 = dual-srchost nat rtt 100.0ms ptm overhead 4502152 >> Sent 42615751 bytes 4491092 pkt (dropped 4491108, overlimits 4491124 = requeues 4491152) >> backlog 0b 4491256p requeues 4491272 >> memory used: 78592b of 4Mb >> capacity estimate: 19900Kbit >> min/max transport layer size: 4537916 / 4537972 >> min/max overhead-adjusted size: 4538000 / 4537972 >> average transport hdr offset: 4538072 >>=20 >> I=E2=80=99m pondering if it=E2=80=99s an endian issue? >=20 > Are you using the latest kernel code? Those values were added in an > incompatible manner, so if you don't have userspace and kernel code in > sync they'll be garbage, basically... >=20 > -Toke > _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake