From: Pete Heist <pete@heistp.net>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: cake@lists.bufferbloat.net
Subject: Re: [Cake] Upstream submission of dual-mode fairness patch
Date: Fri, 1 Mar 2019 11:52:16 +0100 [thread overview]
Message-ID: <72193310-7502-47B8-9554-7F8F9FA23204@heistp.net> (raw)
In-Reply-To: <mailman.1788.1551352661.3538.cake@lists.bufferbloat.net>
[-- Attachment #1: Type: text/plain, Size: 1891 bytes --]
Thanks for the nudge... I just tested this on the original one-armed router setup I encountered it on (3.16.7, routing from eth0 to eth0.3300). The patch makes a big improvement over the original (which was around 10/80):
IP 1, 1 up: 47.0 Mbit
IP 2, 8 up: 47.0 Mbit
IP 1, 8 down: 46.7 Mbit
IP 2, 1 down: 46.6 Mbit
Curiously, if my one-armed router has cake applied on egress and ingress of eth0.3300, instead of egress of eth0 and egress of eth0.3300 as above, some reduction in fairness occurs, but only for the downstream flows. This increases with the number of flows:
IP 1, 1 up: 47.2 Mbit
IP 2, 8 up: 47.2 Mbit
IP 1, 8 down: 44.5 Mbit
IP 2, 1 down: 48.7 Mbit
IP 1, 1 up: 47.0 Mbit
IP 2, 16 up: 47.0 Mbit
IP 1, 16 down: 42.6 Mbit
IP 2, 1 down: 50.3 Mbit
IP 1, 1 up: 47.2 Mbit
IP 2, 32 up: 47.0 Mbit
IP 1, 32 down: 41.4 Mbit
IP 2, 1 down: 51.3 Mbit
It still happens when ether-vlan is used on the leaf qdiscs with vlan traffic.
That said, unless there’s an obvious reason for this that’s fixable, I’m fine with how it is, considering the improvement. :)
> On Feb 28, 2019, at 12:17 PM, Toke Høiland-Jørgensen via Cake <cake@lists.bufferbloat.net> wrote:
>
>
> From: Toke Høiland-Jørgensen <toke@toke.dk>
> Subject: Upstream submission of dual-mode fairness patch
> Date: February 28, 2019 at 12:17:39 PM GMT+1
> To: cake@lists.bufferbloat.net
>
>
> Hey everyone
>
> The dual-mode fairness patch has been in the github repo for a few weeks
> now, and no one has complained. If no one continues to complain, I'll
> submit it upstream tomorrow along with Kevin's fwmark patch.
>
> So if anyone else wants to test, now would be a good time to do so :)
>
> -Toke
>
>
> _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake
[-- Attachment #2: Type: text/html, Size: 4804 bytes --]
next parent reply other threads:[~2019-03-01 10:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.1788.1551352661.3538.cake@lists.bufferbloat.net>
2019-03-01 10:52 ` Pete Heist [this message]
2019-03-01 11:01 ` Toke Høiland-Jørgensen
2019-03-01 11:55 ` Pete Heist
2019-03-01 14:40 ` Georgios Amanakis
2019-03-01 16:43 ` Pete Heist
2019-03-02 3:02 ` George Amanakis
2019-03-02 4:47 ` George Amanakis
2019-03-02 10:20 ` Pete Heist
2019-03-03 7:19 ` Pete Heist
2019-03-03 9:53 ` Sebastian Moeller
2019-03-03 9:58 ` Jonathan Morton
2019-03-03 11:26 ` Sebastian Moeller
2019-03-03 12:13 ` Jonathan Morton
2019-03-03 12:53 ` Sebastian Moeller
2019-03-03 16:07 ` Pete Heist
2019-03-03 16:10 ` Jonathan Morton
2019-03-03 16:35 ` Pete Heist
2019-03-03 16:40 ` Jonathan Morton
2019-03-03 18:48 ` Pete Heist
2019-03-03 19:03 ` gamanakis
2019-03-03 19:49 ` Pete Heist
2019-03-04 2:55 ` Georgios Amanakis
2019-03-04 3:17 ` Jonathan Morton
2019-03-04 4:22 ` Ryan Mounce
2019-03-04 8:27 ` Pete Heist
2019-03-04 13:17 ` Pete Heist
2019-03-04 14:36 ` Georgios Amanakis
2019-03-03 12:06 ` Pete Heist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72193310-7502-47B8-9554-7F8F9FA23204@heistp.net \
--to=pete@heistp.net \
--cc=cake@lists.bufferbloat.net \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox