From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-1" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 536E821F682 for ; Wed, 4 Nov 2015 10:56:01 -0800 (PST) Received: from hms-beagle.home.lan ([217.237.68.126]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0MKLeM-1ZubBl2OmM-001fff; Wed, 04 Nov 2015 19:55:55 +0100 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) From: Sebastian Moeller In-Reply-To: <87y4ed8up0.fsf@toke.dk> Date: Wed, 4 Nov 2015 19:55:56 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <73EFC809-23B5-4BEA-853A-1A42E5C14A42@gmx.de> References: <87oafbnsqn.fsf@toke.dk> <5638B29D.9020503@darbyshire-bryant.me.uk> <87k2pzns29.fsf@toke.dk> <6F28B0F0-8333-4753-802E-BDDAC42CBC7B@gmail.com> <87oafbat54.fsf@toke.dk> <877flzas49.fsf@toke.dk> <87pozqaomi.fsf@toke.dk> <8737wm9g1y.fsf@toke.dk> <563A48AA.1080405@darbyshire-bryant.me.uk> <87y4ed8up0.fsf@toke.dk> To: =?windows-1252?Q?Toke_H=F8iland-J=F8rgensen?= X-Mailer: Apple Mail (2.1878.6) X-Provags-ID: V03:K0:3qAhzvAH/MF7AskFNtqA2LkqTENbeqINAbqUMpIxoeBGO4Ccyh0 /3QQchxJTe3dU49hyrrnOGLPGhXPhY+Bkhc0gE1FrFKKClyHfaswbM8NKdqJlM6A6KKRYy3 kJaqPRm53vQo6Ow0usFIWI+nSEN3j/dH1yGZ1IQ4aeKwQb9UULWm13KxVB+UI+NgzdgEvSn F8IotkhtbgmLkmCDMuvLg== X-UI-Out-Filterresults: notjunk:1;V01:K0:3aHaGWJPnxQ=:BkE+UxB3jZwvr/VaNoqfpQ +pmacvmqYIh8WeLtp103KhneosEqgXit8a7vk9VpcxBdrUaBMwrmJThXYoAEQaqNnNMkRAOdo gyHjkoq3nMX/nOMfdCThrPmr4wXA2Ki0S29+ZX6lr8BeUVWgwliTcXq/1dQ4O47gnrKAR8eAw UC790dPLHMVd2i9i5Re1fAQMHxMd/yuY5joArhpc/Y5h/Xy2+qmOa5SN0nVIq+aS/mAPSBYuR DmJcL/2SaLjDSR0gwyStThOhmV10dVdoAdkC4uEMiLYvqzFz1b95mBZ0nsKE+nAxjfbo+4RFR yEAnsvpIwh+Q4tV7NhzewpsW9ghAmyRdm72jg8KFvVT6eaSvQmxeZNRdVYOxeEgybJPn+tVq1 ukaQ9K7hs+C5e8NmqVyl7V5E01AfaQmirdcOD2wtmDE2+wjaeKbxE/lTKKh1nIeb5GFJQh45A gB/LeSIcvIDCsq6kSqlsrBQu/quy37nOCXVj4rCTKB6cG0uCcp3CnSkZLaCd6yjAVQ/1SlmkA pY9eGpBlhaCDg7442KdsD7nj/SD23RwkmcGbU9XK9cnKXaqXc2O+YzGc0rwY0YWnEAbtFfAK6 tzMohiIHWeMb+hBlHKlHSBQBTn8FMmSHW0DXykM7N2Rr3hZJypdfViixqDm4HddWS2si+tdrO qBnzBYL1/0jL3UDHaMiZ1S/eP/wqsihwZGJoXcjBI3RddspTN/jvJ0ALRekz/cQ0CuAfW97N2 bdGDi3yp/MXRSS3NpLiQAvIKaSHKhVbvxTe9abHsoUrvtu/nlHBKwtzU6R7DaJDh1uU8n6kSb iqQYyYJ Cc: cake@lists.bufferbloat.net Subject: Re: [Cake] Correct 'change' behaviour X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Nov 2015 18:56:25 -0000 Hi All, On Nov 4, 2015, at 19:51 , Toke H=F8iland-J=F8rgensen = wrote: > Kevin Darbyshire-Bryant writes: >=20 >> Doesn't the comment in the code say in essence "if it's the same type = of >> qdisc then the operation is a change, else the operation is (an = atomic) >> remove/add" ? Or did I mis-read it. >=20 > Hmm, that's not how I understood the comment (nor the code). But it > certainly seems that that is what happens. Asked on netdev, let's see > what they say... :) That would be unfortunate, as I believe this would require = another keyword for tc in addition to =93change" and =93replace" we = would need =93initialize=94, =93defaults=94 or =93re-set=94 with ample = opportunities for selecting that bike-shed=92s color=85 If the replace = degenerates to a change is on purpose we have no chance getting it = changed, but even if it was accidental there might be people expecting = that behavior now :( Best Regards Sebastian >=20 > -Toke > _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake