From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 485F83BA8E for ; Wed, 6 Dec 2017 03:14:18 -0500 (EST) Received: from [192.168.250.101] ([134.76.241.253]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MbfnB-1ecmmD2vh7-00J10K; Wed, 06 Dec 2017 09:14:16 +0100 From: Sebastian Moeller Message-Id: <75E4D625-7B54-432A-9777-C354A09E170E@gmx.de> Content-Type: multipart/mixed; boundary="Apple-Mail=_D797A800-21A4-466B-B4FA-4CA3F59CB79F" Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Date: Wed, 6 Dec 2017 09:14:15 +0100 In-Reply-To: Cc: Cake List To: =?utf-8?Q?Dave_T=C3=A4ht?= References: X-Mailer: Apple Mail (2.3273) X-Provags-ID: V03:K0:O5yduhreSyzm0ugBC8pzxCX2wgmVZiAnYWNbHlzvxxT4PelfKvV gCine10myhSpfFjfqGopTGelrO0N19/Pd8+5a7HVNpmJtWZuGUJG+uiZqhyx4WBaq3HztGo VM/Jpa+pjS33I9oDQhKw+qUz7dSFzAHYSRFyM2vtLKPbgsXszTfpnHDpRimfG9c/7tafsaf Ij/vpJsaYrdwZoFr1+iKA== X-UI-Out-Filterresults: notjunk:1;V01:K0:VPqibqW3k74=:nZkztp0BOCJpZhcto+iFEn tT8JxssEu9bituDyAu91kXwMBytFuZ2tuT2s2ZIVXw7+5BUOkB+SFDYS9WEN54HrBIi1sPb+G Uou5FqrF7FOQ1jo5KQznBqpvm4wmsH7IsaNAGEbBWbvHCTOY4jOeVKXZViT59fIamkqxNjvTJ s+8K7iE4KvRK/dbkNcmJniiaFnDfCX9F7mKBcUHXwzFf6c4XoOgbojUodF8tlUbfEGjy6CMQZ sqQl/F4e5Lfv83aFsD9dtaxy23uS1XdVAWQ5XVuwrQ0o8dQAfyT4AxcJ0RfT/bF8+eo+wZpNX 0ARGmCvJnieWZ6FTfNfuoBfKZc/FC6ECV+IEKlee6AsFwO0wMPcS+vtMH6kDRe0xwBZhwDWUE Ud+VETf8wOL1Pq8/duuOK8yAhchGe2EkdMy7HLnLgmlAlejP1Evz5lhVYXoJSO+hNbpVbv0vx AjUdsb74MVDBwmHap8Napvc9RRAkmEzBVxJhMmWUZmu1uckA3nxYb62Hn+SB7vMa1Kx1ivasY I6iKnU/eR3uV81clP38cbUWbDuLEbeomfOo0jiY/g2CFCo0Xeeq+VyeP9asYWJtUqJaHPOOQ0 iOXdloWNIOPJSE1vojJRomw4NEKISgwHZ88n6ahVmDp0fRcym6yUZ1SJxMUtPaGHPM2guRpdy IH+VcSzzC5Kbndp/ahrZVJUGlx0+hUMNqaFBeaBXo9IGg0wwBGbLn6k7IVo9I7qQvvk8VXAFa vau5rf4qkU+M4mMXFWqqwV4jHhdOm9/GVIRXQqv4hLN1UfI6lLl9RLEOG/Uyarw7BF13fr/8s xh1DQm0wF4qyPlTNiGnp5eLQVba0w== Subject: [Cake] [OT] Re: RHODIUM - nuking blue (for testing) X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Dec 2017 08:14:18 -0000 --Apple-Mail=_D797A800-21A4-466B-B4FA-4CA3F59CB79F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi Dave > On Dec 5, 2017, at 20:32, Dave Taht wrote: >=20 > Given some of the results thus far at various RTTs, and at higher > loads, like the ginormous one georgios just ran, I thought it might be > useful to run a battery of tests with blue disabled. >=20 > I haven't gone to the trouble of creating a formal branch - tho if I > did, I'd call it rhodium, as rhodium detectors are used in nuclear > reactors to measure the neutron flux level. And the name Rhodium comes from the greek rhodeos meaning red = like a rose; in other words "not blue" ;) Best Regards Sebastian >=20 > untested-but-compiling-patch attached. I'm busy on a few other things > this week, and it is looking like we'll have to replace the xstats > structure with something smaller to go mainline. >=20 > --=20 >=20 > Dave T=C3=A4ht > CEO, TekLibre, LLC > http://www.teklibre.com > Tel: 1-669-226-2619 --Apple-Mail=_D797A800-21A4-466B-B4FA-4CA3F59CB79F Content-Disposition: attachment; filename=0001-RHODIUM-disable-blue-algorithm-for-testing.patch Content-Type: text/x-patch; x-unix-mode=0644; name="0001-RHODIUM-disable-blue-algorithm-for-testing.patch" Content-Transfer-Encoding: quoted-printable =46rom 56a55081199ed9ee36de8a2806a7c51d5a83a078 Mon Sep 17 00:00:00 2001 From: Dave Taht Date: Tue, 5 Dec 2017 11:22:08 -0800 Subject: [PATCH] RHODIUM: disable blue algorithm for testing This patch disables the blue algorithm so the aqm becomes more pure codel. --- cobalt.h | 2 ++ sch_cake.c | 13 ++++++++++++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/cobalt.h b/cobalt.h index f10f9db..c1d9dff 100644 --- a/cobalt.h +++ b/cobalt.h @@ -126,8 +126,10 @@ struct cobalt_vars { u32 count; u32 rec_inv_sqrt; cobalt_time_t drop_next; +#ifndef RHODIUM cobalt_time_t blue_timer; u32 p_drop; +#endif bool dropping; bool ecn_marked; }; diff --git a/sch_cake.c b/sch_cake.c index 4010388..134c6ca 100644 --- a/sch_cake.c +++ b/sch_cake.c @@ -62,6 +62,7 @@ #else #include #endif +#define RHODIUM 1 #include "cobalt.h" =20 #if IS_ENABLED(CONFIG_NF_CONNTRACK) @@ -443,6 +444,7 @@ static bool cobalt_queue_full(struct cobalt_vars = *vars, { bool up =3D false; =20 +#ifndef RHODIUM if ((now - vars->blue_timer) > p->target) { up =3D !vars->p_drop; vars->p_drop +=3D p->p_inc; @@ -450,6 +452,7 @@ static bool cobalt_queue_full(struct cobalt_vars = *vars, vars->p_drop =3D ~0; vars->blue_timer =3D now; } +#endif vars->dropping =3D true; vars->drop_next =3D now; if (!vars->count) @@ -467,6 +470,7 @@ static bool cobalt_queue_empty(struct cobalt_vars = *vars, { bool down =3D false; =20 +#ifndef RHODIUM if (vars->p_drop && (now - vars->blue_timer) > p->target) { if (vars->p_drop < p->p_dec) vars->p_drop =3D 0; @@ -475,6 +479,7 @@ static bool cobalt_queue_empty(struct cobalt_vars = *vars, vars->blue_timer =3D now; down =3D !vars->p_drop; } +#endif vars->dropping =3D false; =20 if (vars->count && (now - vars->drop_next) >=3D 0) { @@ -559,10 +564,11 @@ static bool cobalt_should_drop(struct cobalt_vars = *vars, } } =20 +#ifndef RHODIUM /* Simple BLUE implementation. Lack of ECN is deliberate. */ if (vars->p_drop) drop |=3D (prandom_u32() < vars->p_drop); - +#endif /* Overload the drop_next field as an activity timeout */ if (!vars->count) vars->drop_next =3D now + p->interval; @@ -1818,8 +1824,13 @@ retry: if (cobalt_queue_empty(&flow->cvars, = &b->cparams, now)) b->unresponsive_flow_count--; =20 +#ifndef RHODIUM if (flow->cvars.p_drop || flow->cvars.count || (now - flow->cvars.drop_next) < 0) { +#else + if (flow->cvars.count || + (now - flow->cvars.drop_next) < 0) { +#endif /* keep in the flowchain until the state = has * decayed to rest */ --=20 2.7.4 --Apple-Mail=_D797A800-21A4-466B-B4FA-4CA3F59CB79F Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii > _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake --Apple-Mail=_D797A800-21A4-466B-B4FA-4CA3F59CB79F--