Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: moeller0 <moeller0@gmx.de>
To: Jonathan Morton <chromatix99@gmail.com>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>, cake@lists.bufferbloat.net
Subject: Re: [Cake] cake/tc - removal of atm/ptm/ethernet specific overhead keywords
Date: Thu, 2 Jun 2016 21:17:06 +0200	[thread overview]
Message-ID: <75FFB40F-2208-4039-A377-44C0959A6FB3@gmx.de> (raw)
In-Reply-To: <31D7D84F-3CA9-46C5-AB52-79E3A1CFFCF0@gmail.com>


> On Jun 2, 2016, at 20:55 , Jonathan Morton <chromatix99@gmail.com> wrote:
> 
> 
>> On 2 Jun, 2016, at 21:53, moeller0 <moeller0@gmx.de> wrote:
>> 
>> “conservative”-keyword needs special care in documentation as it is the only keyword that compounds per-packet-overhead and specific framing
> 
> Not true.  All of the ATM-specific encapsulation keywords - of which there are ten others - also force ATM compensation on.  This is obvious in the code.
> 
> - Jonathan Morton
> 

I might not have picked the best example, but the current keywords make it simple for me ;) 
Let me rephrase then , it is not self-evident which keywords are ATM-specific then… But humor me:
tc qdisc add cake help
Usage: ... cake [ bandwidth RATE | unlimited* | autorate_ingress ]
                [ rtt TIME | datacentre | lan | metro | regional | internet* | oceanic | satellite | interplanetary ]
                [ besteffort | precedence | diffserv8 | diffserv4* ]
                [ flowblind | srchost | dsthost | hosts | flows* | dual-srchost | dual-dsthost | triple-isolate ]
                [ atm | noatm* ] [ overhead N | conservative | raw* ]
                [ wash | nowash* ]
                [ memlimit LIMIT ]
    (* marks defaults)

Where is it evident that “conservative” includes atm encapsulation? And what should a user expect that specifies “noatm conservative”?

	So Jonathan, please, instead of trying to argue obvious inconsistencies in the currently assigned encapsulation keywords away, just go and make sure they are consistent and well documented. 
	Your postings in the overhead-matter make me question whether you do fully understand the issue at hand in its full complexity; so by all means go and collect input from users (usability and self-evidence of the keywords) and experts (on the actual likelihood of encapsulations).

Best Regards
	Sebastian

  reply	other threads:[~2016-06-02 19:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-02  9:37 Kevin Darbyshire-Bryant
2016-06-02 14:22 ` Jonathan Morton
2016-06-02 14:27   ` Toke Høiland-Jørgensen
2016-06-02 14:49     ` Jonathan Morton
2016-06-02 15:42       ` moeller0
2016-06-02 17:40         ` Jonathan Morton
2016-06-02 18:53           ` moeller0
2016-06-02 18:55             ` Jonathan Morton
2016-06-02 19:17               ` moeller0 [this message]
2016-06-02 14:59     ` moeller0
2016-06-02 15:10       ` Jonathan Morton
2016-06-02 15:33         ` moeller0
2016-06-02 14:51   ` moeller0

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75FFB40F-2208-4039-A377-44C0959A6FB3@gmx.de \
    --to=moeller0@gmx.de \
    --cc=cake@lists.bufferbloat.net \
    --cc=chromatix99@gmail.com \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox