From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 42E943BA8E for ; Wed, 6 Dec 2017 03:10:24 -0500 (EST) Received: from [192.168.250.101] ([134.76.241.253]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MPlsg-1eQMfc1QZu-00513s; Wed, 06 Dec 2017 09:10:22 +0100 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) From: Sebastian Moeller In-Reply-To: Date: Wed, 6 Dec 2017 09:10:00 +0100 Cc: Jonathan Morton , Cake List Content-Transfer-Encoding: quoted-printable Message-Id: <7740436B-FB24-49D2-999C-DAFC0BA6890C@gmx.de> References: To: =?utf-8?Q?Dave_T=C3=A4ht?= X-Mailer: Apple Mail (2.3273) X-Provags-ID: V03:K0:Dw+zue7cc+9XASQW4P+ZKZdKAiUTt4o2I3qmVZcVYrXh/I0Mem2 Z8DfvIZ/5QdRD+u7nVCs8YOdMwxKkWJchcus8JAIm1s1lGF5Jml36BcmLrbqST5dP+ynjm1 E4SbO7DSiI0z873W5WFNqRzaUtoBwreobsZeUWrMYxCpGJZ1ehIEUjO4rfao7xpwtMDAJ9M 9n00B30brV3kdWhqxqzVA== X-UI-Out-Filterresults: notjunk:1;V01:K0:arev4bpMcK8=:nXrKjzKUptYp7djUhFdsIy NDFRE3jAErw7qj7QEmL/K6iW9GEppJ/tYSUzPE4ZgBus7mWATk0pLewJnzpGvEV2gDjhxHiGz nVa3a7o/aXcuENiS8g9inn+fyN4sjUgXxqBeMwhk8LQHbqVDBih7sY0EZSOw3VJ/VdkWwyaqT c4g/kmz2vkOfW2EALt6EtblbbKLgx2DB6fCrJykRX8Mcz2rJejn9lVsOcrpclQukBkMxOOWTl 35QnEbhRGx9p1Gjresc6f9/mMYQ6kAFPAVhLGOkupsR+w2IFnB8I9vaQ/rEU6N3MKoigZpgaI 0Wc+AqFh+e2szo+09CzDYuxtZTnTr0ci4tvKwxj5Cos8PP7PwZClXXhfvD0su7KZlLBvPeyg9 GTVJMV6+PU6nV6Baql1ZGrmYScEnbOuVvDtgwpJ+9hKfJRI5gTNQ9biVvQKeAoZh35gMHs9qX WoiufhQG1IB1YEQxZl+5ZZLvFN1uNjS9/hhxajTaJR3Ig9XV3Ch/m748EFcKP5Nj031tVk88Y yA+deK+7WZfAbiN8lHsNqwj5+//e2cKsH9Xg+/R3UWYckHPOasQ10aZkWM/Su7x2WyQzOJduH i4KJtRfy6GdWBiEWVrqVEQ/g4VfSep/mzidwT1qhUKmPD3liGSZ9J4h/R8tCMquDjfp4pG8Ad QRXctL2+EsQBd4CD90V4ANhhKUye7YJpVI95RlIzjHoCPVzbGzPkx+LhH2T5T3dm1yx99GVUn o84TQXc7ysSBA+txGhDZNACj7Ke9Y0AOoTLoQSIbgsYkGjzJm1qQaHCuqAXF5b6fQAqPY62rT x7xyBUeF391wcEOxPXeU+MMNom8o+83dvNITRNDmc8co+q+3lY23GCP3O0zl4oeJZk0C6iY Subject: Re: [Cake] set filtered acks to bulk mode X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Dec 2017 08:10:24 -0000 > On Dec 6, 2017, at 08:05, Dave Taht wrote: >=20 > On Tue, Dec 5, 2017 at 10:08 PM, Jonathan Morton = wrote: >> This is all sorts of wrong. >=20 > Going 1 out of 2 on untested patches for the day is not too horrible. >=20 > (sorry for crashing your router Ryan!!) >=20 >> First, setting the enum isn't sufficient to actually make the flow = bulk. >> You need to move it to the bulk queue-of-queues and update the stats >> counters too. That's probably why it's crashing for Ryan. >=20 > I had figured that would happen on the next round. :( >=20 >>=20 >> Second, I fail to see why this is necessary or even desirable. If = there are >> enough acks to activate the filter, then I assume it should be = treated as >> bulk already. Or, if the filter itself thins out the acks enough to = make it >> sparse, then it still makes sense to deliver those acks timely >=20 > Consider the case where you are emptying the queue on a regular basis. >=20 > As this is indeed, a bulk flow at this point, there is no need to give > it any extra boost. Mmmh, I guess I see Jonathan's point more clearly, if the = (egress) ack traffic is sparse treat it like that if it is not then not. = The fact that the non-filtered ACK queue would be treated as bulk, is I = believe immaterial. Well, unless we have data showing that your proposed mode actually works = better in real life. Data, I realize, for the acquisition of which you = would need the proposed change... This might be too complicated for me = ;) Best Regards Sebastian >=20 >> so as to >> maximise the reduced information they carry. Remember too that Codel >> implements head drop precisely to minimise the feedback lag via ack. >>=20 >> - Jonathan Morton >=20 >=20 >=20 > --=20 >=20 > Dave T=C3=A4ht > CEO, TekLibre, LLC > http://www.teklibre.com > Tel: 1-669-226-2619 > _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake