From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 573203B29E for ; Fri, 26 Jun 2020 09:11:52 -0400 (EDT) Received: by mail-lj1-x242.google.com with SMTP id 9so10288321ljv.5 for ; Fri, 26 Jun 2020 06:11:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=ykHvsTrqoFALeQLAnXWhfrYyHVdyurhRXFO7SGklR3U=; b=ZlHIlLXUkTteChc9njF9k76HLkkYX12vEgnIvEse4tOSY3NFYFNPJ/IJuqIFc/caDU pDqHNIZlCUd5EBPopgwW/61o6yZufgMNiSKVW8/L6OyGsaxx89AMkx3BZX3M6djMTwpj RVszREiLpf/GuxyB6srcuxJYPLnzbJWMJaQDpvTqvpUoq1DfbbE1syU3UuctGVkqhxpM NL4gD/qlkSdTQZ7XkUVr00aQiv02F07Oc2EU1meHKhGrtZcJk2y94d8ceOhoiEj+oHR5 qRj71Nt1b/txhSZvxhLW1k4IaEQP/bgt0nsMd0FKXumJGhCmLHyrIwDe1Da8Bt5LP4KN /06g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=ykHvsTrqoFALeQLAnXWhfrYyHVdyurhRXFO7SGklR3U=; b=AcXgrR+qTv0rb0Rpa4N4D99jmVbWqhNqBBdiXEdr7/nqIYhYCi5kqr8IkpYX9wS3Hf id3Y6n4erv8sPRI/VmHAoTZtffsusCDWDh7FCk9CYF8tJS7TrG30T0S92voI5VjsTGwR g23oNcHSeNhWjhU+pNoPsoCXZQTCsPUWo7R9b/3od0CLey0OTY/+bKcAPfjOcS4zMPzV OW9y/TwVMqwl3TvqPiepkBQ6S0kA4ITc/Keoqjb5n/a4PoqsOa6T6LR2ku84m8GC0oMh 9MZ2K6oGkoC334aopi6FmnRVnit1gJ9DGi5VVOgdPf3LcABG487AMVLqa+5rmcaAsKUd E47Q== X-Gm-Message-State: AOAM5336EGDQXImlu0qeINCCUh0zxmNnSk8tYX1psi+Uo2nTiCx5fvrn TaWgdSgDgGUypsnLx+VuXBI= X-Google-Smtp-Source: ABdhPJytdicbWQStHtdZwj3lg+5v5M/MlJjlKPxCcX4fuJA9l2DbvUZURhaCc97nc8P3PPVFceLcgQ== X-Received: by 2002:a2e:8747:: with SMTP id q7mr1328970ljj.459.1593177111264; Fri, 26 Jun 2020 06:11:51 -0700 (PDT) Received: from jonathartonsmbp.lan (83-245-237-85-nat-p.elisa-mobile.fi. [83.245.237.85]) by smtp.gmail.com with ESMTPSA id y188sm7910691lfc.36.2020.06.26.06.11.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Jun 2020 06:11:50 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.5\)) From: Jonathan Morton In-Reply-To: <240fc14da96a6212a98dd9ef43b4777a9f28f250.camel@redhat.com> Date: Fri, 26 Jun 2020 16:11:49 +0300 Cc: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , David Miller , cake@lists.bufferbloat.net, netdev@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <78C16717-5EB2-49BF-A377-21A9B22662E1@gmail.com> References: <159308610282.190211.9431406149182757758.stgit@toke.dk> <159308610390.190211.17831843954243284203.stgit@toke.dk> <20200625.122945.321093402617646704.davem@davemloft.net> <87k0zuj50u.fsf@toke.dk> <240fc14da96a6212a98dd9ef43b4777a9f28f250.camel@redhat.com> To: Davide Caratti X-Mailer: Apple Mail (2.3445.9.5) Subject: Re: [Cake] [PATCH net-next 1/5] sch_cake: fix IP protocol handling in the presence of VLAN tags X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jun 2020 13:11:52 -0000 Toke has already replied, but: > Sure, my proposal does not cover the problem of mangling the CE bit = inside > VLAN-tagged packets, i.e. if we should understand if qdiscs should = allow > it or not. This is clearly wrong-headed by itself. Everything I've heard about VLAN tags thus far indicates that they = should be *transparent* to nodes which don't care about them; they = determine where the packet goes within the LAN, but not how it behaves. = In particular this means that AQM should be able to apply congestion = control signals to them in the normal way, by modifying the ECN field of = the IP header encapsulated within. The most I would entertain is to incorporate a VLAN tag into the hashes = that Cake uses to distinguish hosts and/or flows. This would account = for the case where two hosts on different VLANs of the same physical = network have the same IP address. - Jonathan Morton