From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 723FF3CB35 for ; Wed, 20 Mar 2019 04:39:01 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1553071137; bh=we0AW8ZjxwcZIiw6XJZIF0y4HqPgMqeaSOev4qGzpDE=; h=X-UI-Sender-Class:Date:In-Reply-To:References:Subject:To:CC:From; b=ByWgcssaqvFexGVyOxOWGsjVicRxHjoBQuuCQwRzoiO3QoePT71YTf5BIKfH57kTP 14n2KolSYig1b0Bs+ofvH3Bn6R5fRaE9jMawNSsZfatEwU+ttiJDfW2nCyjDcTMTh4 5rk7i/fGgEeb1BStIndJLLUpzkmHrOJPjbCqdM7g= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.228.89] ([77.20.135.83]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MMkgl-1h5fwc0vwl-008ezA; Wed, 20 Mar 2019 09:38:57 +0100 Date: Wed, 20 Mar 2019 09:38:56 +0100 User-Agent: K-9 Mail for Android In-Reply-To: References: MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----7JYTMS7GTWMYNUR97EP8GPWP591HZQ" Content-Transfer-Encoding: 7bit To: cake@lists.bufferbloat.net, Kevin Darbyshire-Bryant , Ryan Mounce CC: Cake List From: Sebastian Moeller Message-ID: <7E711BD9-DE6A-4385-8A55-401812D998E8@gmx.de> X-Provags-ID: V03:K1:ecrK3MyL8dOb4CMFZjtal3FMhv/6P0+Kv0G/Jm3wo1rRskgTdYF 7ZKidHFLGgPNEHace3Ghr7peq5mmCFGSgH6e/cDXQ6DeeURQGHJuvnupAzEtMArp3tyG7f3 ndV6kRm2mNZbZpTeKbYOnOal65ClNE4nwxqEjj0qIFAx8IdiJ+wNfCSDU7R6535x9esz08f yiF9oI0vbOeQ8tD3zzF7w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:KkEoXrvzB+4=:0xTB+zfF5SRrhtN6o4Pm3T jd5Wq1LjdOvo+mVY7J1iGMYYgBfTPudYRQvxuuhcndcx8iXZ9uKQDatAnK9DqGWGa0lShrsM6 rSFwY+hASA7VdUdaZ2VIwp5+urREY/1/dSCMNhDbIHWwDWqwWHBHATOv6yKgxt5oKSYYnDhAP 9HoOkBAtl5RXV0/FK8zphP1lCKNmeESoX0A70crGh9/1oq25TYxDyNM0qIdp0lC/K5XI/+Kns Ng3xJ86tidETZv/B1kPRsW6mrCKBA//hXBtVSG8/Cf59JOrZ9rT1C6M0pzOS/G42pK+GaJ0NB ObieIbSaMz6ahKavK+cdoEYPRpzHGcUJX78oYxlVoBBZg3kdNaSHkr4hGJ0ScYBlPsHfFz/Bf baTojyiBWXjz1LLsLfC6UUYZgEEvfKfiJcfXtm6e1kLyGzhnwWLLtMhJ0I/qt8eJi2S+c1JKm L1lKnJX9viquFTrDjeQ1Rwsbg0Bj4V0btVgW8SS5wDJOgOMstrsDC5zuONT33I036RPx/OFfU J/XzRFgMMM5X/VS3WQK4bLi6hYGTY1+8IKntwkdezaikoURHtvg/4wcAyes3xuQIJ9G5/M75b NQkuVdZ2IYg4W3FupJXdQjJ17w1pdjlRIGncVDNwXQW2A3hbAjz5LuSaUJzi6bKBqRvhyr1+6 Vn4SmLb2ScDQfkEYEyleMiU4rQk32/f1Z/qmW6+CMwwYL1Yhs08VRC2u/QRYQ529OspyFyvmm 7xoycc/sI8quQtOyKf2Ts+uxRhZOjIvBAx6JzNpkzFeVgaQe0XEkrr8k0SZUCW0NjDuC7JMUy WMi1dxkWxWpBcW7PpUhEwaYVdYEaS7QkLpUa8PZMw6iELiaiCgNZmwHqpheILcWpxcibN8Vwh iDJFb9iBQYYBo7UfdfPhRqOxMIFZi2A7x2KLxOynWagb5CoREqLvmCtSjx4RT+aXev8seJqBX XKGTxLLdv3A== Subject: Re: [Cake] act_conndscp X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Mar 2019 08:39:01 -0000 ------7JYTMS7GTWMYNUR97EP8GPWP591HZQ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Kevin, Impressive! I had a look at your_layer_cake=2Eqos, and with half the brain= at my disposal currently, I am confused=2E I had thought the idea is to se= t dscp marks on internal hosts or the LAN interface ofva router and copy th= ose to incoming packets of the same flow, but you seem to set dscps in ingr= ess=2E What am missing? I ask because I fully bought your cool-aid ;) I want a "mode" for sqm scr= ipts where easy to set and control egress dscp from internal hosts is also = used for ingress packets of the same flows=2E I also bought your argument t= o preferably only do that once per flow hook line and sinker=2E AFAICT this is one feature that would solve a lot of issues regarding dscp= s in home networks=2E Especially in the light of how easy it turned out to = dscp mark packets on windows10, and a lot of the potential dscp users come = from the gaming crowd and need something that works on Windows=2E Sidenote,= I really like how easy win10 makes it to dscp marks all egress packets of = a given binary, I wish I knew a similarly straightforward way to do this in= Linux and macosx=2E=2E=2E=2E Thanks for this cool feature=2E=2E=2E=2E On March 20, 2019 9:25:31 AM GMT+01:00, Kevin Darbyshire-Bryant wrote: > > >> On 20 Mar 2019, at 03:31, Ryan Mounce wrote: >>=20 >> On Wed, 20 Mar 2019 at 07:57, Kevin Darbyshire-Bryant >> wrote: >>>=20 >>>=20 >>>=20 >>>> On 19 Mar 2019, at 21:24, Ryan Mounce wrote: >>>>=20 >>>> Hi Kevin, >>>>=20 >>>> I've finally applied your patches, compiled, and flashed on my >router=2E >>>> Could you share your tc filter action for conndscp to get me >started? >>>=20 >>> Ahh! Ooops yes knew I forgot something - here=E2=80=99s my hacked up >sqm-scripts/my_layer_cake=2Eqos >>=20 >> Okay=2E=2E=2E I've just spent far longer than I'd like to admit relearn= ing >> the basics of tc filter in order to minify my scripts, but everything >> is working now=2E See attached for my usage=2E I'm back to using the >> Turris Omnia which has more than enough grunt to handle my 100/40 >> link, so I haven't put much thought into optimisation=2E >>=20 >> The only gotcha I ran into with your patch is the explanation >>=20 >>> MODE get (typically ingress) set (typically egress) >>=20 >> This is backwards, but it's confusing anyway=2E 'get' also sets bits in >> the connmark while 'set' also gets bits from the connmark=2E > >Dammit! And yes it shows how confusing and how easy it is to get >confused with the get/set terminology=2E > >>=20 >> I'd suggest changing 'get' to 'save', and 'set' to 'restore'=2E >> > >Fortunately the patch was sent as an RFC to netdev and I=E2=80=99m sure t= hey=E2=80=99ll >have other things to fix/clarify at the same time=2E > >Thanks for putting your router/s in the testing firing line=2E So that= =E2=80=99s >at least two of us doing fun DSCP shenanigans on our routers :-) > > > >Cheers, > >Kevin D-B > >gpg: 012C ACB2 28C6 C53E 9775 9123 B3A2 389B 9DE2 334A > >_______________________________________________ >Cake mailing list >Cake@lists=2Ebufferbloat=2Enet >https://lists=2Ebufferbloat=2Enet/listinfo/cake --=20 Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E ------7JYTMS7GTWMYNUR97EP8GPWP591HZQ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Kevin,

Impressive! I had a look at your_= layer_cake=2Eqos, and with half the brain at my disposal currently, I am co= nfused=2E I had thought the idea is to set dscp marks on internal hosts or = the LAN interface ofva router and copy those to incoming packets of the sam= e flow, but you seem to set dscps in ingress=2E What am missing?
I ask b= ecause I fully bought your cool-aid ;) I want a "mode" for sqm scripts whe= re easy to set and control egress dscp from internal hosts is also used for= ingress packets of the same flows=2E I also bought your argument to prefer= ably only do that once per flow hook line and sinker=2E

AFAICT this = is one feature that would solve a lot of issues regarding dscps in home net= works=2E Especially in the light of how easy it turned out to dscp mark pac= kets on windows10, and a lot of the potential dscp users come from the gami= ng crowd and need something that works on Windows=2E Sidenote, I really lik= e how easy win10 makes it to dscp marks all egress packets of a given binar= y, I wish I knew a similarly straightforward way to do this in Linux and ma= cosx=2E=2E=2E=2E

Thanks for this cool feature=2E=2E=2E=2E

On March 20, 2019 9:25:31 AM GMT+01:00, Kevin Darby= shire-Bryant <kevin@darbyshire-bryant=2Eme=2Euk> wrote:


On 20 Mar 2019, at 03:31, Ryan Mounce <ryan@mounce=2Ecom=2Eau> w= rote:

On Wed, 20 Mar 2019 at 07:57, Kevin Darbyshire-Bryant
<k= evin@darbyshire-bryant=2Eme=2Euk> wrote:



On 19 Mar 2019, at 21:24, Ryan Mounce <ryan@mounce=2Ecom=2Eau>= wrote:

Hi Kevin,

I've finally applied your patches, compiled= , and flashed on my router=2E
Could you share your tc filter action for = conndscp to get me started?

Ahh! Ooops yes knew I forgo= t something - here=E2=80=99s my hacked up sqm-scripts/my_layer_cake=2Eqos

Okay=2E=2E=2E I've just spent far longer than I'd like t= o admit relearning
the basics of tc filter in order to minify my scripts= , but everything
is working now=2E See attached for my usage=2E I'm back= to using the
Turris Omnia which has more than enough grunt to handle my= 100/40
link, so I haven't put much thought into optimisation=2E

= The only gotcha I ran into with your patch is the explanation

MODE get (typically ingress) set= (typically egress)

This is backwards, but it's confusi= ng anyway=2E 'get' also sets bits in
the connmark while 'set' also gets = bits from the connmark=2E

Dammit! And yes it shows how= confusing and how easy it is to get confused with the get/set terminology= =2E


I'd suggest= changing 'get' to 'save', and 'set' to 'restore'=2E
<ryans-cake=2Etx= t>

Fortunately the patch was sent as an RFC to netde= v and I=E2=80=99m sure they=E2=80=99ll have other things to fix/clarify at = the same time=2E

Thanks for putting your router/s in the testing fir= ing line=2E So that=E2=80=99s at least two of us doing fun DSCP shenanigan= s on our routers :-)



Cheers,

Kevin D-B

gpg: 01= 2C ACB2 28C6 C53E 9775 9123 B3A2 389B 9DE2 334A
Cake mailing list
Ca= ke@lists=2Ebufferbloat=2Enet
https://lists=2Ebufferbloat=2Enet/listinfo/cake

--
Sent from my Android device with K-9 Mail= =2E Please excuse my brevity=2E ------7JYTMS7GTWMYNUR97EP8GPWP591HZQ--