[Cake] cobalt through checkpatch

[Cake] cobalt through checkpatch

[Dave Taht]

You will want to pull and rebase on top of this.

Are there any other patches still lying out of tree worth considering?

* retired cobalt.c
* made checkpatch considerably less unhappy
  (down to zero warnings and checks)
* I added a few comments as well.

Re: [Cake] cobalt through checkpatch

[Kevin Darbyshire-Bryant]

> On 21 Nov 2017, at 21:59, Dave Taht <dave@taht.net> wrote:
> 
> 
> You will want to pull and rebase on top of this.
> 
> Are there any other patches still lying out of tree worth considering?

Just did a PR for turning max_skblen (or whatever it is) to a u32….since there *are* super packets out there >64KB.

Opinions on doing a PR for LEDE so they can enjoy(/crash) the fruits of our latest cobalt.  They’re currently missing ingress mode & ack filtering filtering toys.

KDB


> 
> * retired cobalt.c
> * made checkpatch considerably less unhappy
>  (down to zero warnings and checks)
> * I added a few comments as well.
> _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake

Re: [Cake] cobalt through checkpatch

[Dave Taht]

Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> writes:

>> On 21 Nov 2017, at 21:59, Dave Taht <dave@taht.net> wrote:
>> 
>> 
>> You will want to pull and rebase on top of this.
>> 
>> Are there any other patches still lying out of tree worth considering?
>
> Just did a PR for turning max_skblen (or whatever it is) to a u32….since there *are* super packets out there >64KB.

There are?

> Opinions on doing a PR for LEDE so they can enjoy(/crash) the fruits of our latest cobalt.  They’re currently missing ingress mode & ack filtering filtering toys.

Nah. Let's get it into net-next first this time. I would hope for some
good comments.

Also, I *think* that that version will build on 4.9 without any backward
compatability cruft except for patching pkt_sched.h. Is lede fully 4.9 now?

>
> KDB
>
>
>> 
>> * retired cobalt.c
>> * made checkpatch considerably less unhappy
>>  (down to zero warnings and checks)
>> * I added a few comments as well.
>> _______________________________________________
>> Cake mailing list
>> Cake@lists.bufferbloat.net
>> https://lists.bufferbloat.net/listinfo/cake

Re: [Cake] cobalt through checkpatch

[Kevin Darbyshire-Bryant]

> On 23 Nov 2017, at 17:07, Dave Taht <dave@taht.net> wrote:
> 
> Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> writes:
>> 
>> Just did a PR for turning max_skblen (or whatever it is) to a u32….since there *are* super packets out there >64KB.
> 
> There are?
There are!  Well there were.  For a brief time someone enable GRO on the ag71xx switch in LEDE and to my surprise all of a sudden I saw tc via cake reporting >1514 max packet sizes.  More of a surprise was seeing the number occasionally going backwards :-)
> 
>> Opinions on doing a PR for LEDE so they can enjoy(/crash) the fruits of our latest cobalt.  They’re currently missing ingress mode & ack filtering filtering toys.
> 
> Nah. Let's get it into net-next first this time. I would hope for some
> good comments.
Fair enough-ski - either call I was more than happy with.
> 
> Also, I *think* that that version will build on 4.9 without any backward
> compatability cruft except for patching pkt_sched.h. Is lede fully 4.9 now?
Sadly some targets are still 4.4.  It’s being worked on.

Enjoy your few days break!

Cheers,

Kevin

Re: [Cake] cobalt through checkpatch

[Dave Taht]

On Thu, Nov 23, 2017 at 9:44 AM, Kevin Darbyshire-Bryant
<kevin@darbyshire-bryant.me.uk> wrote:
>
>
>> On 23 Nov 2017, at 17:07, Dave Taht <dave@taht.net> wrote:
>>
>> Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> writes:
>>>
>>> Just did a PR for turning max_skblen (or whatever it is) to a u32….since there *are* super packets out there >64KB.
>>
>> There are?
> There are!  Well there were.  For a brief time someone enable GRO on the ag71xx switch in LEDE and to my surprise all of a sudden I saw tc via cake reporting >1514 max packet sizes.  More of a surprise was seeing the number occasionally going backwards :-)
>>
>>> Opinions on doing a PR for LEDE so they can enjoy(/crash) the fruits of our latest cobalt.  They’re currently missing ingress mode & ack filtering filtering toys.
>>
>> Nah. Let's get it into net-next first this time. I would hope for some
>> good comments.
> Fair enough-ski - either call I was more than happy with.
>>
>> Also, I *think* that that version will build on 4.9 without any backward
>> compatability cruft except for patching pkt_sched.h. Is lede fully 4.9 now?
> Sadly some targets are still 4.4.  It’s being worked on.

Lordy: https://git.lede-project.org/?p=lede/hauke/staging.git;a=shortlog;h=refs/heads/kernel-4.14

>
> Enjoy your few days break!

A Merry Thanksgiving to all!  Logging out.

> Cheers,
>
> Kevin
>
> _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake



-- 

Dave Täht
CEO, TekLibre, LLC
http://www.teklibre.com
Tel: 1-669-226-2619