* [Cake] cake in lede-17.01 @ 2018-07-15 13:32 Georgios Amanakis 2018-07-15 14:43 ` Kevin Darbyshire-Bryant 0 siblings, 1 reply; 4+ messages in thread From: Georgios Amanakis @ 2018-07-15 13:32 UTC (permalink / raw) To: Cake Dear All, I backported cake as of commit c91b94f and tc-adv as of 3968731 (latest). I tested in a TP-Link WR-941NDv3 and everything looks ok, including the stats. Could someone take a look at the pull requests? https://github.com/openwrt/openwrt/pull/1180 https://github.com/openwrt/openwrt/pull/1179 Thank you, George ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Cake] cake in lede-17.01 2018-07-15 13:32 [Cake] cake in lede-17.01 Georgios Amanakis @ 2018-07-15 14:43 ` Kevin Darbyshire-Bryant 2018-07-15 16:13 ` Georgios Amanakis 0 siblings, 1 reply; 4+ messages in thread From: Kevin Darbyshire-Bryant @ 2018-07-15 14:43 UTC (permalink / raw) To: Georgios Amanakis; +Cc: Cake [-- Attachment #1: Type: text/plain, Size: 831 bytes --] > On 15 Jul 2018, at 14:32, Georgios Amanakis <gamanakis@gmail.com> wrote: > > Dear All, > > I backported cake as of commit c91b94f and tc-adv as of 3968731 > (latest). I tested in a TP-Link WR-941NDv3 and everything looks ok, > including the stats. > > Could someone take a look at the pull requests? > https://github.com/openwrt/openwrt/pull/1180 > https://github.com/openwrt/openwrt/pull/1179 I think would also need https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=3e81365141e4626522c616e7870d246594eff26d backported to 4.4 as well. > > Thank you, > George > _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake Cheers, Kevin D-B 012C ACB2 28C6 C53E 9775 9123 B3A2 389B 9DE2 334A [-- Attachment #2: Message signed with OpenPGP --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Cake] cake in lede-17.01 2018-07-15 14:43 ` Kevin Darbyshire-Bryant @ 2018-07-15 16:13 ` Georgios Amanakis 2018-07-15 16:43 ` Kevin Darbyshire-Bryant 0 siblings, 1 reply; 4+ messages in thread From: Georgios Amanakis @ 2018-07-15 16:13 UTC (permalink / raw) To: Kevin Darbyshire-Bryant; +Cc: Cake [-- Attachment #1: Type: text/plain, Size: 287 bytes --] I am not sure we need this in 4.4. In the patch we check for "d->tail->nla_type == padattr". However, all gnet_stats_copy*() are defined without a padding attribute. On top of that on a TP-Link WR-941ND (ar71xx) the stats appear fine. Any insight would be greatly appreciated. George [-- Attachment #2: Type: text/html, Size: 547 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Cake] cake in lede-17.01 2018-07-15 16:13 ` Georgios Amanakis @ 2018-07-15 16:43 ` Kevin Darbyshire-Bryant 0 siblings, 0 replies; 4+ messages in thread From: Kevin Darbyshire-Bryant @ 2018-07-15 16:43 UTC (permalink / raw) To: Georgios Amanakis; +Cc: Cake [-- Attachment #1: Type: text/plain, Size: 672 bytes --] > On 15 Jul 2018, at 17:13, Georgios Amanakis <gamanakis@gmail.com> wrote: > > I am not sure we need this in 4.4. > In the patch we check for "d->tail->nla_type == padattr". > However, all gnet_stats_copy*() are defined without a padding attribute. Hmm, I wonder how they handle attribute alignment on MIPS….or maybe just don’t care. > > On top of that on a TP-Link WR-941ND (ar71xx) the stats appear fine. Which would suggest “it just works”. Try adding/removing some extra config options. > > Any insight would be greatly appreciated. > > George > Cheers, Kevin D-B 012C ACB2 28C6 C53E 9775 9123 B3A2 389B 9DE2 334A [-- Attachment #2: Message signed with OpenPGP --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-15 16:43 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-07-15 13:32 [Cake] cake in lede-17.01 Georgios Amanakis 2018-07-15 14:43 ` Kevin Darbyshire-Bryant 2018-07-15 16:13 ` Georgios Amanakis 2018-07-15 16:43 ` Kevin Darbyshire-Bryant
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox