From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 579CC3CB35 for ; Thu, 27 Jan 2022 11:01:12 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1643299256; bh=Bt8OqLgnOxynRLY4b2b2o4iqKvPISP4pVOnQlE40P0Q=; h=X-UI-Sender-Class:Subject:From:In-Reply-To:Date:Cc:References:To; b=TmRhxbZnjdLWeK8AtacEJ8cY2Wjxnwhyk2/DWgDYS0FiGHFnsU3dI6u+Ozsbtgk3m ne87gvT76DJUbIYDeXb6O3bliXHP7jBuJTUm2eAmNKkPaSNyW+m3pA7I1p4BJ5WZKW Pik3thMZt62P2MzfQpUM7wE3eFfVN4cJnE6h1GbM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from smtpclient.apple ([77.8.117.92]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MRCKC-1msAZQ329s-00N8nl; Thu, 27 Jan 2022 17:00:56 +0100 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) From: Sebastian Moeller In-Reply-To: Date: Thu, 27 Jan 2022 17:00:54 +0100 Cc: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , Kevin Darbyshire-Bryant , cake@lists.bufferbloat.net, Jakub Kicinski , "David S . Miller" , netdev@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <82BBD116-4A04-4E19-9833-0DCB5134C73C@gmx.de> References: <20220125060410.2691029-1-matt@codeconstruct.com.au> <87r18w3wvq.fsf@toke.dk> <242985FC-238B-442D-8D86-A49449FF963E@gmx.de> To: Matt Johnston X-Mailer: Apple Mail (2.3654.120.0.1.13) X-Provags-ID: V03:K1:mHn1nyR0QjM3nDrP4h2GaDb4oo0n5u506IeJLiHOZX7NSGb6ujf vgUx78oY2I5h3cUmqeQx1W9OljmlDlQYgdzB3jBOawcYyExtnamDErbuwWxFKHePT+7q9JV Oisc33pcwrwTd5B3QEp+/7kgyo+vMmB9atwUekM8Vf6jVrWn1UwGPgAZfrxiSChE4bvF26d CjoIHKhzyU/mdyeZc3igg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:TZMT8aeK80E=:dr9EtUL9ZOEnRAKO83tyhI larrGUABQmYtEnKrCyVlVvbV5hbiBIthnUxqhFFtek7RIHujSPLTJEKl8hxuxj1ciqBpeMta7 i5KE1ijuismryE27Um3wOpPf8RsXha0YWNsV3l1r6dI/am2MLek7qQEnDK01Fugl22yuo6tkr f9i8u2azpC76lA64DmPE2RolbOrGRGlgLZNcNsWacWMoxW7tvA3NQJecFHTXvziQYyrTapHHu 67Glhapok8bjudoJ1iHOW1jU0gMsPfBfArKS4pbU322UV6+/588cMqeQZB4RteFsnY3fWHu/F T6/VcA3yB/1GYvE62gs0c3PqP1GcRobuOhAZX904ToLhDxBfadMTwQUGLlZZQ9Hd+VIlUJffJ d033wmmqAIFkVhI8s6ZPMU4QWXj0mVXowi3JSCDPHXqA2FAO0FvcvzugNvOXQ8b152rVqxtXL Svf0f7m2+WUv7k/dwUCMGTay17vOm5wcgr4zwhLUUFTyzI9GMR/z+BsAAPPZxIS2anN7ZGXd6 BSYxmE5kE12/JFyDv8XHsFIs372tIjW8rDoKWX59iA2VJkxYIyU6egPUX+WbppNG/Y76pt7S4 BjCXSpGDYhv/6xkojRiy/l4au+HhvMtYbIUmcgQsYdXUdTZhdTQpAU+Kn+8hj5XCIeh+NwyJ6 ly9isr0T+DiMwNAh1JHiXr0VvkM23EbN0mkR2inUHCGDUWzcKL9ZzQOZP/ybS7/PiMi1bQlrV 7PDriMcM0SccBOEPRMWLyQzo3srnxCalxCtoYhvuMJd61R1P4ZKdgZu2sVsQ44JkYmGlvZcjR v2H12MApYPgkC4K+YM9mBf55nx3efPf++r7kI5iEtBDCagrRLYuN/pTrck5yhfWrAjzfDEHoW PmLs1Kp0YL/R3wuZ+sEBYAt1EAlGgkgHcHo7SbVkLe/S3spuidr2DURDXiiCDfFXlqv1Diwgz FTp4CMppt7L6s1s1x2V/Tv/uXrWfsEe72fVZOhphdOG2ruJoaWICY6yaojZhSAeYiAx17rhFZ aU14re3uV2MeuLxAR75E+lOXiEfOw3Li2H7KzfoQki7RN3AjetldwbIETrrH+J3BZMdU7asRF 2c8s2gJBxQj9bg= Subject: Re: [Cake] [PATCH net] sch_cake: diffserv8 CS1 should be bulk X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jan 2022 16:01:12 -0000 Hi Matt, > On Jan 27, 2022, at 04:14, Matt Johnston = wrote: >=20 > On Tue, 2022-01-25 at 12:54 +0100, Sebastian Moeller wrote: >>=20 >> LE(1) is tin 0 the lowest >> CS1(8) is 1 slightly above LE >> CS0/BE(0) is 2 >> AF1x (10, 12, 14) are all in tin 1 as is CS1 > ... >> Just as documented in the code: >>=20 >> * Bog Standard (CS0 etc.) >> * High Throughput (AF1x, TOS2) >> * Background Traffic (CS1, LE) >=20 > The documentation doesn't match the code though. Since I did not see your original mail, only Toke's response, = which documentation is wrong here? > Almost, but it's off by one. I fully believe you, but could you spell it out by showing the = line of code and the line of documentation that are off? > I can submit a patch instead to change the docs, though it's not clear = the > divergence between code and docs was intended in the first place. >=20 > (diffserv8 also needs a description in the cake manpage, I'll send a = patch > for that once the order is clarified) Regards Sebastian >=20 > Cheers, > Matt >=20