From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70085.outbound.protection.outlook.com [40.107.7.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id B351B3B29E for ; Sun, 15 Jul 2018 16:13:14 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darbyshire-bryant.me.uk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=obr/kKB9aNYlDzh3pp5YR4r1opTmG4aDSziqCwFQ6rk=; b=ZpAs0JtRfTo47wePI9sDQ3/PpNmrA8kdU+I8fCJQpExSfD7aFCo83gKOlKPeK6/kz2hZsTmOcPvVkR0ndl+b01DkdGrSs+AnsoLTZiJ/uC66iSsDs7D2EsT4u2hQfGUucDz8rnUyMZLd6S+AZQJsuAy4F4sz7BVb++ZGxDRC96s= Received: from VI1PR07MB4254.eurprd07.prod.outlook.com (20.176.6.147) by VI1PR07MB1342.eurprd07.prod.outlook.com (10.164.92.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.13; Sun, 15 Jul 2018 20:13:11 +0000 Received: from VI1PR07MB4254.eurprd07.prod.outlook.com ([fe80::44fe:35ff:4978:fb9d]) by VI1PR07MB4254.eurprd07.prod.outlook.com ([fe80::44fe:35ff:4978:fb9d%3]) with mapi id 15.20.0973.013; Sun, 15 Jul 2018 20:13:11 +0000 From: Kevin Darbyshire-Bryant To: =?utf-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= CC: "cake@lists.bufferbloat.net" Thread-Topic: [Cake] Backporting 'tc class' support Thread-Index: AQHUG7zFHbVX+wbneUChyvqSQX//XaSPc7GAgACWrACAAK6rgA== Date: Sun, 15 Jul 2018 20:13:11 +0000 Message-ID: <83B2AEF4-C052-444F-8AFA-E8C3EE2F4A7F@darbyshire-bryant.me.uk> References: <8736wla3lq.fsf@toke.dk> <4C12C6A1-84E3-4B78-885F-F5C212CD13FF@darbyshire-bryant.me.uk> <87wotw96el.fsf@toke.dk> In-Reply-To: <87wotw96el.fsf@toke.dk> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-originating-ip: [193.240.142.133] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR07MB1342; 6:ae4NczCwgQ7rLkDNvvY7X0t5QNpiajsr3xa8hDmR/JpD09lXOxpam1K9G955P80YQw8K7MTro/41pM97zDPjEBlNL6iegpDZ4lcXT2E13RRWCWBGsqZyExIOhPyCrSTqh3mkAYcbJQMg0CBXEfwg2TJz4WUF3XF6ZqozaplErVpGdTcz+z0CnvPGUPsIuCRBM+MncRk0ypzl2HvyQVXvcxRyHzj58VZgFB+mmkYnfoLR36QPq3POFtfK9b88VFkMx2mstDoBiJjOTSPlj5GSmef7VikwAC+MFMWa6IM8qFmgl0h9jTrL6bqw80jiW310S0MnO/8Gi6peqJSs9jDZbkBnF45eORabEyTOgbgGOSJMCW303bVyrRylkg0ZzMvTMcB3orQgIhxLi8soRPyoMv7gLYGS/iKB9483ApJ9sCHtXgEFWsEPb80OZjdaW21FeQM2GghNJSusG+1UQqmvcg==; 5:j5UF69sDUH0QIDjh/a+3k4JeVIr7f02D/ebW1zcDCG8fi1KWthofUjnB/Dg0hi4J6g+hTJMKdNGaeoW7CXkxgzKOUhNjR8mS9/X/P6m6MClPjFG8lGvAmU9kazdt4J5yT7DHO3opO9Uh0BTjKdhZBTWCbj0cCHmd4Cfo1h0Og6g=; 7:b835g5fzyHocZAbvln7QOPlE6C3wUxQ2sHkJSpU8Ge7rZuLFc+RKzamfoKRnzDogn8vGvxDBoSOvqhGzeOnkatO2bIfzP8WaWCmjJaxVY7vsxPUK7+Y7c88rOcgzsHVA0HsZOAD+0HTg7tT7kPjw2VS0xT3q08xInNyI/V3c9bWKniZbXtP4WEhijfPVggek36qF3Zp/GJ3zx10RncSgFZvZiwXpkuvzaFYAMrbKCzC+XOp3eQCGb6gsu4SX4LDY x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 45243ea8-24c4-41e7-ff2f-08d5ea8f63af x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(7021125)(8989117)(5600053)(711020)(4534165)(7022125)(4603075)(4627221)(201702281549075)(8990107)(7048125)(7024125)(7027125)(7028125)(7023125)(2017052603328)(7153060)(49563074)(7193020); SRVR:VI1PR07MB1342; x-ms-traffictypediagnostic: VI1PR07MB1342: authentication-results: spf=none (sender IP is ) smtp.mailfrom=kevin@darbyshire-bryant.me.uk; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(102415395)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231311)(944501410)(52105095)(3002001)(93006095)(93001095)(149027)(150027)(6041310)(20161123562045)(20161123558120)(2016111802025)(20161123560045)(20161123564045)(6072148)(6043046)(201708071742011)(7699016); SRVR:VI1PR07MB1342; BCL:0; PCL:0; RULEID:; SRVR:VI1PR07MB1342; x-forefront-prvs: 07349BFAD2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39830400003)(346002)(136003)(376002)(366004)(396003)(189003)(199004)(11346002)(6512007)(305945005)(4326008)(76176011)(2900100001)(6246003)(99936001)(446003)(33656002)(83716003)(102836004)(68736007)(6506007)(6486002)(82746002)(6916009)(2906002)(7736002)(99286004)(476003)(6436002)(53546011)(5250100002)(66066001)(486006)(186003)(25786009)(6116002)(8676002)(5024004)(97736004)(5660300001)(3846002)(53936002)(106356001)(8936002)(2616005)(316002)(105586002)(86362001)(14454004)(81166006)(81156014)(229853002)(14444005)(36756003)(74482002)(26005)(478600001)(256004); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR07MB1342; H:VI1PR07MB4254.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: darbyshire-bryant.me.uk does not designate permitted sender hosts) x-microsoft-antispam-message-info: Y1DbBkiYjRIQVuie1Gv0QxJPL3Jn5TH6/CHnt2pIxVSk+hQq5Q8Y+Bpbn5cxyH5lv3fms+UMvGtwbt6xr2fmSRvBXseIXnoKI8osjqASbVXjvltkaQ7yjpbXYq9k0KQRyjV9Wk9dg7JG1s6/Z9vEXFM9yd7aFJnL4nk446XYcvdDywLBLyIV9eQSWFeCWF3TV8bzBO4bv03byGw5ZJGYs/gH+Lw5FVYWf4cTFPo6Znnmaa4oU09MIGDDa0OaZFGkSD8KP9bgsHVIMeqY4Ok8NACmMt5Ci0EjW0Ep1vieoM6LHKRwtEusmYNmH7E1LgdYt/SKUxmYU0QYrx4HtKgzf4kqC4HsE8Ff0Ib66fBA37U= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: multipart/signed; boundary="Apple-Mail=_35827907-CED3-4E96-B481-84BEF1F150C3"; protocol="application/pgp-signature"; micalg=pgp-sha256 MIME-Version: 1.0 X-OriginatorOrg: darbyshire-bryant.me.uk X-MS-Exchange-CrossTenant-Network-Message-Id: 45243ea8-24c4-41e7-ff2f-08d5ea8f63af X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2018 20:13:11.6134 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 9151708b-c553-406f-8e56-694f435154a4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR07MB1342 Subject: Re: [Cake] Backporting 'tc class' support X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 20:13:15 -0000 --Apple-Mail=_35827907-CED3-4E96-B481-84BEF1F150C3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 15 Jul 2018, at 10:48, Toke H=C3=B8iland-J=C3=B8rgensen = wrote: >=20 > Kevin Darbyshire-Bryant writes: >=20 >>> On 14 Jul 2018, at 22:50, Toke H=C3=B8iland-J=C3=B8rgensen = wrote: >>>=20 >>> Now that CAKE has been accepted upstream, I figured it was a good = time >>> to backport the 'tc class' support. So I did, back to kernel v4.9. >>>=20 >>> This is in the master branch; anyone feel like testing? With this, = the >>> version of CAKE in the master branch should be identical to the = version >>> that will be in Linux 4.19 :) >>=20 >> I need the attached patch to get it to build on openwrt - it looks >> like an include guard order thing. >=20 > Ah, right, thanks! Fixed in master :) And now that I=E2=80=99ve run it, with Georgios=E2=80=99 help (I=E2=80=99v= e never played with tc filters before!) I=E2=80=99ve fallen over a = wrinkle: So using sqm-scripts I have my standard cake instances on eth0 and = ifb4eth0, both using diffserv3 <<=E2=80=94 diffserv3 is important. This = creates according to tc -s qdisc Bulk, Best Effort & Voice tins. (where = is he going with this?) For =E2=80=98fun=E2=80=99 I wanted to classify stuff incoming to my = bittorrent port as Bulk. So you=E2=80=99d think that "tc filter add dev = ifb4eth0 parent 8011: protocol ip u32 match ip dport 6981 0xffff action = skbedit priority 8011:1=E2=80=9D would do the trick. 8011:1 being the = target tin. Whilst syntactically correct you=E2=80=99d be disappointed = by the result =E2=80=98cos=E2=80=A6..diffserv3 & 4 put the bulk traffic = in tin 2 although tc displays it as the first tin. This is a bit horrible. To fix we need to drop the =E2=80=98out of = order=E2=80=99 tin dump in cake, and tweak the column heading orders in = tc. e.g. from fprintf(f, " Bulk Best Effort = Voice\n"); to fprintf(f, " Best Effort Bulk = Voice\n"); and break the ABI in the process? I=E2=80=99ll go and fetch my coat. KDB --Apple-Mail=_35827907-CED3-4E96-B481-84BEF1F150C3 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEASyssijGxT6XdZEjs6I4m53iM0oFAltLqtcACgkQs6I4m53i M0ofVQ//Uv+NOVYlklJ2QTLp13P22ZGGZ9oaM/I6YlT+qm2kxa4ABOxl7qAWae/3 Ln9aUQ6UHFt2xiUQLHTroM4p8RDmDymtnxcqUZCN0jdCdWKkKsXszHmXtEVo9r+V 1CffI/zPSTn4C+6tg00hfn52/xl67deOWX2cu4kMXr3N0yNEUtStvJPQA6uidoG4 LvAyqQzh31siEli98qXut2+V1TXuRTv6MMXjowYwHeAVqM5Rar1JdbHXB9RACVXD nholBeG2LetaEBF4sMQwO/8KToHTHxaGy+C20e934/pHBvXcW/S439I3EN7lIBy/ bAhTuCpk16JPPdM8yzpjwoUox2FGe/jtj1NioFRm30d/6bhBkwMos6ZMi7UQOow6 GysbVcEP37s7w8aqmCm6WBvjpDK1+AcXzf9J062ZIWrT54Baw21pSRXnUYJ55XGm rFNxbnQPIbKge7HZ88xNP2+b9ACWyUS1yzOPrrqO01oU6NK39KyoXGqRNoM7fAWd EyQTYwIpOkhjMFT3lYYE4Av2Y6Ofas65DhJHRe2/btTWyOiXYxmRZ2RHoWcFJ3a9 EVmhSWvmQQIA2HsyV/TEXUj0mb6pTpweTh8E/4nWRQdaUGLtqs9B6gCWmiZN9K4M ZMPHn9lI0zWuwpmbnbOy36UGL38OmlAJsKzFKnHnA/XD0qHU/0U= =mPcJ -----END PGP SIGNATURE----- --Apple-Mail=_35827907-CED3-4E96-B481-84BEF1F150C3--