Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Jonathan Morton <chromatix99@gmail.com>
To: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
Cc: cake@lists.bufferbloat.net
Subject: Re: [Cake] de-natting & host fairness
Date: Wed, 28 Sep 2016 06:06:40 +0300	[thread overview]
Message-ID: <8555AC94-885C-41C1-BE12-40C3C3E96810@gmail.com> (raw)
In-Reply-To: <3c28ec73-36e7-dfed-fad8-1a694d4ceeca@darbyshire-bryant.me.uk>


> On 28 Sep, 2016, at 05:56, Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> wrote:
> 
> Does this need to be another variable/parameter or could it be the next bit along in the flow type?

I’ve already pushed it to the ‘cobalt’ branch, so you can see how I’ve done it and start testing.  I’ve verified that it compiles, no more than that so far.

For configuration, there is a separate flag parameter passed.  Internally, I’ve used another bit of the existing flow_mode field (but not the next one along).  The latter is also how the configuration is read back out again to tc.

Overall, the patch ended up much smaller than the original.  Switch statements in C are actually quite verbose.

 - Jonathan Morton


  reply	other threads:[~2016-09-28  3:06 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-26  3:20 Kevin Darbyshire-Bryant
2016-09-26  3:54 ` Dave Taht
2016-09-26  5:11   ` Dave Taht
2016-09-26  8:54 ` moeller0
2016-09-26 13:02   ` Kevin Darbyshire-Bryant
2016-09-26 13:28     ` moeller0
2016-09-26 14:06       ` Kevin Darbyshire-Bryant
2016-09-26 14:30       ` Jonathan Morton
2016-09-26 15:23         ` moeller0
2016-09-27  1:52 ` Noah Causin
2016-09-27  2:32   ` Kevin Darbyshire-Bryant
2016-09-27  4:20     ` Noah Causin
2016-09-27 14:52     ` Noah Causin
2016-09-27 15:28       ` Kevin Darbyshire-Bryant
2016-09-27 20:40         ` Noah Causin
2016-09-27 20:44           ` Jonathan Morton
     [not found]           ` <CAA93jw6rPE8aAGEiqf7jp3hc1J0ThrVer8PFmFLPBqANdtEixg@mail.gmail.com>
2016-09-27 20:58             ` Noah Causin
2016-09-28  4:38           ` Kevin Darbyshire-Bryant
2016-09-28  5:08             ` Noah Causin
2016-09-27 23:08 ` Jonathan Morton
2016-09-28  2:56   ` Kevin Darbyshire-Bryant
2016-09-28  3:06     ` Jonathan Morton [this message]
2016-09-28  3:33       ` Kevin Darbyshire-Bryant
2016-09-28  3:49         ` Jonathan Morton
2016-09-28  6:07       ` Kevin Darbyshire-Bryant
2016-09-28 11:08         ` Kevin Darbyshire-Bryant
2016-09-28 11:49           ` Dave Taht
2016-09-28 14:11             ` Kevin Darbyshire-Bryant
2016-09-28  5:56   ` Sebastian Moeller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8555AC94-885C-41C1-BE12-40C3C3E96810@gmail.com \
    --to=chromatix99@gmail.com \
    --cc=cake@lists.bufferbloat.net \
    --cc=kevin@darbyshire-bryant.me.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox