From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-x22d.google.com (mail-lf0-x22d.google.com [IPv6:2a00:1450:4010:c07::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 9CDA13B260 for ; Tue, 27 Sep 2016 23:06:45 -0400 (EDT) Received: by mail-lf0-x22d.google.com with SMTP id y6so38866411lff.1 for ; Tue, 27 Sep 2016 20:06:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=YcoOj9EH0x9n0YNs+YbnOHQ2zI6P2vmBeo+XsqD1WSg=; b=vP3NEPzDCym/3OhnPZ2YWc2LVbdMXjQ6ObFklE3pP7BhrC1vsiJ9K+H/YWvBTjk4iu b5lamtXkQRyq/pWUq7kJgCkRQbArCdhgxy+zJzHg3shfLcDq3aIhR7zIV7Dws+FpvfOj 7Om5t4IrUGRx2s/4mHAtcyrwzLnE4RT0kJpeX9WvVwEd7VxeHk3LQYAmWSwgujJAjhw0 ekCe+gBf4LdgC8kNZOnps4BJDLn8PuM/66sygeRS4zqE0gFStYbkf0UtekG0xx1KoEEq cmIPLkCrEaskAFrHxhMuvSibpCt5kWVXWx/tjtzMpBMfapvnpU5Er3H30uMSi+YXEtXx JYFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=YcoOj9EH0x9n0YNs+YbnOHQ2zI6P2vmBeo+XsqD1WSg=; b=SZOF/NiYVS6voWeb0XnUdHUhn9WjP7zRjUXHzXMZCAaeTULC6Fo7LZ0rAZP8D7V7vl kTx70KHHpBs2oJcFe0TbQJs8kBUxTALhcF7cH7F2YFcUk+Q3lZuIYiP8r5qoo/xsx+wD Ce+PEoLflTkaJdvPOJhrdzVFJeHXK0CTgm06fBpMJGz4Gz7TnR7InApZkZw5oqV5mGMA ZGQeC1VZz49J0DUSmfVgco3/PY525n9DTHMC2F75b3eVw6vV2Sil0HVagQ5vWKWZwdnK eP9qWyAx2QdjOrjk0Z5bjfyuT4BjJnJ1YG84ZbhN+ALQYdGYBv0w9ZJ9zdcTYyCM57A3 Mi+g== X-Gm-Message-State: AE9vXwM4WhSS3IPFf7yeVnwXQW+yXdAxfteoedGbTYx1uT24Kzee1i1915f0vDNSPRObEg== X-Received: by 10.25.212.5 with SMTP id l5mr12013117lfg.73.1475032004245; Tue, 27 Sep 2016 20:06:44 -0700 (PDT) Received: from [192.168.100.13] (37-33-90-35.bb.dnainternet.fi. [37.33.90.35]) by smtp.gmail.com with ESMTPSA id h14sm911312ljh.21.2016.09.27.20.06.43 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 27 Sep 2016 20:06:43 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) From: Jonathan Morton In-Reply-To: <3c28ec73-36e7-dfed-fad8-1a694d4ceeca@darbyshire-bryant.me.uk> Date: Wed, 28 Sep 2016 06:06:40 +0300 Cc: cake@lists.bufferbloat.net Content-Transfer-Encoding: quoted-printable Message-Id: <8555AC94-885C-41C1-BE12-40C3C3E96810@gmail.com> References: <3a99770e-6350-471f-72b6-b209d7d77d75@darbyshire-bryant.me.uk> <8425FD26-5C1F-42B5-9087-01D81E1ED7F5@gmail.com> <3c28ec73-36e7-dfed-fad8-1a694d4ceeca@darbyshire-bryant.me.uk> To: Kevin Darbyshire-Bryant X-Mailer: Apple Mail (2.3124) Subject: Re: [Cake] de-natting & host fairness X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Sep 2016 03:06:45 -0000 > On 28 Sep, 2016, at 05:56, Kevin Darbyshire-Bryant = wrote: >=20 > Does this need to be another variable/parameter or could it be the = next bit along in the flow type? I=E2=80=99ve already pushed it to the =E2=80=98cobalt=E2=80=99 branch, = so you can see how I=E2=80=99ve done it and start testing. I=E2=80=99ve = verified that it compiles, no more than that so far. For configuration, there is a separate flag parameter passed. = Internally, I=E2=80=99ve used another bit of the existing flow_mode = field (but not the next one along). The latter is also how the = configuration is read back out again to tc. Overall, the patch ended up much smaller than the original. Switch = statements in C are actually quite verbose. - Jonathan Morton