From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [IPv6:2001:470:dc45:1000::1]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 74AD03CB35 for ; Thu, 13 Sep 2018 10:22:26 -0400 (EDT) Date: Thu, 13 Sep 2018 16:22:24 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1536848545; bh=GbFd++qDYJGZ2I2vHv73DvfWUizCxR7Z7tHBrrB3iw4=; h=Date:In-Reply-To:References:Subject:To:CC:From:From; b=PXCQ3ehj5J3nUHHLelVKgFHeZWW360sdnqS1MJyhXIyoR0J7X12DVNgtACufPjBzE NZTo1YF73Ux4LhJ5d7OhczeCHFNBR9rOB8q2f9INXCoGVqvzntE8vdToMoSiYSZeYc kQivvuhmoL9g6T4d+VAXL0ceSLBQdZ0wQm/uRd6M4AeazmEa2FklASZIdWgGhEXwcZ aye/+QBpVvWxfv6bZdQ1AVmjJZnUzSwt5o8j5EVF/BPU41rk45UT9mURDEnvOT3M2J gr5JmX8ov8nPAxw85FgOOHtQyAO9yygvXl443QoJuKdu2IUpPBIMs9K6vxC22v3i/d AkiqA6WE+AxlQ== In-Reply-To: <5dc16f03-7cd2-f797-1bda-592d5f5462b5@gmail.com> References: <153670437243.12756.693381878569982309.stgit@alrua-kau> <5dc16f03-7cd2-f797-1bda-592d5f5462b5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable To: Eric Dumazet ,netdev@vger.kernel.org CC: cake@lists.bufferbloat.net,Eric Dumazet From: =?ISO-8859-1?Q?Toke_H=F8iland-J=F8rgensen?= X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <85765D69-F7BA-48A8-9954-595DEA22EE37@toke.dk> Subject: Re: [Cake] [PATCH net] gso_segment: Reset skb->mac_len after modifying network header X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Sep 2018 14:22:26 -0000 On 13 September 2018 16:11:18 CEST, Eric Dumazet wrote: > > >On 09/11/2018 03:19 PM, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> When splitting a GSO segment that consists of encapsulated packets, >the >> skb->mac_len of the segments can end up being set wrong, causing >packet >> drops in particular when using act_mirred and ifb interfaces in >> combination with a qdisc that splits GSO packets=2E >>=20 >> This happens because at the time skb_segment() is called, >network_header >> will point to the inner header, throwing off the calculation in >> skb_reset_mac_len()=2E The network_header is subsequently adjust by the >> outer IP gso_segment handlers, but they don't set the mac_len=2E >>=20 >> Fix this by adding skb_reset_mac_len() calls to both the IPv4 and >IPv6 >> gso_segment handlers, after they modify the network_header=2E >>=20 >> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen > >Looks good but I would have appreciated a thanks or something >after the help I gave on this problem=2E Yes, of course=2E Should have mentioned that in the commit message=2E My apologies, won't happen again=2E And thanks! :) -Toke