From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Jonathan Morton <chromatix99@gmail.com>
Cc: cake@lists.bufferbloat.net
Subject: Re: [Cake] [PATCH] Keep an internal counter for total queue length
Date: Fri, 06 Jul 2018 15:27:47 +0200 [thread overview]
Message-ID: <871scgbijw.fsf@toke.dk> (raw)
In-Reply-To: <B10A18E5-B122-4D4C-B47E-7ECA0E9084CC@gmail.com>
Jonathan Morton <chromatix99@gmail.com> writes:
>> On 6 Jul, 2018, at 4:21 pm, Toke Høiland-Jørgensen <toke@toke.dk> wrote:
>>
>>> I'm handling it without using any extra permanent state, just making
>>> use of what's already there. Take a look at latest commit.
>>
>> Yup, that also fixes the infinite loop issue. I'm fine with doing it
>> this way; however, it doesn't handle the other places where we check
>> whether sch->q.qlen is nonzero. Are you sure that is not going to give
>> us more problems down the road? :)
>
> The other places are checking whether the queue is empty for the
> purposes of updating the shaper state. They are therefore much less
> critical, and I think self-correcting.
Right, cool. In that case I think we are good to go for another upstream
submission; I'll get that done later today :)
-Toke
next prev parent reply other threads:[~2018-07-06 13:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 11:57 Toke Høiland-Jørgensen
2018-07-06 12:00 ` Toke Høiland-Jørgensen
2018-07-06 12:45 ` Jonathan Morton
2018-07-06 13:21 ` Toke Høiland-Jørgensen
2018-07-06 13:23 ` Jonathan Morton
2018-07-06 13:27 ` Toke Høiland-Jørgensen [this message]
2018-07-07 7:07 ` Dave Taht
2018-07-07 11:57 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871scgbijw.fsf@toke.dk \
--to=toke@toke.dk \
--cc=cake@lists.bufferbloat.net \
--cc=chromatix99@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox