From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <toke@toke.dk>
Received: from mail.toke.dk (mail.toke.dk [IPv6:2001:470:dc45:1000::1])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id 167CE3B2A4
 for <cake@lists.bufferbloat.net>; Fri,  6 Jul 2018 09:27:50 -0400 (EDT)
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023;
 t=1530883669; bh=57ypDD/RgyE9VzSU01BaUDP/Fn6SGxZXpLx88W//be8=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=GONsIDaPCUILl6epVaK3uA3oZw8rJcS3DDSdOFpmztMRPY8Nb3hOFvAeNc2Ghivqq
 lB1WIb9WR3F/gCMI+r3CqYT7/DfLGBd8u++r6ArpkGOP2b4WsnhxHcj1UBNhesPQMI
 KpOsUVuhdjOUI4Yrnac682s4J9Myc49BDecXkeT0DWDmChYxJ3Fi4VWR1Vpu3G5smB
 gI+9PauK01bVRnHbl2CYhS8aMCE+wyL1ieTn7SX6M7oMWvU3N786gQ7KG8Xq3vRa1W
 zdwMXQfKzliYEsFGQGiEXlJupcjlIzljVSG3oyAzlYR0dUUQH8w6tKvlzH3C4SlVJq
 Tq4R+DTSWh9HQ==
To: Jonathan Morton <chromatix99@gmail.com>
Cc: cake@lists.bufferbloat.net
In-Reply-To: <B10A18E5-B122-4D4C-B47E-7ECA0E9084CC@gmail.com>
References: <20180706115745.2791-1-toke@toke.dk> <87a7r4bmlk.fsf@toke.dk>
 <D0961B2E-DC81-449E-81A3-5269A7DF08F0@gmail.com> <874lhcbiux.fsf@toke.dk>
 <B10A18E5-B122-4D4C-B47E-7ECA0E9084CC@gmail.com>
Date: Fri, 06 Jul 2018 15:27:47 +0200
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <871scgbijw.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Cake] [PATCH] Keep an internal counter for total queue length
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Fri, 06 Jul 2018 13:27:50 -0000

Jonathan Morton <chromatix99@gmail.com> writes:

>> On 6 Jul, 2018, at 4:21 pm, Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.=
dk> wrote:
>>=20
>>> I'm handling it without using any extra permanent state, just making
>>> use of what's already there. Take a look at latest commit.
>>=20
>> Yup, that also fixes the infinite loop issue. I'm fine with doing it
>> this way; however, it doesn't handle the other places where we check
>> whether sch->q.qlen is nonzero. Are you sure that is not going to give
>> us more problems down the road? :)
>
> The other places are checking whether the queue is empty for the
> purposes of updating the shaper state. They are therefore much less
> critical, and I think self-correcting.

Right, cool. In that case I think we are good to go for another upstream
submission; I'll get that done later today :)

-Toke