Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Dave Taht <dave@taht.net>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: Dave Taht <dave.taht@gmail.com>,  cake@lists.bufferbloat.net
Subject: Re: [Cake] [RFC PATCH 3/3] Add support for building the new cake qdisc
Date: Fri, 17 Nov 2017 11:55:23 -0800	[thread overview]
Message-ID: <871skw1xzo.fsf@nemesis.taht.net> (raw)
In-Reply-To: <87bmk0btir.fsf@toke.dk> ("Toke \=\?utf-8\?Q\?H\=C3\=B8iland-J\?\= \=\?utf-8\?Q\?\=C3\=B8rgensen\=22's\?\= message of "Fri, 17 Nov 2017 20:21:48 +0100")



Toke Høiland-Jørgensen <toke@toke.dk> writes:

> Dave Taht <dave.taht@gmail.com> writes:
>
>> ---
>>  net/sched/Kconfig  | 11 +++++++++++
>>  net/sched/Makefile |  1 +
>>  2 files changed, 12 insertions(+)
>>
>> diff --git a/net/sched/Kconfig b/net/sched/Kconfig
>> index c03d86a..3ea22e5 100644
>> --- a/net/sched/Kconfig
>> +++ b/net/sched/Kconfig
>> @@ -284,6 +284,17 @@ config NET_SCH_FQ_CODEL
>>  
>>  	  If unsure, say N.
>>  
>> +config NET_SCH_CAKE
>> +	tristate "Common Applicatons Kept Enhanced (CAKE)"
>> +	help
>> +	  Say Y here if you want to use the CAKE
>> +	  packet scheduling algorithm.
>> +
>> +	  To compile this driver as a module, choose M here: the module
>> +	  will be called sch_cake.
>> +
>> +	  If unsure, say N.
>> +
>>  config NET_SCH_FQ
>>  	tristate "Fair Queue"
>>  	help
>> diff --git a/net/sched/Makefile b/net/sched/Makefile
>> index 5b63544..3a0743a 100644
>> --- a/net/sched/Makefile
>> +++ b/net/sched/Makefile
>> @@ -50,6 +50,7 @@ obj-$(CONFIG_NET_SCH_CHOKE)	+= sch_choke.o
>>  obj-$(CONFIG_NET_SCH_QFQ)	+= sch_qfq.o
>>  obj-$(CONFIG_NET_SCH_CODEL)	+= sch_codel.o
>>  obj-$(CONFIG_NET_SCH_FQ_CODEL)	+= sch_fq_codel.o
>> +obj-$(CONFIG_NET_SCH_FQ_CODEL)	+= sch_cake.o
>
> I read somewhere that copy/paste errors most often occur at the last
> line of a pasted piece of code...

Yep!

I did not necessarily intend these commits to work, I just wanted stuff
in a format I could *read*.

I'll fix in a v2.

My next mission, such as it is, is to go back to the last version of
pre-cobalt cake I understood, and try to compare the two.

>
> -Toke
> _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake

      reply	other threads:[~2017-11-17 19:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-17 19:11 [Cake] [RFC PATCH 0/3] Cake patches for net-next Dave Taht
2017-11-17 19:11 ` [Cake] [RFC PATCH 1/3] Add cake to pkt_sched.h Dave Taht
2017-11-17 19:11 ` [Cake] [RFC PATCH 2/3] Add cake related includes and source files Dave Taht
2017-11-17 19:52   ` Dave Taht
     [not found]     ` <91830311-fea3-cb03-be2e-b132ae54ad89@gmail.com>
2017-11-21 18:59       ` Dave Taht
     [not found]     ` <dbf49d41-27e1-5d4c-ad23-093d3d2d442e@gmail.com>
2017-11-21 19:03       ` Dave Taht
     [not found]     ` <f7a57f62-9b61-5e4f-6734-dc92f2758d2f@gmail.com>
2017-11-21 19:04       ` Dave Taht
     [not found]     ` <fe13b27c-223f-f9d2-b153-44fbe388ff50@gmail.com>
2017-11-21 19:05       ` Dave Taht
     [not found]     ` <5fbd8b62-f557-d9f6-0396-8bd9135b7c74@gmail.com>
2017-11-21 19:07       ` Dave Taht
2017-11-17 19:11 ` [Cake] [RFC PATCH 3/3] Add support for building the new cake qdisc Dave Taht
2017-11-17 19:21   ` Toke Høiland-Jørgensen
2017-11-17 19:55     ` Dave Taht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871skw1xzo.fsf@nemesis.taht.net \
    --to=dave@taht.net \
    --cc=cake@lists.bufferbloat.net \
    --cc=dave.taht@gmail.com \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox