From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [52.28.52.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 1E0E93CB3C for ; Sun, 11 Mar 2018 17:22:23 -0400 (EDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1520803341; bh=TdnRr0Wtip46TsNc7Ih1YrPjrbhzV0wTZnSOrYW2GYg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=HO9cFgY8V+lFXi4OmUmvz7FuypvyH/n+B1t4AULWni5hWxUJknPa3KQLE2w9nUdRk 0cee7fBS84wN0YQjA2wXGvYSO9JR/PRbGLLRxKfe6Zlx9NT6Rj/aas2r/WQWVuGdeK sK2cYbn7Pic1LUkP4cfUv+n5xYYU0BQXbFpl/6ju4MgLz7SdiaBpf+gyzVbguqCTEv WppMcTLHMvO8iM6W6INIRXIXd7+sQGM7SGPdUlsvebNTrSGYzgySP2fPytIP/bt+kV 7g46QHjI8Ex/FIdVMOBgqlGcdXEXP+i3gtgDsyEUzYwcWmriK5yRxlRTI9UXwrGpfE dp+3V3ZImbyUQ== To: Kevin Darbyshire-Bryant Cc: "cake\@lists.bufferbloat.net" In-Reply-To: References: <20180311091930.86264-1-ldir@darbyshire-bryant.me.uk> <20180311091930.86264-3-ldir@darbyshire-bryant.me.uk> <878tayjpzp.fsf@toke.dk> Date: Sun, 11 Mar 2018 22:22:21 +0100 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <873716joj6.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH 2/2] tc print_uint format fixes X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Mar 2018 21:22:23 -0000 Kevin Darbyshire-Bryant writes: >> On 11 Mar 2018, at 20:50, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >>=20 >> Kevin Darbyshire-Bryant writes: >>=20 >>> Signed-off-by: Kevin Darbyshire-Bryant >>> --- >>> tc/tc_qdisc.c | 3 ++- >>> tc/tc_util.c | 24 ++++++++++++------------ >>> 2 files changed, 14 insertions(+), 13 deletions(-) >>=20 >> Care to submit this to upstream iproute2? Amending the commit message >> with an explanation of why the change is needed and sending the same >> patch to netdev@vger.kernel.org should be enough, I think :) > > I wanted a sanity check first :-) And there=E2=80=99s more to do. A LOT= more! > > Is it sane? Apart from the fact that it is really grating that a function called "print_uint()" needs this weird 64-bit format string include. But that is probably an issue that upstream should deal with. Also, the inttypes.h include is missing from tc_util.c in your patch... Other than that, compiles and works for me on x86_64... -Toke