From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dave@taht.net>
Received: from mail.taht.net (mail.taht.net
 [IPv6:2a01:7e00::f03c:91ff:feae:7028])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id 7EB173BA8E
 for <cake@lists.bufferbloat.net>; Sun, 26 Nov 2017 13:19:46 -0500 (EST)
Received: from nemesis.taht.net (unknown
 [IPv6:2603:3024:1536:86f0:2e0:4cff:fec1:1206])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.taht.net (Postfix) with ESMTPSA id 3448D21473;
 Sun, 26 Nov 2017 18:19:45 +0000 (UTC)
From: Dave Taht <dave@taht.net>
To: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
Cc: Jonathan Morton <chromatix99@gmail.com>,
 Cake List <cake@lists.bufferbloat.net>
References: <5816D8EC-71EF-43FF-95A5-1B061B329701@darbyshire-bryant.me.uk>
 <CAJq5cE1K0OQmqifjZg1kDW0biOoF6OZVbAHi_LCy0n0LAYYdcQ@mail.gmail.com>
 <E028C982-F7FF-4633-A68C-2741216F58AE@darbyshire-bryant.me.uk>
Date: Sun, 26 Nov 2017 10:19:43 -0800
In-Reply-To: <E028C982-F7FF-4633-A68C-2741216F58AE@darbyshire-bryant.me.uk>
 (Kevin Darbyshire-Bryant's message of "Sun, 26 Nov 2017 10:03:16
 +0000")
Message-ID: <873750x5q8.fsf@nemesis.taht.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Cake] RFC: allocate without the gotos
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Sun, 26 Nov 2017 18:19:46 -0000

Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> writes:

>> On 26 Nov 2017, at 10:00, Jonathan Morton <chromatix99@gmail.com> wrote:
>>=20
>> On a purely theoretical basis, it probably isn't as fast, because now the
>> 'found' condition has to be tested multiple times on the fast and slow p=
aths
>> alike.  Only if the compiler is smart enough to transform it back the wa=
y it
>> was=E2=80=A6
> It was done as a =E2=80=98for sh*ts=E2=80=99n=E2=80=99giggles=E2=80=99 ex=
ercise=E2=80=A6.which is probably why I haven=E2=80=99t even tried compilin=
g it :-)
>>=20
>> ...and IMHO the goto version is easier to read too.
> I definitely agree with that!

gotos we stick with, then.

>>=20
>> - Jonathan Morton
>
>
> _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake