From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <toke@toke.dk>
Received: from mail.toke.dk (mail.toke.dk [IPv6:2a00:7660:6da:2001::664])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id CF32E3B2A4
 for <cake@lists.bufferbloat.net>; Fri,  1 Mar 2019 06:01:27 -0500 (EST)
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023;
 t=1551438086; bh=ipJSTkFnG7NwiNEorZ0x42dR8JtwMlZbieYHPunyBr8=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=xFRZBC8pl70dY7AT46wrKMFRRr1Aogg+3VZsCWE4ciQqXiftAVp2HoY7JqlYdGXQA
 Zclmg+rap6oAbDlJg/wUcRlMvO1G8WWXwW9NS+A/tZ9awWY7FVD2prU7e3EK9KM1Tb
 CL1M/K9H/IZWFrWyakNjMnIPu+jVj4gVHZ+DcIqHBf1fWQHDc0Fqggyu5BrO6sbfpm
 YVCjl1CPeXzItj4luN+0ZRrJOavkVMX87Ms2FBrDB2l8F3mLnkLNV3dEABNkzGeyrr
 y9skKNktAYP9I83XWrTPAKnlgkPqAqaNtvLKOB35Fxn6tGT0WP9v6fa3z2tFuXNyRs
 XxFKFYmhaR8kw==
To: Pete Heist <pete@heistp.net>
Cc: cake@lists.bufferbloat.net
Subject: Re: [Cake] Upstream submission of dual-mode fairness patch
In-Reply-To: <72193310-7502-47B8-9554-7F8F9FA23204@heistp.net>
References: <mailman.1788.1551352661.3538.cake@lists.bufferbloat.net>
 <72193310-7502-47B8-9554-7F8F9FA23204@heistp.net>
Date: Fri, 01 Mar 2019 12:01:25 +0100
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <874l8mn9iy.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-List-Received-Date: Fri, 01 Mar 2019 11:01:28 -0000

Pete Heist <pete@heistp.net> writes:

> Thanks for the nudge... I just tested this on the original one-armed
> router setup I encountered it on (3.16.7, routing from eth0 to
> eth0.3300). The patch makes a big improvement over the original (which
> was around 10/80):
>
> IP 1, 1 up: 47.0 Mbit
> IP 2, 8 up: 47.0 Mbit
> IP 1, 8 down: 46.7 Mbit
> IP 2, 1 down: 46.6 Mbit
>
> Curiously, if my one-armed router has cake applied on egress and
> ingress of eth0.3300, instead of egress of eth0 and egress of
> eth0.3300 as above, some reduction in fairness occurs, but only for
> the downstream flows. This increases with the number of flows:
>
> IP 1, 1 up: 47.2 Mbit
> IP 2, 8 up: 47.2 Mbit
> IP 1, 8 down: 44.5 Mbit
> IP 2, 1 down: 48.7 Mbit
>
> IP 1, 1 up: 47.0 Mbit
> IP 2, 16 up: 47.0 Mbit
> IP 1, 16 down: 42.6 Mbit
> IP 2, 1 down: 50.3 Mbit
>
> IP 1, 1 up: 47.2 Mbit
> IP 2, 32 up: 47.0 Mbit
> IP 1, 32 down: 41.4 Mbit
> IP 2, 1 down: 51.3 Mbit
>
> It still happens when ether-vlan is used on the leaf qdiscs with vlan
> traffic.

Hmm, I have no good explanation for this...

> That said, unless there=E2=80=99s an obvious reason for this that=E2=80=
=99s fixable,
> I=E2=80=99m fine with how it is, considering the improvement. :)

Cool! And you haven't seen any regressions in other usage? :)

-Toke