From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <toke@toke.dk>
Received: from mail.toke.dk (mail.toke.dk [52.28.52.200])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id 760D13B29E
 for <cake@lists.bufferbloat.net>; Tue, 24 Apr 2018 11:41:33 -0400 (EDT)
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023;
 t=1524584492; bh=JVQkgquIan+U6bkmMxw0kxAszsw7rkgJ6AiPM9rFpLs=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=OHDjRRYjKbi6bJO0tLQc3MohijW9zaFgLQKrPTTmlLDSNasd6lOoCgFTDjVsS4ksR
 HQBqHxRaK0OePK39knU/kFMiPL5SuLA5HFhoTp9eJwyh15v7X9Iw2w109vgRIvZOqP
 rswgzIbr5YNF3BOQMIt/KIFANi+yktgIE5woY2P2VTfGxTL/XU+Y6qD/2JicFOJhcc
 od7/CRXJl0oUS+dymPSv7KfPXY3w8qUqorll/SVqcTDBnisnhbcV6fl2qMcF+eMy+U
 no+ka7MyZLuVd490kVGesl50lCAq4v/WqObIhpievzOFZdfN5EwIe/ZDfuGIMqQAKA
 1CrHYLeusZI5g==
To: Georgios Amanakis <gamanakis@gmail.com>
Cc: Cake List <cake@lists.bufferbloat.net>, netdev@vger.kernel.org
In-Reply-To: <CACvFP_hEv_cEPKFxz+7X5mvwbM+4oTOAxMcW52b51qYUpez1ow@mail.gmail.com>
References: <1512338775-3270-1-git-send-email-dave.taht@gmail.com>
 <20180424114407.5939-1-toke@toke.dk> <20180424081406.5127f1bc@xeon-e3>
 <CACvFP_hEv_cEPKFxz+7X5mvwbM+4oTOAxMcW52b51qYUpez1ow@mail.gmail.com>
Date: Tue, 24 Apr 2018 17:41:32 +0200
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <874lk07gsz.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Cake] [PATCH net-next v2] Add Common Applications Kept
	Enhanced (cake) qdisc
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Tue, 24 Apr 2018 15:41:33 -0000

Georgios Amanakis <gamanakis@gmail.com> writes:

> On Tue, 24 Apr 2018 13:44:06 +0200
> Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk> wrote:
>
>> +config NET_SCH_CAKE
>> +       tristate "Common Applications Kept Enhanced (CAKE)"
>> +       help
>> +         Say Y here if you want to use the Common Applications Kept Enh=
anced
>> +          (CAKE) queue management algorithm.
>> +
>> +         To compile this driver as a module, choose M here: the module
>> +         will be called sch_cake.
>
> In net/sched/Kconfig we should probably add NF_CONNTRACK as a dependency:
> "depends on NF_CONNTRACK"
>
> Otherwise if NET_SCH_CAKE=3Dy and NF_CONNTRACK=3Dm compilation fails with:
>
> net/sched/sch_cake.o: In function `cake_enqueue':
> sch_cake.c:(.text+0x3e10): undefined reference to `nf_ct_get_tuplepr'
> sch_cake.c:(.text+0x3e3a): undefined reference to `nf_conntrack_find_get'
> make: *** [Makefile:1041: vmlinux] Error 1

Hmm we really don't want to have a hard depend on conntrack. We
currently ifdef the conntrack-specific bits thus:
#if IS_ENABLED(CONFIG_NF_CONNTRACK).

Does anyone know if there is a way to do this so the module/builtin
split doesn't bite us?

-Toke