From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [52.28.52.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 5F32D3B2A4 for ; Wed, 22 Nov 2017 02:46:45 -0500 (EST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1511336802; bh=XGKr3yjkdWWc/XMmGy5eu06RiFkPEk2K0HxIWk86V/8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=p+S4YdbDgIrMiGH/oSbIUmR4Qm+sD/OpkBCj38n89TQCwtlPtjOfyeD45WvLAd276 fd3lUGAjvsSIZh2FFDI5ypyTLhuLL27J1IorFJrP+3SHg7aucj7ke6BGFPIq5zezpI LXgVEK481flL00r+c3AbxVL7EZEzABGwdnc4QGrteY43ZhIB/bbvvEhxwip4Y+HW+E CULtKkU/bY3Vq49TCWNtylIk/mHuwRqv5bl8P4ElofZEQYy9j39Fi+27ovlON4LsT5 Yxx6PIcQb8q6MH6Lkn235eRBVWKid8G2o6Y6Qmq1URTtxU0dhnvnne/sQjxSm0kGc0 59vPsEidPRG6g== To: Dave Taht , Dave Taht Cc: cake@lists.bufferbloat.net In-Reply-To: <87wp2jrv1f.fsf@nemesis.taht.net> References: <1511309382-24060-1-git-send-email-dave.taht@gmail.com> <1511309382-24060-3-git-send-email-dave.taht@gmail.com> <87wp2jrv1f.fsf@nemesis.taht.net> Date: Wed, 22 Nov 2017 08:46:11 +0100 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <874lpmah8c.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH 2/3] Add Common Applications Kept Enhanced (sch_cake) qdisc X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Nov 2017 07:46:45 -0000 Dave Taht writes: > And now I can comment. > > I've added this version to a for_upstream branch in the hope that future > commits can be kept in sync. > > Is there anything more that should be added to the commit message? > Should I be less snarky? > >> while presenting an API simple enough that even an ISP can configure >> it. I chuckled at this part at least. I'd say keep it ;) >> Example of use on an ISP uplink: >> >> tc qdisc add dev eth0 cake bandwidth 20Mbit nat docsis ack-filter >> >> Cake can also be used in unlimited mode to drive packets at the speed >> of the underlying link. >> >> Cake is filled with: >> >> * A hybrid Codel/Blue AQM algorithm, =E2=80=9CCobalt=E2=80=9D, tied to a= n FQ_Codel >> derived Flow Queuing system, which autoconfigures based on the bandwid= th. >> * A unique "triple-isolate" mode (the default) which balances per-flow >> and per-host flow FQ even through NAT. >> * An integral deficit based shaper with extensive dsl and docsis support >> that can also be used in unlimited mode. "dsl and docsis link layer compensation support"? Not sure someone who hasn't drunk the koolaid understands how a shaper can have "dsl and docsis support" >> * 8 way set associative queuing to reduce flow collisions to a >>minimum. 8-way set-associative hashing >> * A reasonable interpretation of various diffserv latency/loss >>tradeoffs. Heh. Not sure the word 'reasonable' can reasonably be applied to diffserv ;) >> * Support for washing diffserv for entering and exiting traffic. The term 'washing' is also internal; explain it? ("washing (zeroing) diffserv markings") >> * Perfect support for interacting with Docsis 3.0 shapers. What does that mean? >> * Extensive support for DSL framing types. Aren't you just repeating yourself from above now? >> * (New) Support for ack filtering. >> - 20 % better throughput at a 16x1 down/up ratio on the rrul test. >From the PoV of an upstream submission it's all new, isn't it? Also, this is the only place where you cite benchmark results. >> * Extensive statistics for measuring, loss, ecn markings, latency variat= ion. >> >> There are some features still considered experimental, notably the >> ingress_autorate bandwidth estimator and cobalt itself. >> >> Various versions shipping have been available as an out of tree build for >> kernel versions going back to 3.10, as the embedded router world has been >> running a few years behind mainline Linux. A stable version has been >> generally available on lede-17.01 and later. >> >> sch_cake replaces a combination of iptables, tc filter, htb and fq_codel= in >> the sqm-scripts, with sane defaults and vastly easier configuration. s/easier/simpler/ >> Cake's principal author is Jonathan Morton, with contributions from >> Kevin Darbyshire-Bryant, Toke H=C3=B8iland-J=C3=B8rgensen, Sebastian Moe= ller, >> Ryan Mounce, Dean Scarff, Guido Sarducci, Nils Andreas Svee, Dave T=C3= =A4ht, and >> Loganaden Velvindron. But no Signed-off-by? :) -Toke