Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Victor Nogueira <victor@mojatatu.com>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Jiri Pirko <jiri@resnulli.us>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>
Cc: "Jonas Köppeler" <j.koeppeler@tu-berlin.de>,
	cake@lists.bufferbloat.net, netdev@vger.kernel.org
Subject: [Cake] Re: [PATCH net-next v5 6/6] selftests/tc-testing: add selftests for cake_mq qdisc
Date: Tue, 06 Jan 2026 11:30:23 +0100	[thread overview]
Message-ID: <875x9f58zk.fsf@toke.dk> (raw)
In-Reply-To: <04a4cfc3-ca15-49cf-89c1-17a4bc374caa@mojatatu.com>

Victor Nogueira <victor@mojatatu.com> writes:

> On 05/01/2026 09:50, Toke Høiland-Jørgensen wrote:
>> From: Jonas Köppeler <j.koeppeler@tu-berlin.de>
>> [...]
>> Test 18e0: Fail to install CAKE_MQ on single queue device
>>  [...]
>> +    {
>> +        "id": "18e0",
>> +        "name": "Fail to install CAKE_MQ on single queue device",
>> +        "category": [
>> +            "qdisc",
>> +            "cake_mq"
>> +        ],
>> +        "plugins": {
>> +            "requires": "nsPlugin"
>> +        },
>> +        "setup": [
>> +            "echo \"1 1 1\" > /sys/bus/netdevsim/new_device"
>> +        ],
>> +        "cmdUnderTest": "$TC qdisc add dev $ETH handle 1: root cake_mq",
>> +        "expExitCode": "2",
>> +        "verifyCmd": "$TC qdisc show dev $ETH",
>> +        "matchPattern": "qdisc (cake_mq 1: root|cake 0: parent 1:[1-4]) bandwidth unlimited diffserv3 triple-isolate nonat nowash no-ack-filter split-gso rtt 100ms raw overhead 0 ",
>> +        "matchCount": "0",
>> +        "teardown": []
>
> Hi!
>
> This test is missing the device deletion on the teardown stage.

Ah, oops; will fix and respin, thanks for catching this!

-Toke

  reply	other threads:[~2026-01-06 10:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-05 12:50 [Cake] [PATCH net-next v5 0/6] Multi-queue aware sch_cake Toke Høiland-Jørgensen
2026-01-05 12:50 ` [Cake] [PATCH net-next v5 1/6] net/sched: Export mq functions for reuse Toke Høiland-Jørgensen
2026-01-05 12:50 ` [Cake] [PATCH net-next v5 2/6] net/sched: sch_cake: Factor out config variables into separate struct Toke Høiland-Jørgensen
2026-01-05 12:50 ` [Cake] [PATCH net-next v5 3/6] net/sched: sch_cake: Add cake_mq qdisc for using cake on mq devices Toke Høiland-Jørgensen
2026-01-05 12:50 ` [Cake] [PATCH net-next v5 4/6] net/sched: sch_cake: Share config across cake_mq sub-qdiscs Toke Høiland-Jørgensen
2026-01-05 12:50 ` [Cake] [PATCH net-next v5 5/6] net/sched: sch_cake: share shaper state across sub-instances of cake_mq Toke Høiland-Jørgensen
2026-01-05 12:50 ` [Cake] [PATCH net-next v5 6/6] selftests/tc-testing: add selftests for cake_mq qdisc Toke Høiland-Jørgensen
2026-01-05 20:52   ` [Cake] " Victor Nogueira
2026-01-06 10:30     ` Toke Høiland-Jørgensen [this message]
2026-01-05 15:24 ` [Cake] Re: [PATCH net-next v5 0/6] Multi-queue aware sch_cake Jakub Kicinski
2026-01-05 16:13   ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875x9f58zk.fsf@toke.dk \
    --to=toke@toke.dk \
    --cc=cake@lists.bufferbloat.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=j.koeppeler@tu-berlin.de \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=victor@mojatatu.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox