From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mail.toke.dk; dkim=pass header.d=toke.dk; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=toke.dk policy.dmarc=reject
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023;
	t=1767695424; bh=uqx4UNio5IZHh0domM8JuvlnEo/PhdnFDKl+/fCu09A=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
	b=smQWWFRkFDf0Yzu3ZSqtvimCM8d5274H0RdCyWUTgtRYG3s7HC60EziqBPvGRILfo
	 tmSP3ZqsPqrNeBQj9jRLdparj6mUkD66dmNE0CsRM8ylbOYWtxhLT+n7f/eTMoHJgT
	 DduSqs4LG02I8/ZV+ctmKj8vJZ4hG/AE551e44VyHaK/A4nudxX/ikjQMxNOrzuFMX
	 J385VqHdTUFoL6Cz9EjbQKcsZlbMwXp4la/2ESaljJ1SPYN/K1KW2omV4gPDo82GWC
	 u7oMVzCC/M42w1BGzG0Ri1yDqOEAftkGmxquO+bnvsb3KupWXUvrH2qJ+aQUdaMAZr
	 qpGbi7+lSxLuQ==
To: Victor Nogueira <victor@mojatatu.com>, Jamal Hadi Salim
 <jhs@mojatatu.com>, Cong Wang <xiyou.wangcong@gmail.com>, Jiri Pirko
 <jiri@resnulli.us>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet
 <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
 <pabeni@redhat.com>, Simon Horman <horms@kernel.org>
Cc: Jonas =?utf-8?Q?K=C3=B6ppeler?= <j.koeppeler@tu-berlin.de>,
 cake@lists.bufferbloat.net,
 netdev@vger.kernel.org
In-Reply-To: <04a4cfc3-ca15-49cf-89c1-17a4bc374caa@mojatatu.com>
References: <20260105-mq-cake-sub-qdisc-v5-0-8a99b9db05e6@redhat.com>
 <20260105-mq-cake-sub-qdisc-v5-6-8a99b9db05e6@redhat.com>
 <04a4cfc3-ca15-49cf-89c1-17a4bc374caa@mojatatu.com>
Date: Tue, 06 Jan 2026 11:30:23 +0100
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <875x9f58zk.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Message-ID-Hash: 5LLJSAP4RZDAR3NMUQXJUHQOSNFFQKTM
X-Message-ID-Hash: 5LLJSAP4RZDAR3NMUQXJUHQOSNFFQKTM
X-MailFrom: toke@toke.dk
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
Subject: [Cake] Re: [PATCH net-next v5 6/6] selftests/tc-testing: add selftests for cake_mq qdisc
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
Archived-At: <https://lists.bufferbloat.net/cake/875x9f58zk.fsf@toke.dk/>
List-Archive: <https://lists.bufferbloat.net/cake/>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Owner: <mailto:cake-owner@lists.bufferbloat.net>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Subscribe: <mailto:cake-join@lists.bufferbloat.net>
List-Unsubscribe: <mailto:cake-leave@lists.bufferbloat.net>

Victor Nogueira <victor@mojatatu.com> writes:

> On 05/01/2026 09:50, Toke H=C3=83=C2=B8iland-J=C3=83=C2=B8rgensen wrote:
>> From: Jonas K=C3=B6ppeler <j.koeppeler@tu-berlin.de>
>> [...]
>> Test 18e0: Fail to install CAKE_MQ on single queue device
>>  [...]
>> +    {
>> +        "id": "18e0",
>> +        "name": "Fail to install CAKE_MQ on single queue device",
>> +        "category": [
>> +            "qdisc",
>> +            "cake_mq"
>> +        ],
>> +        "plugins": {
>> +            "requires": "nsPlugin"
>> +        },
>> +        "setup": [
>> +            "echo \"1 1 1\" > /sys/bus/netdevsim/new_device"
>> +        ],
>> +        "cmdUnderTest": "$TC qdisc add dev $ETH handle 1: root cake_mq",
>> +        "expExitCode": "2",
>> +        "verifyCmd": "$TC qdisc show dev $ETH",
>> +        "matchPattern": "qdisc (cake_mq 1: root|cake 0: parent 1:[1-4])=
 bandwidth unlimited diffserv3 triple-isolate nonat nowash no-ack-filter sp=
lit-gso rtt 100ms raw overhead 0 ",
>> +        "matchCount": "0",
>> +        "teardown": []
>
> Hi!
>
> This test is missing the device deletion on the teardown stage.

Ah, oops; will fix and respin, thanks for catching this!

-Toke