From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 40B363B2A4 for ; Mon, 28 Mar 2022 12:42:56 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648485775; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fmjqOD3BHl74OkWJZQBaV4zUSFxZmdbs1YlkDjt8Mso=; b=HibXWvBE2ZcIjpcxcO4eI0OtJtpUwisdhI+w4ZO/EgW8A34sofxaa/CY+YD0loj3DUuQim EYpcFPvdA0tcYR+RicX1lOir2iocjQkQ59J4EVkTSM1Z32QNsrkbx5Jg4oljJWGrl1yAVZ gSCwMW14sG3iVqwcZQah4fodPckL7m0= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-339-50vytxaRNLKk2eqfZiHd3g-1; Mon, 28 Mar 2022 12:42:54 -0400 X-MC-Unique: 50vytxaRNLKk2eqfZiHd3g-1 Received: by mail-ed1-f70.google.com with SMTP id c22-20020a50f616000000b004196649d144so9261241edn.10 for ; Mon, 28 Mar 2022 09:42:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=fmjqOD3BHl74OkWJZQBaV4zUSFxZmdbs1YlkDjt8Mso=; b=3dGbgBcJmXPIuCuhRNXdx3cT1xGZxYcfSob1z6mijuppFUBCZj35mvIbX/+znSN6nV TWD/2cRHAR9AS5dgoWA/O2rD0RIrWu4EksbJDyknp4B//NHa3VdLBnWXzRwI0Z8aX65t Ky8QxOzmxE4yc9n/PSbnKT1CXqCrwQzk7IAP16e9ydC2AeyJl/kvYelltolTFa7ywFKG tRHPN6pHzydX/AAAxHmlmr8vq2bjO1G+vIZXef2AEbvsuie0/Xz/Flw/Lz73z/O4JyOm TW1fBRlRCSVTZy+z7hc8qlTkQEeRwqpr9CBltxUKE2J2lUwy8BO2crzBGKoJW0FIcw26 pInw== X-Gm-Message-State: AOAM531qUw6BwynLjugxmoo/sZna/0u4g7lZFjcGmNij8s92bTH38LOv YS2bsELOJ407ODWtiQFBI7rCi3iUFNcYmEjjo4nphMBZDI6p6TzhzPgGUILSiGBuxKB0dgpru4W 1RMykQYNodBsunaSLYHGiBw== X-Received: by 2002:a17:906:69d1:b0:6ce:7201:ec26 with SMTP id g17-20020a17090669d100b006ce7201ec26mr29008769ejs.105.1648485767576; Mon, 28 Mar 2022 09:42:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzKl2T4YNWrX/G/bLyX2wwQvRxTA6uAkjsCaHLi/EPyI7kjYU0rENziBQoKf+YQfsM/0GREpQ== X-Received: by 2002:a17:906:69d1:b0:6ce:7201:ec26 with SMTP id g17-20020a17090669d100b006ce7201ec26mr29007877ejs.105.1648485757354; Mon, 28 Mar 2022 09:42:37 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id z5-20020a1709063a0500b006da8fa9526esm6164674eje.178.2022.03.28.09.42.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Mar 2022 09:42:36 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 224592279E0; Mon, 28 Mar 2022 18:42:36 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Christophe Leroy , "David S. Miller" , Jakub Kicinski , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Paolo Abeni Cc: "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "cake@lists.bufferbloat.net" In-Reply-To: <079a3b29-fec7-97c9-19d9-0bd9a17e63f1@csgroup.eu> References: <356a242a964fabbdf876a18c7640eb6ead6d0e6b.1648468695.git.christophe.leroy@csgroup.eu> <87bkxq5bgt.fsf@toke.dk> <079a3b29-fec7-97c9-19d9-0bd9a17e63f1@csgroup.eu> X-Clacks-Overhead: GNU Terry Pratchett Date: Mon, 28 Mar 2022 18:42:36 +0200 Message-ID: <875yny58qr.fsf@toke.dk> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=toke@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH net-next] sch_cake: Take into account guideline DEF/DGSIC/36 from French Administration X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Mar 2022 16:42:56 -0000 Christophe Leroy writes: > Le 28/03/2022 =C3=A0 17:43, Toke H=C3=B8iland-J=C3=B8rgensen a =C3=A9crit= =C2=A0: >> Christophe Leroy writes: >>=20 >>> French Administration has written a guideline that defines additional >>> DSCP values for use in its networks. >>=20 >> Huh, that's interesting! >>=20 >>> Add new CAKE diffserv tables to take those new values into account >>> and add CONFIG_NET_SCH_CAKE_DGSIC to select those tables instead of >>> the default ones. >>=20 >> ...however I don't think we should be including something this >> special-purpose into the qdisc kernel code, and certainly we shouldn't >> have a config option that changes the meaning of the existing diffserv >> keywords! > > By the way it doesn't really change meaning. Just enhances it indeed.=20 > Because they are not changing the meaning of existing DSCP codes, just=20 > adding new ones. Ah, OK, but then it's even easier, you can just add rules for the new values using the userspace options and let cake select the rest using the existing code. >> Rather, this is something that is best specified from userspace; and in >> fact Cake already has no less than two different ways to do this: the >> 'fwmark' option, and setting the skb->priority field. Have you tried >> using those? > > No I have not. In fact I'm just discovering the subject after some=20 > people told me "we are contractually required to apply this guideline,=20 > please make sure Linux kernel supports it". > > I'll give 'fwmark' and/or skb->priority a try. Is there any=20 > Documentation on that somewhere ? Both are documented in the tc-cake man page. -Toke