From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Dave Taht <dave.taht@gmail.com>, Avakash bhat <avakash261@gmail.com>
Cc: Vybhav Pai <vybhavpai1999.vp@gmail.com>,
Shrinidhi Varna <shrinidhivarna.171co145@nitk.edu.in>,
Cake List <cake@lists.bufferbloat.net>,
"Mohit P. Tahiliani" <tahiliani@nitk.edu.in>,
Deepak K <deepakkavoor99@gmail.com>
Subject: Re: [Cake] Query on ACK
Date: Fri, 08 May 2020 17:08:21 +0200 [thread overview]
Message-ID: <875zd6h3bu.fsf@toke.dk> (raw)
In-Reply-To: <CAA93jw6xZRcUerJ8JuxjtjW2_C+wyAUKRtqDojPj6hLdg1w0Dg@mail.gmail.com>
Dave Taht <dave.taht@gmail.com> writes:
> On Thu, May 7, 2020 at 11:36 PM Avakash bhat <avakash261@gmail.com> wrote:
>>
>> Ok thanks so much for the clarifications.
>> That cleared it up quite a bit.
>
> I note that there was something really subtle that could have been
> done to improve cake's ack handling, and for all I know
> it actually happened in the final codebase.
>
> so, please, go forth and duplicate the existing implementation, and
> ignore me, cause looking at this hairy code gives me a
> headache.
>
> anyway, to try and describe what I thought I saw an interaction with
> the scheduler back in the day.
>
> The ack-filter runs, deleting all but one packet from the ack queue,
> and delivers that.
> the scheduler runs, serves a bunch of other flows, then returns to the
> ack queue, which has accumulated a couple more packets,
> the ack-filter runs, deleting all but one packet from the ack queue,
> and delivers that, but doesn't exhaust its qauntum
The ACK filter runs on enqueue, so if a queue has only ACKs in it, it
will never accumulate anything in the first place...
-Toke
next prev parent reply other threads:[~2020-05-08 15:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 18:43 Avakash bhat
2020-05-06 19:01 ` Jonathan Morton
2020-05-06 19:13 ` Toke Høiland-Jørgensen
2020-05-07 6:44 ` Avakash bhat
2020-05-07 6:59 ` Jonathan Morton
2020-05-07 7:07 ` Sebastian Moeller
2020-05-08 6:36 ` Avakash bhat
2020-05-08 6:50 ` Dave Taht
2020-05-08 7:41 ` Sebastian Moeller
2020-05-08 15:08 ` Toke Høiland-Jørgensen [this message]
2020-05-08 15:11 ` Dave Taht
2020-05-08 15:20 ` Jonathan Morton
2020-05-08 15:40 ` Dave Taht
2020-05-25 5:17 ` Avakash bhat
2020-05-25 9:42 ` Jonathan Morton
2020-05-25 11:58 ` Toke Høiland-Jørgensen
2020-06-14 12:43 ` Avakash bhat
2020-06-14 14:43 ` Jonathan Morton
2020-06-16 5:22 ` Avakash bhat
2020-06-16 5:31 ` Dave Taht
2020-06-16 5:32 ` Dave Taht
2020-05-08 17:43 ` [Cake] Curious regarding Cake sensitivity to hardware queue depth David P. Reed
2020-05-08 8:23 ` [Cake] Query on ACK Sebastian Moeller
2020-05-06 19:08 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zd6h3bu.fsf@toke.dk \
--to=toke@redhat.com \
--cc=avakash261@gmail.com \
--cc=cake@lists.bufferbloat.net \
--cc=dave.taht@gmail.com \
--cc=deepakkavoor99@gmail.com \
--cc=shrinidhivarna.171co145@nitk.edu.in \
--cc=tahiliani@nitk.edu.in \
--cc=vybhavpai1999.vp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox