Re: [Cake] Bug or not Cake + hfsc or Cake + Drr

["Toke Høiland-Jørgensen" <toke@redhat.com>]

Martin Zaharinov <micron10@gmail.com> writes:

> Hi Pete
> yes i find this patch and add to cake source
> and in my test with hfsc and cake
> i use
>
> tc qdisc add dev eth1 root handle 1: hfsc default 1
> tc class add dev eth1 parent 1: classid 1:1 hfsc ls rate 7mbit ul rate 7mbit
> tc qdisc add dev eth1 parent 1:1 cake besteffort bandwidth 5mbit datacentre
> nat memlimit 32m
>
> user speed is 5mbit and on hfsc i add extra 2 mbit to give free limit for
> cake.
> and work fine but in dmesg get :
>
> [44835.530255] qdisc_peek_len: cake qdisc 8017: is non-work-conserving?
> [44840.689403] HFSC: cake qdisc 8012: is non-work-conserving?

Yes. As I said, you *cannot use the cake shaper* when running in under
HFSC.

> user receive 5mbit for upload and download and fine work.
> mai be need to add no-split-gso to config
>
> but after add have same error on dmesg :
>
> [44955.641391] HFSC: cake qdisc 8021: is non-work-conserving?
> [44955.958904] HFSC: cake qdisc 801C: is non-work-conserving?
>
> but work fine and will remove warrning from kernel source to not list in
> dmesg :)

I very much doubt that things will just continue to "work fine" if you
just remove the warning...

-Toke