From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 172953B29E for ; Thu, 7 Mar 2019 13:28:31 -0500 (EST) Received: by mail-ed1-f65.google.com with SMTP id g19so14338738edp.2 for ; Thu, 07 Mar 2019 10:28:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=nVI6YMxlYJJBmIYB5LSJbjgy+o8pq6v6M51JjxuRYlI=; b=iLBUWCl32fAy08BLW5+3t6RVDECYB99UqRGeXk6YbQcC4bZb9Ar6kxn0TueA+ztE/+ opJ0OA3P61Zw6QtEkSqoZgEsdj3T6iehY7bW1xQ0YgzPOKunhc4sPodXfPx6zwGCOTsH 9ZDE6ZENB6rFF14onISCu1lt3VyFnAtk/Io+eN8X5E1HSqp5061lnLFDOdNQdpw7JEzA fxEnRbrscFPWmSGp0X4RBmME6xww+UPmNC+yJyumx9C7/RhEt+3SNzRl0G4oVdCs0DVm dvivFBKqBSDiu76loJr+zZVY4H/2yvuFGicRRuqlk3UHprTZNmdYG4RpDxhd3aZ41nSo YwDA== X-Gm-Message-State: APjAAAXUzExyqCe9Mb02sz0w96Q+k/w6r3aTELDDGypfrAyFJsq9zOIV My2tZuXrMkVwtuAzkABwIynXdDoBj0E= X-Google-Smtp-Source: APXvYqyqBYzGXdioW0zdkRD0gOU9TNk2VeiFBp6F7T3sszppOrBjtEWtKTFJKmQs8H8IoBUdgCUTgw== X-Received: by 2002:a17:906:7b03:: with SMTP id e3mr8901798ejo.21.1551983310156; Thu, 07 Mar 2019 10:28:30 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([2a00:7660:6da:10::2]) by smtp.gmail.com with ESMTPSA id g25sm1020440ejc.55.2019.03.07.10.28.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Mar 2019 10:28:29 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 03A41182F5B; Thu, 7 Mar 2019 19:28:23 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Martin Zaharinov , Pete Heist Cc: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= via Cake In-Reply-To: References: <8736nz11mt.fsf@toke.dk> <87o96nyo1n.fsf@toke.dk> <87lg1r0xp0.fsf@toke.dk> <87h8cf0wt7.fsf@toke.dk> <87ef7j0vui.fsf@toke.dk> X-Clacks-Overhead: GNU Terry Pratchett Date: Thu, 07 Mar 2019 19:28:23 +0100 Message-ID: <875zsu1quw.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Cake] Bug or not Cake + hfsc or Cake + Drr X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Mar 2019 18:28:31 -0000 Martin Zaharinov writes: > Hi Pete > yes i find this patch and add to cake source > and in my test with hfsc and cake > i use > > tc qdisc add dev eth1 root handle 1: hfsc default 1 > tc class add dev eth1 parent 1: classid 1:1 hfsc ls rate 7mbit ul rate 7mbit > tc qdisc add dev eth1 parent 1:1 cake besteffort bandwidth 5mbit datacentre > nat memlimit 32m > > user speed is 5mbit and on hfsc i add extra 2 mbit to give free limit for > cake. > and work fine but in dmesg get : > > [44835.530255] qdisc_peek_len: cake qdisc 8017: is non-work-conserving? > [44840.689403] HFSC: cake qdisc 8012: is non-work-conserving? Yes. As I said, you *cannot use the cake shaper* when running in under HFSC. > user receive 5mbit for upload and download and fine work. > mai be need to add no-split-gso to config > > but after add have same error on dmesg : > > [44955.641391] HFSC: cake qdisc 8021: is non-work-conserving? > [44955.958904] HFSC: cake qdisc 801C: is non-work-conserving? > > but work fine and will remove warrning from kernel source to not list in > dmesg :) I very much doubt that things will just continue to "work fine" if you just remove the warning... -Toke