From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [IPv6:2001:470:dc45:1000::1]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 36F793CB3C for ; Tue, 6 Mar 2018 16:06:03 -0500 (EST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1520370361; bh=N7toKxjqcgCnN9H7jkF2Wkf4J88tPNCelmoNnoKWd7Q=; h=From:To:Subject:In-Reply-To:References:Date:From; b=QHWbaZxEd0Hck/P4shmkZ4J1lUzqRcRf+kBGRUUKpW9MTPYf+T3dgVjg2AG1AdYye 5AKe3NPt4pMvyZ1E5yhnAGtM/6nX6qhCpBbFg7TJFErsDR83Dg7M7ZGxM8kpdAbJ+t vTdDKBdIPxcGwAUz/7wP7XpXV315/Dl40AG/Zg6hLAwyh9EKf/4R7CJWTZBecz8Wm4 l6ycxbofU0ILlkGpQb3j5c2ULMHcH/EOSkOwJbx2eLlhTJdOflWHXHL36oqlYKo8E7 pUGiEI+g50+JQjCsQEIqUimbhIdhTDs8vh9fuV9LPfdnh2LXFRXD/cwDFPRHyknOM9 BtGMu/npmYfKA== To: cake@lists.bufferbloat.net In-Reply-To: <87ina9m4up.fsf@toke.dk> References: <20180127130542.25817-1-toke@toke.dk> <20180211172618.13297-1-toke@toke.dk> <20180211172618.13297-2-toke@toke.dk> <20180306075616.380a533c@xeon-e3> <87ina9m4up.fsf@toke.dk> Date: Tue, 06 Mar 2018 22:06:01 +0100 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <876068nccm.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Mar 2018 21:06:03 -0000 Toke H=C3=B8iland-J=C3=B8rgensen writes: > Stephen Hemminger writes: > >> On Sun, 11 Feb 2018 18:26:18 +0100 >> Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> >>> This updates tc to understand the updated cake xstats structure (which >>> splits out the tin stats in a separate structure the length of which is >>> included in the containing struct). >>>=20 >>> Old versions of the cake stats will no longer be understood by the >>> resulting version of tc. >>>=20 >>> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen >> >> Please consider using new json printing routines in latest iproute2. > > Yeah, was going to look into that... Right, so I merged the upstream iproute2-next repository into the master branch and added JSON support to the Cake qdisc code. I also removed a bunch of old compatibility code along the way, as well as the fq_pie code and any changes to the repo that were not in upstream and were not cake-related. So the delta between the tc-adv repo and upstream is now only cake. This was quite a bit of rearranging, so please do check if I broke something along the way. Other than that, though, this means that on the iproute2 side the only thing missing before we can attempt an upstream submission is an update of the man page, as far as I can tell. Any volunteers to do that? :) -Toke