Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Pete Heist <pete@heistp.net>
Cc: Jonathan Morton <chromatix99@gmail.com>,
	Cake List <cake@lists.bufferbloat.net>
Subject: Re: [Cake] cake at 60gbit
Date: Fri, 06 Jul 2018 14:04:56 +0200	[thread overview]
Message-ID: <877em8bmdz.fsf@toke.dk> (raw)
In-Reply-To: <8184CEEA-64C0-4CCD-A831-D90CFDC56F22@heistp.net>

Pete Heist <pete@heistp.net> writes:

>> On Jul 6, 2018, at 1:33 PM, Toke Høiland-Jørgensen <toke@toke.dk> wrote:
>> 
>> AHA! Found the culprit!
>> 
>> The bulk dequeue mechanism in sch_generic.c will dequeue a bunch of
>> packets at once, then check if they belong on the same hardware txq. If
>> they don't, they will be put back on a separate queue in the qdisc
>> structure (sch->skb_bad_txq), and the qlen will be increased, without
>> telling the qdisc about it.
>
> Solid, nice work!

Thanks :)

>> This obviously only happens on hardware with multiple TXQs, which is why
>> the bug doesn't happen on veth.
>
>
> It would be nice if veth were mq capable.
>
> For whatever reason, I didn’t see this on my i210at’s (1gbit ethernet
> with 4 transmit and 4 receive queues).

Well, you have to hit the exact conditions; i.e., a bulk dequeue that
happens to get a bunch of packets that hit different TX queues. So that
depends on both the TXQ hashing, and the queue state, number of flows
etc. I only get a handful of "lockups" (debug lines) on a 10-sec netperf
test with 6 flows.

> I’m now playing with netem, cake and veth for the first time (two
> namespaces with netem as the parent qdisc to cake for each namespace).
> I’ve gotten the setup not to lock up in an infinite loop but to
> occasionally stop passing traffic sometimes after a netperf test. This
> could easily be a problem specific to netns though, so I’ll be playing
> with it some more and will post if I can narrow it down to something
> specific.

Yay, more fun! :P

Please do see if you can narrow this down; it would be good to fix this
as well before we submit another version upstream...

-Toke

  reply	other threads:[~2018-07-06 12:05 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.381.1530347349.3512.cake@lists.bufferbloat.net>
2018-06-30 16:37 ` [Cake] Cake on openwrt - falling behind Georgios Amanakis
2018-06-30 17:26   ` Pete Heist
2018-06-30 18:09     ` Georgios Amanakis
2018-06-30 18:55       ` Kevin Darbyshire-Bryant
2018-06-30 19:57         ` Pete Heist
2018-06-30 20:58           ` Georgios Amanakis
2018-06-30 21:37             ` Pete Heist
2018-06-30 22:43               ` Pete Heist
2018-06-30 23:20                 ` Pete Heist
     [not found]                   ` <CACvFP_gkdAPKSEO7j9+cMPqTa-fJYd8XFEEBD6ZzLuVvaNwsvg@mail.gmail.com>
2018-07-01  2:37                     ` [Cake] Fwd: " Georgios Amanakis
2018-07-01  7:18                       ` [Cake] " Pete Heist
2018-07-01 13:48                         ` Pete Heist
2018-07-01 14:02                           ` Dave Taht
2018-07-01 15:30                             ` Pete Heist
2018-07-01 14:38                           ` Kevin Darbyshire-Bryant
2018-07-01 16:54                             ` Pete Heist
2018-07-01 19:41                               ` Kevin Darbyshire-Bryant
2018-07-02 10:19                                 ` Pete Heist
2018-07-02 11:38                                   ` Pete Heist
2018-07-02 11:59                                     ` Kevin Darbyshire-Bryant
2018-07-02 14:01                                       ` Pete Heist
2018-07-02 12:03                                     ` Toke Høiland-Jørgensen
2018-07-02 14:51                                       ` Pete Heist
2018-07-02 16:14                                         ` Toke Høiland-Jørgensen
2018-07-02 16:59                                           ` Kevin Darbyshire-Bryant
2018-07-02 17:04                                           ` Pete Heist
2018-07-02 17:12                                             ` Kevin Darbyshire-Bryant
2018-07-02 18:24                                             ` Pete Heist
2018-07-02 19:31                                               ` Toke Høiland-Jørgensen
2018-07-02 20:09                                                 ` Pete Heist
2018-07-02 20:11                                                   ` Toke Høiland-Jørgensen
2018-07-02 20:46                                                     ` Pete Heist
     [not found]                                           ` <mailman.407.1530550780.3512.cake@lists.bufferbloat.net>
2018-07-02 17:50                                             ` Kevin Darbyshire-Bryant
2018-07-02 19:33                                               ` Toke Høiland-Jørgensen
2018-07-02 19:36                                                 ` Kevin Darbyshire-Bryant
2018-07-02 19:39                                                   ` Toke Høiland-Jørgensen
2018-07-02 20:03                                                     ` [Cake] cake at 60gbit Dave Taht
2018-07-02 20:09                                                       ` Toke Høiland-Jørgensen
2018-07-02 21:16                                                         ` Pete Heist
2018-07-02 21:35                                                           ` Toke Høiland-Jørgensen
2018-07-02 22:07                                                             ` Georgios Amanakis
2018-07-02 22:12                                                               ` Dave Taht
2018-07-02 23:48                                                                 ` Georgios Amanakis
2018-07-02 22:23                                                               ` Toke Høiland-Jørgensen
2018-07-03  7:35                                                                 ` Pete Heist
2018-07-03  9:18                                                                 ` Jonathan Morton
2018-07-03  9:57                                                                   ` Pete Heist
2018-07-03 10:27                                                                   ` Toke Høiland-Jørgensen
2018-07-03 10:41                                                                     ` Pete Heist
2018-07-05 22:31                                                                     ` Toke Høiland-Jørgensen
2018-07-05 23:48                                                                       ` Georgios Amanakis
2018-07-06  1:21                                                                         ` Dave Taht
2018-07-06  2:55                                                                           ` George Amanakis
2018-07-06  3:06                                                                             ` George Amanakis
2018-07-06  9:22                                                                               ` Toke Høiland-Jørgensen
2018-07-06  9:21                                                                           ` Toke Høiland-Jørgensen
2018-07-06  8:55                                                                       ` Pete Heist
2018-07-06  9:29                                                                         ` Toke Høiland-Jørgensen
2018-07-06 10:00                                                                           ` Pete Heist
2018-07-06 10:46                                                                             ` Toke Høiland-Jørgensen
2018-07-06 11:33                                                                               ` Toke Høiland-Jørgensen
2018-07-06 11:43                                                                                 ` Jonathan Morton
2018-07-06 11:48                                                                                   ` Toke Høiland-Jørgensen
2018-07-06 11:58                                                                                 ` Pete Heist
2018-07-06 12:04                                                                                   ` Toke Høiland-Jørgensen [this message]
2018-07-02 18:39                                           ` [Cake] Cake on openwrt - falling behind Dave Taht
2018-07-02 19:11                                             ` Kevin Darbyshire-Bryant
2018-07-02 19:23                                               ` Toke Høiland-Jørgensen
2018-07-02 19:27                                                 ` Dave Taht
2018-07-02 19:38                                                   ` Toke Høiland-Jørgensen
2018-07-02 20:05                                                     ` Toke Høiland-Jørgensen
2018-07-02 19:31                                             ` Pete Heist
     [not found]                               ` <mailman.397.1530474091.3512.cake@lists.bufferbloat.net>
2018-07-01 23:55                                 ` Dave Taht
2018-07-02  0:05                                   ` Dave Taht
     [not found]                           ` <mailman.392.1530455913.3512.cake@lists.bufferbloat.net>
2018-07-01 15:17                             ` Jonathan Morton
     [not found]       ` <mailman.384.1530384918.3512.cake@lists.bufferbloat.net>
2018-07-01  9:46         ` Magnus Olsson
2018-07-01 12:34           ` Kevin Darbyshire-Bryant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877em8bmdz.fsf@toke.dk \
    --to=toke@toke.dk \
    --cc=cake@lists.bufferbloat.net \
    --cc=chromatix99@gmail.com \
    --cc=pete@heistp.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox