From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Jonathan Morton <chromatix99@gmail.com>
Cc: Pete Heist <pete@heistp.net>, Cake List <cake@lists.bufferbloat.net>
Subject: Re: [Cake] the Cake stalemate
Date: Tue, 19 Jun 2018 13:54:44 +0200 [thread overview]
Message-ID: <877emvt2ij.fsf@toke.dk> (raw)
In-Reply-To: <0FF888EC-4FF0-4AAE-B2B8-79A10B0B5A9E@gmail.com>
Jonathan Morton <chromatix99@gmail.com> writes:
>> On 19 Jun, 2018, at 12:55 pm, Toke Høiland-Jørgensen <toke@toke.dk> wrote:
>>
>> Not sure there is a stalemate, actually. I just ran out of time to do
>> further revisions; planning to take that up again. Don't see any reason
>> why we shouldn't be able to succeed in getting Cake upstream in its
>> current form(ish) in just a few more revisions (or, who knows, maybe a
>> dozen more; better not jinx it ;)).
>
> My impression was that we were practically there - but we ran up
> against a hang bug which *may* have had a root cause elsewhere than
> Cake itself. I strongly suspect we're tickling a HW driver bug, but
> we need someone with a different flavour of 100Gbps NIC to try (and
> hopefully fail) to reproduce it.
Yeah, that and getting the ACK filter approved by the TCP devs are the
major outstanding issues. I'm planning to go poke at the hanging issue
once I have some time, then hopefully fix whatever is causing it, and
resubmit :)
We also saw a bug on 32-bit MIPS where some combinations of 64-bit
netlink attributes would cause stats display in tc to fail. However, I
believe this is more a case of Cake exposing a latent bug somewhere in
the tc or kernel netlink code (alignment issues, perhaps?), and so I'm
not sure it is necessarily a blocker for merging Cake. However, if
someone could take a look that would be very helpful. I forget if the
current head of the cobalt branch exposes the bug, but I think it does.
It's quite obvious when it happens: no stats output whatsoever...
-Toke
next prev parent reply other threads:[~2018-06-19 11:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 9:31 Pete Heist
2018-06-19 9:55 ` Toke Høiland-Jørgensen
2018-06-19 10:04 ` Pete Heist
2018-06-19 11:32 ` Jonathan Morton
2018-06-19 11:54 ` Toke Høiland-Jørgensen [this message]
2018-06-19 12:26 ` Pete Heist
2018-06-19 13:41 ` Kevin Darbyshire-Bryant
2018-06-19 14:48 ` Pete Heist
2018-06-19 16:24 ` Dave Taht
2018-06-19 20:14 ` Pete Heist
2018-06-19 20:35 ` Jonathan Morton
2018-06-19 21:48 ` Dave Taht
2018-06-19 23:41 ` Sebastian Moeller
2018-06-19 22:34 ` Pete Heist
2018-06-19 23:38 ` Sebastian Moeller
2018-06-20 3:36 ` Jonathan Morton
2018-06-20 4:34 ` Sebastian Moeller
2018-06-19 12:08 ` Pete Heist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877emvt2ij.fsf@toke.dk \
--to=toke@toke.dk \
--cc=cake@lists.bufferbloat.net \
--cc=chromatix99@gmail.com \
--cc=pete@heistp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox