From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <toke@toke.dk>
Received: from mail.toke.dk (mail.toke.dk [IPv6:2001:470:dc45:1000::1])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id 0CA3B3B29E
 for <cake@lists.bufferbloat.net>; Tue, 24 Apr 2018 11:38:25 -0400 (EDT)
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023;
 t=1524584304; bh=165vs1oiZmiyGCDMweYgc1tASihFmwU0dhpHj4FFzV0=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=bLC7/GRD/WVa2rYlRoap+hKvoz2BbrQLrg4dGyZJSzkN4j34+1lG/7Xbop+4Shrjq
 O1Q5r2vLmUH+C6R5nmrjBAMZ2bwVn8VRkRSP9hdj1Oo/qvcGQAwpKqK3GyRp5n1KG9
 Lh/Thxtl9crPvij7QoaBcJfL8Ih/IAXqMM1YQq9tOVNGxmNN7y1DZS26x1ieKhoVK+
 llkrxI9/jDHNx0HOZcAPflLzhF4BqlnsG4IUwdkIGBC+q4WkplSpAB//tjv6ZFOKT8
 ECtBiWyPkNw5U0JhhwyDoCrQeaBAApXkNGdVjgfNhgwU3ESROW4psQ8Xv2S0Uc3XtH
 SVr4wSqtorVxA==
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net
In-Reply-To: <20180424081008.2ad7eaa7@xeon-e3>
References: <20180424114407.5939-2-toke@toke.dk>
 <20180424123046.21247-1-toke@toke.dk> <20180424074552.397564a5@xeon-e3>
 <87efj47j1y.fsf@toke.dk> <20180424081008.2ad7eaa7@xeon-e3>
Date: Tue, 24 Apr 2018 17:38:24 +0200
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <877eow7gy7.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Cake] [PATCH iproute2-next v3] Add support for cake qdisc
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Tue, 24 Apr 2018 15:38:26 -0000

Stephen Hemminger <stephen@networkplumber.org> writes:

> On Tue, 24 Apr 2018 16:52:57 +0200
> Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk> wrote:
>
>> Well, this is leftover from keeping track of different versions of the
>> out-of-tree patch, and we already broke compatibility pretty thoroughly
>> as a preparation for upstreaming. So I'm fine with dropping the version
>> check; will resend.
>>=20
>> That being said, the versioning comes from the XSTATS API, which does
>> not use netlink attributes for its members, but rather passes through as
>> struct. So what is one supposed to do in this case?
>
> If a structure is likely to change, then it should be decomposed into nes=
ted
> netlink attributes. Once you send a structure over userspace API in netli=
nk
> it is fixed forever.

Right. Is decomposing stats into netlink attributes actually possible
within the qdisc dump_stats callback? Could we do something like:

nla_start_nest(d->skb, TCA_CAKE_STATS);

from within cake_dump_stats() and read it in cake_print_xstats in tc?

-Toke