From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Sebastian Moeller <moeller0@gmx.de>
Cc: cake@lists.bufferbloat.net
Subject: Re: [Cake] Long-RTT broken again
Date: Tue, 03 Nov 2015 12:45:49 +0100 [thread overview]
Message-ID: <878u6fpaqa.fsf@toke.dk> (raw)
In-Reply-To: <355718FB-BE85-4C53-BE85-48367A62B923@gmx.de> (Sebastian Moeller's message of "Tue, 3 Nov 2015 12:08:15 +0100")
Sebastian Moeller <moeller0@gmx.de> writes:
>> BUG_ON I put in the category of "Never test for a condition you don't
>> know how to handle" ;-) Now that the off-by-one has been stomped on I'm
>> going to stick my neck out and say that bin_cnt > 8 implies something
>> has stomped on our config structure and we really shouldn't be trusting
>> anything in it. Goodness knows what our skb queues are like...and err,
>> help! Also note that the correctly written BUG_ON didn't explode for
>> many months.
>
> Well, not my call, but I have seen discussions on LKML about
> this topic with the general gist that a BUG_ON needs to be
> justified, and only be there is the situation is not
> salvageable. After all we take down a whole machine that might
> be doing something really really important...
The right thing to do would be to reject the netlink request and not
change anything.
-Toke
next prev parent reply other threads:[~2015-11-03 11:45 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 16:53 Toke Høiland-Jørgensen
2015-11-02 18:29 ` Sebastian Moeller
2015-11-03 1:39 ` Jonathan Morton
2015-11-03 8:20 ` Sebastian Moeller
2015-11-03 8:25 ` Jonathan Morton
2015-11-03 8:34 ` Sebastian Moeller
2015-11-03 10:29 ` Kevin Darbyshire-Bryant
2015-11-03 11:08 ` Sebastian Moeller
2015-11-03 11:45 ` Toke Høiland-Jørgensen [this message]
2015-11-03 11:57 ` Toke Høiland-Jørgensen
2015-11-03 12:41 ` Sebastian Moeller
2015-11-03 11:50 ` Toke Høiland-Jørgensen
2015-11-03 16:43 ` Jonathan Morton
2015-11-03 17:05 ` Toke Høiland-Jørgensen
2015-11-03 17:11 ` Sebastian Moeller
2015-11-03 17:25 ` Toke Høiland-Jørgensen
2015-11-03 17:31 ` Jonathan Morton
2015-11-03 17:33 ` Toke Høiland-Jørgensen
2015-11-03 17:46 ` Sebastian Moeller
2015-11-03 17:49 ` Toke Høiland-Jørgensen
2015-11-03 17:52 ` Sebastian Moeller
2015-11-03 17:54 ` Toke Høiland-Jørgensen
2015-11-03 17:57 ` Sebastian Moeller
2015-11-03 17:59 ` Toke Høiland-Jørgensen
2015-11-03 18:06 ` Sebastian Moeller
2015-11-03 19:17 ` Jonathan Morton
2015-11-03 19:24 ` Sebastian Moeller
2015-11-05 14:36 ` Toke Høiland-Jørgensen
2015-11-05 19:30 ` Jonathan Morton
2015-11-06 11:00 ` Toke Høiland-Jørgensen
2015-11-06 14:15 ` Toke Høiland-Jørgensen
2015-11-06 15:09 ` Toke Høiland-Jørgensen
2015-11-07 5:02 ` Jonathan Morton
2015-11-07 5:16 ` Dave Taht
2015-11-07 6:49 ` Jonathan Morton
2015-11-07 8:48 ` Toke Høiland-Jørgensen
2015-11-07 10:51 ` Jonathan Morton
2015-11-07 13:06 ` Jonathan Morton
2015-11-07 13:42 ` Toke Høiland-Jørgensen
2015-11-07 16:34 ` Toke Høiland-Jørgensen
2015-11-07 13:44 ` Toke Høiland-Jørgensen
2015-11-07 15:08 ` Sebastian Moeller
2015-11-07 16:24 ` Toke Høiland-Jørgensen
2015-11-07 18:25 ` Sebastian Moeller
2015-11-07 19:32 ` Kevin Darbyshire-Bryant
2015-11-08 16:29 ` Dave Taht
2015-11-11 10:23 ` Kevin Darbyshire-Bryant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878u6fpaqa.fsf@toke.dk \
--to=toke@toke.dk \
--cc=cake@lists.bufferbloat.net \
--cc=moeller0@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox