From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <toke@toke.dk>
Received: from mail.toke.dk (mail.toke.dk [IPv6:2001:470:dc45:1000::1])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id 668CD3B2A4
 for <cake@lists.bufferbloat.net>; Fri,  6 Jul 2018 08:00:26 -0400 (EDT)
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023;
 t=1530878425; bh=+TKhFmfJdNJV09j22787E3r361lNMaSlWzMBHv3xQX0=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=ad4yr5GOquHuJlBa2Y2YLuM2cDk6g5M8HixJsb2MzrBVtd4KuXWHXNlOARup4n/kB
 O2nm0hQ34tNaUt8KOp/x6cW66KCPTKo5TmnitYfOUVnSfAUAVHTNCO0GW+CMQI6dz4
 m+8AOyW0ZSGSz0LLV+lIG7n9opj89UHz8AKnDaDJ05DylkZTSdAbHigAodQ5psUpvk
 7sPh54oKhZ7qO88OV89mzG0v/3eaMr6XFjIDOHUHf9El7bNIbRz5SdC4/wztF4m6Q5
 ZRLmJeY7y8K9kKZ0GMil+kk3OGajsej8ci2tArf0SpID15NhkUO7iMMzGRKs/zK9Ye
 XfFT4CQBhoByA==
To: Jonathan Morton <chromatix99@gmail.com>
Cc: cake@lists.bufferbloat.net
In-Reply-To: <20180706115745.2791-1-toke@toke.dk>
References: <20180706115745.2791-1-toke@toke.dk>
Date: Fri, 06 Jul 2018 14:00:23 +0200
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <87a7r4bmlk.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Cake] [PATCH] Keep an internal counter for total queue length
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Fri, 06 Jul 2018 12:00:26 -0000

Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk> writes:

> Since sch->q.qlen can be changed from outside cake, we can't rely on it f=
or
> break loops etc. So keep an internal counter that mirrors it and use that
> for all checks.

Sent this as a patch to avoid stepping on your toes if you are working
on the code now :)

-Toke