[Cake] tc not showing detailed stats

[Cake] tc not showing detailed stats

[Georgios Amanakis]

Hi All,

I am running latest tc-adv (r4227) and sch-cake/cobalt (r500), and "tc
-s qdisc show" doesn't show detailed stats anymore. Latest known
working revisions for me were tc-adv:r4226 sch-cake:r494.


% tc -s qdisc show dev ens4
qdisc cake 8003: root refcnt 2 bandwidth 18Mbit diffserv3 dual-dsthost
ingress split-gso rtt 100.0ms noatm overhead 18 mpu 64 
 Sent 298679 bytes 510 pkt (dropped 0, overlimits 392 requeues 0) 
 backlog 3331b 3p requeues 0
 memory used: 4Mb of 2250000b
 min/max network layer size:           12 /      52
 min/max overhead-adjusted size:     1500 /      70
 average network hdr offset:        21076

!!!Deficit 4, rta_len=1518



George

Re: [Cake] tc not showing detailed stats

[Kevin Darbyshire-Bryant]

[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]



> On 20 May 2018, at 14:23, Georgios Amanakis <gamanakis@gmail.com> wrote:
> 
> Hi All,
> 
> I am running latest tc-adv (r4227) and sch-cake/cobalt (r500), and "tc
> -s qdisc show" doesn't show detailed stats anymore. Latest known
> working revisions for me were tc-adv:r4226 sch-cake:r494.
> 
> 
> % tc -s qdisc show dev ens4
> qdisc cake 8003: root refcnt 2 bandwidth 18Mbit diffserv3 dual-dsthost
> ingress split-gso rtt 100.0ms noatm overhead 18 mpu 64
> Sent 298679 bytes 510 pkt (dropped 0, overlimits 392 requeues 0)
> backlog 3331b 3p requeues 0
> memory used: 4Mb of 2250000b
> min/max network layer size:           12 /      52
> min/max overhead-adjusted size:     1500 /      70
> average network hdr offset:        21076
> 
> !!!Deficit 4, rta_len=1518

Hi George,

Yes I see this problem as well.  Toke & I spent some time trying to work out the problem but got diverted to other things in real life.

What platform/architecture are you trying this on?

Cheers,

Kevin D-B

012C ACB2 28C6 C53E 9775  9123 B3A2 389B 9DE2 334A


[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [Cake] tc not showing detailed stats

[Georgios Amanakis]

[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]

This is on x86_64 running 4.16.9.

On Sun, May 20, 2018, 11:43 AM Kevin Darbyshire-Bryant <
kevin@darbyshire-bryant.me.uk> wrote:

>
>
> > On 20 May 2018, at 14:23, Georgios Amanakis <gamanakis@gmail.com> wrote:
> >
> > Hi All,
> >
> > I am running latest tc-adv (r4227) and sch-cake/cobalt (r500), and "tc
> > -s qdisc show" doesn't show detailed stats anymore. Latest known
> > working revisions for me were tc-adv:r4226 sch-cake:r494.
> >
> >
> > % tc -s qdisc show dev ens4
> > qdisc cake 8003: root refcnt 2 bandwidth 18Mbit diffserv3 dual-dsthost
> > ingress split-gso rtt 100.0ms noatm overhead 18 mpu 64
> > Sent 298679 bytes 510 pkt (dropped 0, overlimits 392 requeues 0)
> > backlog 3331b 3p requeues 0
> > memory used: 4Mb of 2250000b
> > min/max network layer size:           12 /      52
> > min/max overhead-adjusted size:     1500 /      70
> > average network hdr offset:        21076
> >
> > !!!Deficit 4, rta_len=1518
>
> Hi George,
>
> Yes I see this problem as well.  Toke & I spent some time trying to work
> out the problem but got diverted to other things in real life.
>
> What platform/architecture are you trying this on?
>
> Cheers,
>
> Kevin D-B
>
> 012C ACB2 28C6 C53E 9775  9123 B3A2 389B 9DE2 334A
>
>

[-- Attachment #2: Type: text/html, Size: 1778 bytes --]

Re: [Cake] tc not showing detailed stats

[Toke Høiland-Jørgensen]

Georgios Amanakis <gamanakis@gmail.com> writes:

> This is on x86_64 running 4.16.9.

OK, that is decidedly odd. I have just spent the last several hours
debugging this, and I'm starting to lean towards this being an unrelated
bug in openwrt, or something triggering such a bug. It seems tc doesn't
get the 'TCA_STATS2' attribute, for *any* qdiscs... I have no idea why.

>> > On 20 May 2018, at 14:23, Georgios Amanakis <gamanakis@gmail.com> wrote:
>> >
>> > Hi All,
>> >
>> > I am running latest tc-adv (r4227) and sch-cake/cobalt (r500), and "tc
>> > -s qdisc show" doesn't show detailed stats anymore. Latest known
>> > working revisions for me were tc-adv:r4226 sch-cake:r494.

What are the corresponding git commits; and does it still work if you
revert to the previous versions of tc-adv/cake? How are you building
tc-adv?

-Toke

Re: [Cake] tc not showing detailed stats

[Toke Høiland-Jørgensen]

Toke Høiland-Jørgensen <toke@toke.dk> writes:

> Georgios Amanakis <gamanakis@gmail.com> writes:
>
>> This is on x86_64 running 4.16.9.
>
> OK, that is decidedly odd. I have just spent the last several hours
> debugging this, and I'm starting to lean towards this being an unrelated
> bug in openwrt, or something triggering such a bug. It seems tc doesn't
> get the 'TCA_STATS2' attribute, for *any* qdiscs... I have no idea why.
>
>>> > On 20 May 2018, at 14:23, Georgios Amanakis <gamanakis@gmail.com> wrote:
>>> >
>>> > Hi All,
>>> >
>>> > I am running latest tc-adv (r4227) and sch-cake/cobalt (r500), and "tc
>>> > -s qdisc show" doesn't show detailed stats anymore. Latest known
>>> > working revisions for me were tc-adv:r4226 sch-cake:r494.
>
> What are the corresponding git commits; and does it still work if you
> revert to the previous versions of tc-adv/cake? How are you building
> tc-adv?

Also, which kernel version?

-Toke

Re: [Cake] tc not showing detailed stats

[Georgios Amanakis]

I am running everything on 4.16.9.
It seems the culprit is sch-cake.
tc-adv@d52fe00 and sch-cake@66e5d6 : detailed stats are printed
tc-adv@d52fe00 and sch-cake@842d7f : details not printed anymore. 

Could it be that the culprit is sch-cake@842d7f?

George

Re: [Cake] tc not showing detailed stats

[Toke Høiland-Jørgensen]

Georgios Amanakis <gamanakis@gmail.com> writes:

> I am running everything on 4.16.9.
> It seems the culprit is sch-cake.
> tc-adv@d52fe00 and sch-cake@66e5d6 : detailed stats are printed
> tc-adv@d52fe00 and sch-cake@842d7f : details not printed anymore. 
>
> Could it be that the culprit is sch-cake@842d7f?

Well, that commit breaks compatibility with tc-adv (again :P). You'll
need to recompile tc-adv and make sure you have commit
aa554002af169a135cb82fb809842f5d7afce309

-Toke

Re: [Cake] tc not showing detailed stats

[Georgios Amanakis]

I am well aware of that :)
On my system though with tc-adv@aa554002 and sch_cake/cobalt@842d7f0
it doesn't produce any detailed stats:

% tc -s qdisc show
qdisc cake 8009: dev ens4 root refcnt 2 bandwidth 18Mbit diffserv3
dual-dsthost ingress split-gso rtt 100.0ms noatm overhead 18 mpu 64 
 Sent 5098 bytes 35 pkt (dropped 0, overlimits 0 requeues 0) 
 backlog 0b 0p requeues 0
 memory used: 4Mb of 2250000b
 min/max network layer size:            2 /      88
 min/max overhead-adjusted size:      248 /     106
 average network hdr offset:         2304

!!!Deficit 4, rta_len=266


I bisected it and it's definitely commit sch_cake/cobalt@842d7f0.
Now if I introduce TCA_CAKE_STATS_PAD at the end of the enum, this
resolves the bug. i.e.:

--- a/pkt_sched.h
+++ b/pkt_sched.h
@@ -883,7 +883,6 @@ enum {
 
 enum {
        __TCA_CAKE_STATS_INVALID,
-       TCA_CAKE_STATS_PAD,
        TCA_CAKE_STATS_CAPACITY_ESTIMATE64,
        TCA_CAKE_STATS_MEMORY_LIMIT,
        TCA_CAKE_STATS_MEMORY_USED,
@@ -893,6 +892,7 @@ enum {
        TCA_CAKE_STATS_MIN_ADJLEN,
        TCA_CAKE_STATS_MAX_ADJLEN,
        TCA_CAKE_STATS_TIN_STATS,
+       TCA_CAKE_STATS_PAD,
        __TCA_CAKE_STATS_MAX
 };



George

Re: [Cake] tc not showing detailed stats

[Toke Høiland-Jørgensen]

Georgios Amanakis <gamanakis@gmail.com> writes:

> I am well aware of that :)
> On my system though with tc-adv@aa554002 and sch_cake/cobalt@842d7f0
> it doesn't produce any detailed stats:

Hmm, the thing is that I can reproduce your error if I use commit
d52fe0077637caa1e3a4b1242d2bf935929b8275 in tc-adv I can reproduce your
error, but not if I use the current HEAD (aa554002). So I'm guessing
there's something else going on here, and moving the PAD attribute is
just treating a symptom. Did you do `make clean && make` in the tc-adv
repo? Just changing pkt_sched.h doesn't trigger a rebuild if you just
run make...

-Toke

Re: [Cake] tc not showing detailed stats

[Georgios Amanakis]

[-- Attachment #1: Type: text/plain, Size: 968 bytes --]

Of course you are right. I was using archlinux's build system which
produces the bug somehow. If I compile directly from the source everything
works normal.

I am sorry for the mess this caused.


George

On Mon, May 21, 2018, 10:00 AM Toke Høiland-Jørgensen <toke@toke.dk> wrote:

> Georgios Amanakis <gamanakis@gmail.com> writes:
>
> > I am well aware of that :)
> > On my system though with tc-adv@aa554002 and sch_cake/cobalt@842d7f0
> > it doesn't produce any detailed stats:
>
> Hmm, the thing is that I can reproduce your error if I use commit
> d52fe0077637caa1e3a4b1242d2bf935929b8275 in tc-adv I can reproduce your
> error, but not if I use the current HEAD (aa554002). So I'm guessing
> there's something else going on here, and moving the PAD attribute is
> just treating a symptom. Did you do `make clean && make` in the tc-adv
> repo? Just changing pkt_sched.h doesn't trigger a rebuild if you just
> run make...
>
> -Toke
>

[-- Attachment #2: Type: text/html, Size: 1458 bytes --]

Re: [Cake] tc not showing detailed stats

[Toke Høiland-Jørgensen]

Georgios Amanakis <gamanakis@gmail.com> writes:

> Of course you are right. I was using archlinux's build system which
> produces the bug somehow. If I compile directly from the source everything
> works normal.
>
> I am sorry for the mess this caused.

No worries. We are still debugging another issue like it on openwrt...
And apologies for the frequent API changes; I am making it a bit harder
to track git for the time being...

-Toke