[Cake] Running Cake at long RTTs

["Toke Høiland-Jørgensen" <toke@toke.dk>]

[-- Attachment #1: Type: text/plain, Size: 737 bytes --]

So Dave and I did a bit of testing of Cake at a 1-second base RTT. That
showed that, compared with a straight FIFO queue (with a sufficiently
large buffer), throughput was suffering quite a bit under Cake,
especially at large bandwidths. We did two changes to fix this:

- Turn the hard packet queue size into a lower bound rather than an
  upper bound.

- Scale the target to be 1/16th of the interval.

The first change allows Cake to actually reach the target throughput,
but it still takes a long while to get there. With the second change, we
actually get the desired behaviour. The attached plot shows the
difference, with the solid line being before the change and the dashed
line being after the change.

Patch attached.

-Toke


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: cake-longrtt.patch --]
[-- Type: text/x-diff, Size: 859 bytes --]

diff --git a/sch_cake.c b/sch_cake.c
index c97a212..91e556c 100644
--- a/sch_cake.c
+++ b/sch_cake.c
@@ -854,10 +854,11 @@ static void cake_set_rate(struct cake_tin_data *b, u64 rate, u32 mtu,
 
 	byte_target_ns = (byte_target * rate_ns) >> rate_shft;
 
-	b->cparams.target = max(byte_target_ns, ns_target);
 	b->cparams.interval = max(rtt_est_ns +
 				     b->cparams.target - ns_target,
 				     b->cparams.target * 8);
+	b->cparams.target = max(max(byte_target_ns, ns_target),
+				b->cparams.interval >> 4);
 	b->cparams.threshold = (b->cparams.target >> 15) *
 		(b->cparams.interval >> 15) * 2;
 
@@ -1144,7 +1145,7 @@ static void cake_reconfigure(struct Qdisc *sch)
 		q->peel_threshold = 0;
 	}
 
-	q->buffer_limit = min(q->buffer_limit, sch->limit *
+	q->buffer_limit = max(q->buffer_limit, sch->limit *
 			      psched_mtu(qdisc_dev(sch)));
 }
 

[-- Attachment #3: cake-longrtt.pdf --]
[-- Type: application/pdf, Size: 149611 bytes --]