From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>,
cake@lists.bufferbloat.net
Subject: Re: [Cake] [PATCH 1/2] cake: print_uint format fixes
Date: Sun, 11 Mar 2018 21:49:55 +0100 [thread overview]
Message-ID: <87bmfujq18.fsf@toke.dk> (raw)
In-Reply-To: <20180311091930.86264-2-ldir@darbyshire-bryant.me.uk>
Thank you for the patch! :)
> Signed-off-by: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
> ---
> tc/q_cake.c | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/tc/q_cake.c b/tc/q_cake.c
> index 44cadb63..f888bd2a 100644
> --- a/tc/q_cake.c
> +++ b/tc/q_cake.c
> @@ -47,6 +47,7 @@
> #include <netinet/in.h>
> #include <arpa/inet.h>
> #include <string.h>
> +#include <inttypes.h>
>
> #include "utils.h"
> #include "tc_util.h"
> @@ -557,10 +558,10 @@ static int cake_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt)
> else if (!raw)
> print_string(PRINT_ANY, "atm", "%s ", "noatm");
>
> - print_uint(PRINT_ANY, "overhead", "overhead %d ", overhead);
> + print_uint(PRINT_ANY, "overhead", "overhead %" PRId64 " ",
> overhead);
Guess this should actually be print_int(), since overhead can be
negative?
-Toke
next prev parent reply other threads:[~2018-03-11 20:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-11 9:19 [Cake] fixing tc cake output since json-ification Kevin Darbyshire-Bryant
2018-03-11 9:19 ` [Cake] [PATCH 1/2] cake: print_uint format fixes Kevin Darbyshire-Bryant
2018-03-11 20:49 ` Toke Høiland-Jørgensen [this message]
2018-03-11 22:10 ` Kevin Darbyshire-Bryant
2018-03-11 23:34 ` Stephen Hemminger
2018-03-12 9:28 ` Kevin Darbyshire-Bryant
2018-03-12 9:56 ` Toke Høiland-Jørgensen
2018-03-12 15:11 ` Stephen Hemminger
2018-03-12 15:38 ` Toke Høiland-Jørgensen
2018-03-12 21:44 ` Kevin Darbyshire-Bryant
2018-03-16 8:02 ` Kevin Darbyshire-Bryant
2018-03-17 14:33 ` Toke Høiland-Jørgensen
2018-03-11 9:19 ` [Cake] [PATCH 2/2] tc " Kevin Darbyshire-Bryant
2018-03-11 20:50 ` Toke Høiland-Jørgensen
2018-03-11 20:57 ` Kevin Darbyshire-Bryant
2018-03-11 21:22 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmfujq18.fsf@toke.dk \
--to=toke@toke.dk \
--cc=cake@lists.bufferbloat.net \
--cc=ldir@darbyshire-bryant.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox