From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <toke@toke.dk>
Received: from mail.toke.dk (mail.toke.dk [IPv6:2001:470:dc45:1000::1])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id 10AFC3CB41
 for <cake@lists.bufferbloat.net>; Sun, 11 Mar 2018 16:49:58 -0400 (EDT)
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023;
 t=1520801396; bh=86ki1EN1qxi+oSEHINMqm2UO3y2TFlv85Ci5sU2ge4k=;
 h=From:To:Subject:In-Reply-To:References:Date:From;
 b=zDAQELMxicNwHKZEGkkFmqijwJOOpHEe5DHg04owzQyHFjSUwKcjoOq5s4CTNavjn
 dkG7Q1vsXX9IaVOJggtUQ0nw1g0ZUI11XbdUzJ1vhhQc1NY7ecM5tPtHoebspYptEB
 2EabZAvZ/3w7KXfBKF4qBgOrcUfo4wDTfiziCY+LLW/I3YjJKv548HUggclMX8wSck
 IJGhCRjuUDQk68d17lQrM3lwUtQ7QLGKc43+XGjIkEw7qcULzccpzrSVPYbpEiUVOs
 HND5U/QQ0A7zAr4AeB+6jJU7p9oXO4OH8N0hWSUQZbwuNYAmgIneZSDEv+Ui0hE3os
 ypVscxmjdql6Q==
To: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>,
 cake@lists.bufferbloat.net
In-Reply-To: <20180311091930.86264-2-ldir@darbyshire-bryant.me.uk>
References: <20180311091930.86264-1-ldir@darbyshire-bryant.me.uk>
 <20180311091930.86264-2-ldir@darbyshire-bryant.me.uk>
Date: Sun, 11 Mar 2018 21:49:55 +0100
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <87bmfujq18.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Cake] [PATCH 1/2] cake: print_uint format fixes
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Sun, 11 Mar 2018 20:49:58 -0000

Thank you for the patch! :)

> Signed-off-by: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
> ---
>  tc/q_cake.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/tc/q_cake.c b/tc/q_cake.c
> index 44cadb63..f888bd2a 100644
> --- a/tc/q_cake.c
> +++ b/tc/q_cake.c
> @@ -47,6 +47,7 @@
>  #include <netinet/in.h>
>  #include <arpa/inet.h>
>  #include <string.h>
> +#include <inttypes.h>
>  
>  #include "utils.h"
>  #include "tc_util.h"
> @@ -557,10 +558,10 @@ static int cake_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt)
>  	else if (!raw)
>  		print_string(PRINT_ANY, "atm", "%s ", "noatm");
>  
> -	print_uint(PRINT_ANY, "overhead", "overhead %d ", overhead);
> +	print_uint(PRINT_ANY, "overhead", "overhead %" PRId64 " ",
> overhead);

Guess this should actually be print_int(), since overhead can be
negative?

-Toke