From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.taht.net (mail.taht.net [176.58.107.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id C2FA53B2A4 for ; Fri, 24 Nov 2017 15:53:36 -0500 (EST) Received: from nemesis.taht.net (unknown [IPv6:2603:3024:1536:86f0:2e0:4cff:fec1:1206]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.taht.net (Postfix) with ESMTPSA id 4DFF9220ED; Fri, 24 Nov 2017 20:53:35 +0000 (UTC) From: Dave Taht To: Marcelo Ricardo Leitner Cc: Stephen Hemminger , cake@lists.bufferbloat.net References: <1511309382-24060-1-git-send-email-dave.taht@gmail.com> <1511309382-24060-2-git-send-email-dave.taht@gmail.com> <20171121165513.036b01da@xeon-e3> <87shd7ruwh.fsf@nemesis.taht.net> <20171124133317.GB32400@localhost.localdomain> Date: Fri, 24 Nov 2017 12:53:33 -0800 In-Reply-To: <20171124133317.GB32400@localhost.localdomain> (Marcelo Ricardo Leitner's message of "Fri, 24 Nov 2017 11:33:18 -0200") Message-ID: <87bmjrwg8i.fsf@nemesis.taht.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Cake] [PATCH 1/3] pkt_sched.h: add support for sch_cake API X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Nov 2017 20:53:36 -0000 Marcelo Ricardo Leitner writes: > On Tue, Nov 21, 2017 at 04:58:54PM -0800, Dave Taht wrote: >> Stephen Hemminger writes: > ... >> > Also, when I see multiple arrays of same size. It seems the API should >> > be: >> > struct tc_cake_tin_stats { >> > __u32 threshold_rate; >> > __u32 target_us; >> > struct tc_cake_traffic_stats sent; >> > ... >> > >> > What if you want to change number of TINS, the ABI shouldn't have to change. >> >> It is hard to imagine ever wanting more than 8 tins. Using up 3, sanely, >> has proven hard. > > Which means each stats dump will almost always dump 5 empty TINS, > while if it were dynamic, it could dump only the 1, 2 or 3 in use and > probably help with the stats dump performance. Smaller slab, less > bytes to copy, ... It is not a lot of data, and well under under a page in size, which is the minimum for a userspace copy. (1080 bytes or so I think). The existing API has proven easy to extend, and changing the mechanism would require a flag day for the places where cake is used presently. Part of my reluctance is that cake's current main use case (today) is on a small home router which has - at most - two instances of cake running, and people (aside from the flent folk) are not polling it madly. Those that want to leverage it for traffic engineering in the data center, for hundreds or thousands of sub qdiscs, should try to express what their problems are now with existing qdiscs, and how cake could evolve to help solve those. Certainly having hw mq support would help there, among other things. > > Marcelo