From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <toke@toke.dk>
Received: from mail.toke.dk (mail.toke.dk [IPv6:2001:470:dc45:1000::1])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id D09D53B29E
 for <cake@lists.bufferbloat.net>; Thu,  3 May 2018 11:28:28 -0400 (EDT)
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023;
 t=1525361306; bh=uCL9maLHGP7aLtXgli9mzZF6GbAAglg9UVZ0FHtlSfU=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=Xdx94Dx+IbVNVAB/rarL4M8L+bJCPEktqBqVF7JcuxHlND4YYBQx+fRMaP7BuTla8
 llK8bs1/sq/b4keoWE7Q8DK1/LNbtHh2+C0PzqSecz0CLZ991hNhi1VPwWAJcpauRT
 NNO/hfwL1UJCNOx3Ix7i+WyHfLdsgF0re6yCdzA+LLiU4s+2VobxTae73Ga1gjgzwX
 PRr9NYhaQ1lsFxShu8geyc+rgxAX8cZy+mCWTfJqcQtnIMAumXRSLUnaRz0JP3OTzq
 VpYsV0w/F1FHgh+4WOO1jpVEWl9Evrkj6yflDcXW8tAp70n4BzuP+79nU6Z0tSgsEH
 3WheAsrylAQfA==
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net
In-Reply-To: <20180503.112402.774278226377528271.davem@davemloft.net>
References: <152527385803.14936.8396262019181995139.stgit@alrua-kau>
 <152527386316.14936.5409621935637217368.stgit@alrua-kau>
 <20180503.112402.774278226377528271.davem@davemloft.net>
Date: Thu, 03 May 2018 17:28:26 +0200
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <87d0ycyd0l.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Cake] [PATCH net-next v7 1/7] sched: Add Common Applications
	Kept Enhanced (cake) qdisc
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Thu, 03 May 2018 15:28:29 -0000

David Miller <davem@davemloft.net> writes:

> From: Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk>
> Date: Wed, 02 May 2018 17:11:03 +0200
>
>> diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c
>> new file mode 100644
>> index 000000000000..18bc147f12bc
>> --- /dev/null
>> +++ b/net/sched/sch_cake.c
>> +static inline cobalt_time_t cobalt_get_time(void)
>> +{
>> +	return ktime_get_ns();
>> +}
>
> Please do not use inline in foo.c files, let the compiler decide.

Right, will fix :)

>> +static inline u32
>> +cake_hash(struct cake_tin_data *q, const struct sk_buff *skb, int flow_=
mode)
>> +{
>
> Especially for this monster!  Yikes!

Fair point...