From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; dkim=pass header.d=toke.dk; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=toke.dk policy.dmarc=reject From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1768388054; bh=ebA5xYZs+17O4zaAsWAKepT51kZFKCWS1n0x4EfFURg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=gzMW+j3Qw9O4WKbG/prvJRpqAFP4vz9w5tZ0PzYaBdsX1x+kFpGnhnWwihMQViWm7 7XqQiEz3wVNUaucnmfVmPYNqkqQUbpQKXfwsYoQ0ia+I9dbX9L4nuFzH8d7j0KHhRn R7jZWOi0obkMVYigAKLVS84JAfq5DKsvDNYjMoar6UnUBpJRnnpUxG37e/N/fgMlzz /CB4rHb5KlEIRB7GNg0Yi28zNfo5e4Lx8aQHJNoZFlPfi1xxy5edWVYPf6R9a3gHll Kc3S/JQsImCeWECBqeVp0cWJTmV0hqQvslI3+kmkJ3KK1DVFsjOjeIjnXobU80Ubgi HOAkCquwjVLQA== To: Eric Dumazet Cc: Jamal Hadi Salim , Cong Wang , Jiri Pirko , Paolo Abeni , "David S. Miller" , Jakub Kicinski , Simon Horman , cake@lists.bufferbloat.net, netdev@vger.kernel.org In-Reply-To: References: <20260113143157.2581680-1-toke@redhat.com> Date: Wed, 14 Jan 2026 11:54:12 +0100 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87ecns1n3f.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: XYGYLE4KJTJIFMVYCZ2LCNIYYRSGEMSA X-Message-ID-Hash: XYGYLE4KJTJIFMVYCZ2LCNIYYRSGEMSA X-MailFrom: toke@toke.dk X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH net-next] net/sched: cake: avoid separate allocation of struct cake_sched_config List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Eric Dumazet writes: > On Tue, Jan 13, 2026 at 3:32=E2=80=AFPM Toke H=C3=B8iland-J=C3=B8rgensen = wrote: >> >> Paolo pointed out that we can avoid separately allocating struct >> cake_sched_config even in the non-mq case, by embedding it into struct >> cake_sched_data. This reduces the complexity of the logic that swaps the >> pointers and frees the old value, at the cost of adding 56 bytes to the >> latter. Since cake_sched_data is already almost 17k bytes, this seems >> like a reasonable tradeoff. >> >> Suggested-by: Paolo Abeni >> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen >> --- > > This is also fixing a panic, so : > > Fixes: bc0ce2bad36c ("net/sched: sch_cake: Factor out config variables > into separate struct") > > For the record, a fix for the panic would be : Ah yes, of course; thanks for noticing (and for the tag)! -Toke