Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

["Toke Høiland-Jørgensen" <toke@toke.dk>]

Sebastian Moeller <moeller0@gmx.de> writes:

>> diff --git a/tc/q_cake.c b/tc/q_cake.c
>> index e21552e8..95301b41 100644
>> --- a/tc/q_cake.c
>> +++ b/tc/q_cake.c
>> @@ -243,12 +243,22 @@ static int cake_parse_opt(struct qdisc_util *qu, int argc, char **argv,
>>                /* Typical VDSL2 framing schemes, both over PTM */
>>                /* PTM has 64b/65b coding which absorbs some bandwidth */
>>                } else if (strcmp(*argv, "pppoe-ptm") == 0) {
>> +                       /* 2B PPP + 6B PPPoE + 6B dest MAC + 6B src MAC
>> +                        * + 2B ethertype + 4B Frame Check Sequence
>> +                        * + 1B Start of Frame (S) + 1B End of Frame (Ck)
>> +                        * + 2B TC-CRC (PTM-FCS) = 30B
>> +                        */
>>                        atm = 2;
>> -                       overhead += 27;
>> +                       overhead += 30;
>>                        overhead_set = true;
>>                } else if (strcmp(*argv, "bridged-ptm") == 0) {
>> +                       /* 6B dest MAC + 6B src MAC + 2B ethertype
>> +                        * + 4B Frame Check Sequence
>> +                        * + 1B Start of Frame (S) + 1B End of Frame (Ck)
>> +                        * + 2B TC-CRC (PTM-FCS) = 22B
>> +                        */
>>                        atm = 2;
>> -                       overhead += 19;
>> +                       overhead += 22;
>>                        overhead_set = true;
>> 
>> 
>> 
>> 
>> I assume 30 and 22 are the correct values? Could someone confirm this? :)
>
> 	As I made that change all I can confirm that at the current time
> 	I am convinced that 30 and 22 are the correct values. I did look
> 	into the ITU standard documents for VDSL and to the best of my
> 	knowledge these agree.

Awesome. Pushed that change to the tc-adv repo. Which means that the
cake-specific bits of both repos are now identical; but the tc-adv repo
is up-to-date with upstream iproute2-next.

I'll see if I can cook up a patch for openwrt...

-Toke