From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [52.28.52.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 2BDE03CB45 for ; Wed, 7 Mar 2018 09:30:54 -0500 (EST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1520433053; bh=rcp7AVevqR58eyyTIHOHS+RCoc9HRHUmMfbWTrkPvYo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=YsGfxb0gH40vksQjsgzGTwai2q3oE+NLUgapf0bduL1SgC6WEXepwPtAGcGD8fvzC D+Wgc7pIGp3lZmrfaZoyhtnEqLrYwYAEtrwI27/BqWTx09GGt6I0s4GIQlKFiSz5dZ nQielxa1wnEtNWgm+Jo1lwoItRrUZ5ngvQpNn0GLxDmEkhUwYAYntkb/EatLQuPgIc RMtvKeuxaoAYUtGl9ABQqF21kHFeVzHFpX0cFxqoo1WAi9IR5Q8FAWJPIJtFXIeJv3 MbW4Dle6xTmmlRIEyHuidL+5fj1N0Eu9ftFN3KFozuyOku6RItAzD5WsuAIWnCWZxs oeBN8I6HrwWew== To: Sebastian Moeller Cc: Kevin Darbyshire-Bryant , "cake\@lists.bufferbloat.net" In-Reply-To: <70CC0AF0-1C86-4998-909A-503B65122E93@gmx.de> References: <20180127130542.25817-1-toke@toke.dk> <20180211172618.13297-1-toke@toke.dk> <20180211172618.13297-2-toke@toke.dk> <20180306075616.380a533c@xeon-e3> <87ina9m4up.fsf@toke.dk> <876068nccm.fsf@toke.dk> <0A156FD3-4816-462C-952B-7938EF8C0EA3@gmail.com> <87sh9cl15n.fsf@toke.dk> <879005B6-2334-4F46-9922-4BC2CACBF107@darbyshire-bryant.me.uk> <87vae8yy68.fsf@toke.dk> <87sh9cyxy9.fsf@toke.dk> <340269AF-2325-4657-8939-5E3195D1C0DC@darbyshire-bryant.me.uk> <87muzkyvj7.fsf@toke.dk> <11DDD9A0-BBD7-4DAA-ACE1-EB88CDC26E7C@darbyshire-bryant.me.uk> <87h8psyraq.fsf@toke.dk> <70CC0AF0-1C86-4998-909A-503B65122E93@gmx.de> Date: Wed, 07 Mar 2018 15:30:52 +0100 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87efkw2c0z.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 14:30:54 -0000 Sebastian Moeller writes: >> diff --git a/tc/q_cake.c b/tc/q_cake.c >> index e21552e8..95301b41 100644 >> --- a/tc/q_cake.c >> +++ b/tc/q_cake.c >> @@ -243,12 +243,22 @@ static int cake_parse_opt(struct qdisc_util *qu, int argc, char **argv, >> /* Typical VDSL2 framing schemes, both over PTM */ >> /* PTM has 64b/65b coding which absorbs some bandwidth */ >> } else if (strcmp(*argv, "pppoe-ptm") == 0) { >> + /* 2B PPP + 6B PPPoE + 6B dest MAC + 6B src MAC >> + * + 2B ethertype + 4B Frame Check Sequence >> + * + 1B Start of Frame (S) + 1B End of Frame (Ck) >> + * + 2B TC-CRC (PTM-FCS) = 30B >> + */ >> atm = 2; >> - overhead += 27; >> + overhead += 30; >> overhead_set = true; >> } else if (strcmp(*argv, "bridged-ptm") == 0) { >> + /* 6B dest MAC + 6B src MAC + 2B ethertype >> + * + 4B Frame Check Sequence >> + * + 1B Start of Frame (S) + 1B End of Frame (Ck) >> + * + 2B TC-CRC (PTM-FCS) = 22B >> + */ >> atm = 2; >> - overhead += 19; >> + overhead += 22; >> overhead_set = true; >> >> >> >> >> I assume 30 and 22 are the correct values? Could someone confirm this? :) > > As I made that change all I can confirm that at the current time > I am convinced that 30 and 22 are the correct values. I did look > into the ITU standard documents for VDSL and to the best of my > knowledge these agree. Awesome. Pushed that change to the tc-adv repo. Which means that the cake-specific bits of both repos are now identical; but the tc-adv repo is up-to-date with upstream iproute2-next. I'll see if I can cook up a patch for openwrt... -Toke