From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [IPv6:2a0c:4d80:42:2001::664]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id A5C0C3B2A4 for ; Thu, 9 Jan 2025 11:35:15 -0500 (EST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1736440514; bh=ANbjk8gqhN0il2QO5ixDt4BuDf3BmOKAImjLOA2m5+0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=w1CovmHm+9bvL/zZ07yGdFcwZ1dyVGwl3B+98WXgP83QWcN3SEE49S8bOurAIKqRR 9B7U69aDFWjVFFnvQPWrgKsT3SDVpJupIFrIqipzixAdTvg0dDpPgBeI340aKJaMKc cOu0VSt0A8TID14Gp+iUwr8rOVgKIt9pPNlXF/mYVPGXNyeZGStJz8YNxhSmuE7wZd md2R3qJDq9cXB+UmaihGe+ApZpiM5CYk9GIrwoNfJKGAfB+sBk2khEjhUSMIn23bnK VeptjQMywy4XRTGPp/J4GNPWsdUWYeYSsJBP/nzPPTGCZiM/gn1QSVPvj1UfboChdN jfOIxInzjanbg== To: Jakub Kicinski Cc: Paolo Abeni , Jamal Hadi Salim , Cong Wang , Jiri Pirko , syzbot+f63600d288bfb7057424@syzkaller.appspotmail.com, "David S. Miller" , Eric Dumazet , Simon Horman , cake@lists.bufferbloat.net, netdev@vger.kernel.org In-Reply-To: <20250109081811.01b7bad1@kernel.org> References: <20250107120105.70685-1-toke@redhat.com> <87plkwi27e.fsf@toke.dk> <11915c70-ec5e-4d94-b890-f07f41094e2c@redhat.com> <87ikqohswh.fsf@toke.dk> <20250109081811.01b7bad1@kernel.org> Date: Thu, 09 Jan 2025 17:35:14 +0100 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87frlshrnh.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH net v2] sched: sch_cake: add bounds checks to host bulk flow fairness counts X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jan 2025 16:35:15 -0000 Jakub Kicinski writes: > On Thu, 09 Jan 2025 17:08:14 +0100 Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> >> I guess I should have mentioned in the commit message that this was >> >> deliberate. Since it seems you'll be editing that anyway (cf the abov= e), >> >> how about adding a paragraph like: >> >>=20 >> >> As part of this change, the flow quantum calculation is consolidated >> >> into a helper function, which means that the dithering applied to the >> >> host load scaling is now applied both in the DRR rotation and when a >> >> sparse flow's quantum is first initiated. The only user-visible effe= ct >> >> of this is that the maximum packet size that can be sent while a flow >> >> stays sparse will now vary with +/- one byte in some cases. This sho= uld >> >> not make a noticeable difference in practice, and thus it's not worth >> >> complicating the code to preserve the old behaviour.=20=20 >> > >> > It's in Jakub's hands now, possibly he could prefer a repost to reduce >> > the maintainer's overhead.=20=20 >>=20 >> Alright, sure, I'll respin :) > > Hold on, I'll do it :) Crossed streams, but thanks! :) -Toke