From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [IPv6:2a0c:4d80:42:2001::664]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 9A67D3B2A4 for ; Mon, 29 Aug 2022 04:33:58 -0400 (EDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1661762036; bh=1vMZ0dX5dY0+I40JPo+IzGf0b+MZYSJImU8ZR2XqqQs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=SoCNSiGx48l+rdngjy81aq2A4fYWJspecsZEkjjwEL2b+JT7ZTzGs7NUXr8Jzv82C tBewXXCEwolXTcG7vLIXlULQBR5sr2LXgZHuAzR8peB7CXYUrK+922upum0Dtfe8WX oqgySWoXR6LZBOnWkekISbb23xJKpdi1Q6talUdNIdqioHryYH9PAYL0CpECe6E1ne 3LBgIuIA285+22uzfJIRMY/QLrI/st0gbw0ow2HPfMnD1RpTnrYpeYTONOkn25P7xm xYZjTCT/haw87O7HyH1qD72e1AxW/raKc5QHvLyOKFxx39tJs3JtklN8Xdc41P1IwS ESfgrF2BBdlEQ== To: Zhengchao Shao , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, stephen@networkplumber.org Cc: cake@lists.bufferbloat.net, weiyongjun1@huawei.com, yuehaibing@huawei.com, shaozhengchao@huawei.com In-Reply-To: <20220829071219.208646-1-shaozhengchao@huawei.com> References: <20220829071219.208646-1-shaozhengchao@huawei.com> Date: Mon, 29 Aug 2022 10:33:55 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87fshf78jw.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH net-next, v2] net: sched: remove redundant NULL check in change hook function X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Aug 2022 08:33:58 -0000 Zhengchao Shao writes: > Currently, the change function can be called by two ways. The one way is > that qdisc_change() will call it. Before calling change function, > qdisc_change() ensures tca[TCA_OPTIONS] is not empty. The other way is > that .init() will call it. The opt parameter is also checked before > calling change function in .init(). Therefore, it's no need to check the > input parameter opt in change function. > > Signed-off-by: Zhengchao Shao for sch_cake: Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen