Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>,
	Cake List <cake@lists.bufferbloat.net>
Subject: Re: [Cake] Removing kmod-sched-cake package from openwrt
Date: Thu, 19 Jul 2018 18:08:38 +0200	[thread overview]
Message-ID: <87fu0f2oop.fsf@toke.dk> (raw)
In-Reply-To: <8915BC75-12AD-42B0-8076-3DE8D292C410@darbyshire-bryant.me.uk>

Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> writes:

> Hiya Chaps,
>
> Bet that subject woke you up!
>
> This is one for the back burner but I’d like to do it at some point,
> mainly ‘cos my name is in the maintainer field :-)
>
> Ideally I’d like to introduce cake as a kernel patch backport to
> openwrt instead of as an additional module. I’ve started out but my
> biggest stumbling block is over the conditional conntrack stuff we
> added to netfilter. The mechanism (of course) has completely changed
> between v4.18 and anything earlier and I’m quite frankly lost!
>
> Any assistance or clue on doing this pre v4.18 would be appreciated.
> I’m ok slogging through the ifdef kernel version stuff and
> changing/re-introducing for the backport… but the conditional
> conntrack has me beaten.

Yeah, considered doing a backport patch to the kernel in openwrt. But I
concluded it was not worth the trouble, since we already have a working
module from the main repo.

If you do want to go the kernel patch route, it's a matter of figuring
out which patches you'll need to add to the backport series. Basically,
figure out which parts of the patch doesn't work, run git blame on the
file it is being applied to, and find the previous patch that changes
the context. Add that to you stack of backported patches, and rinse and
repeat until your series applies.

Your call whether that is less work that keeping your name on the
maintainer list until Openwrt naturally progresses past kernel 4.19 :)

-Toke

  parent reply	other threads:[~2018-07-19 16:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-19 15:53 Kevin Darbyshire-Bryant
2018-07-19 16:06 ` Jonathan Morton
2018-07-19 16:08 ` Toke Høiland-Jørgensen [this message]
2018-07-20  9:45   ` Kevin Darbyshire-Bryant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fu0f2oop.fsf@toke.dk \
    --to=toke@toke.dk \
    --cc=cake@lists.bufferbloat.net \
    --cc=kevin@darbyshire-bryant.me.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox