From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [IPv6:2001:470:dc45:1000::1]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id DEBA33CB35 for ; Thu, 19 Jul 2018 12:08:53 -0400 (EDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1532016532; bh=ZECBElNm4qvd8foTotmpt8sdtqeLZuMNwaiULiruhoE=; h=From:To:Subject:In-Reply-To:References:Date:From; b=Rul5Vfw9k122qrZRdqsm+sjklmQESJTFGDJhxnXa5mCwBo7m3UHro9dIbfXx1OMJa NEMAiKR45VpEsJgVqQ/i1H0F5yIA0CxSrqoKipcPtVuBDmKeRTBgT8r+RC8cTdaWGW QSzXYyof0PzWp8RgWecoSxrYXXMibbsy1SAVpIpLoW7bMEFiK42ILjcliUg5mDbctd 0H/G1GaMeu3wWduz2ijP3f+9rbPLj414oxaFYxIEoLsI6BiuIiihZBrr1iPU0zdDyI USxzl/Z0b1qIiXRhx5Ju9nfK6s70Pxl6+jM5UVHwHy8fUNk0EBboqGIfD0zrG8LcjQ WN9WCudXs+UDA== To: Kevin Darbyshire-Bryant , Cake List In-Reply-To: <8915BC75-12AD-42B0-8076-3DE8D292C410@darbyshire-bryant.me.uk> References: <8915BC75-12AD-42B0-8076-3DE8D292C410@darbyshire-bryant.me.uk> Date: Thu, 19 Jul 2018 18:08:38 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87fu0f2oop.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] Removing kmod-sched-cake package from openwrt X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2018 16:08:54 -0000 Kevin Darbyshire-Bryant writes: > Hiya Chaps, > > Bet that subject woke you up! > > This is one for the back burner but I=E2=80=99d like to do it at some poi= nt, > mainly =E2=80=98cos my name is in the maintainer field :-) > > Ideally I=E2=80=99d like to introduce cake as a kernel patch backport to > openwrt instead of as an additional module. I=E2=80=99ve started out but = my > biggest stumbling block is over the conditional conntrack stuff we > added to netfilter. The mechanism (of course) has completely changed > between v4.18 and anything earlier and I=E2=80=99m quite frankly lost! > > Any assistance or clue on doing this pre v4.18 would be appreciated. > I=E2=80=99m ok slogging through the ifdef kernel version stuff and > changing/re-introducing for the backport=E2=80=A6 but the conditional > conntrack has me beaten. Yeah, considered doing a backport patch to the kernel in openwrt. But I concluded it was not worth the trouble, since we already have a working module from the main repo. If you do want to go the kernel patch route, it's a matter of figuring out which patches you'll need to add to the backport series. Basically, figure out which parts of the patch doesn't work, run git blame on the file it is being applied to, and find the previous patch that changes the context. Add that to you stack of backported patches, and rinse and repeat until your series applies. Your call whether that is less work that keeping your name on the maintainer list until Openwrt naturally progresses past kernel 4.19 :) -Toke