From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <toke@toke.dk>
Received: from mail.toke.dk (mail.toke.dk [52.28.52.200])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id DEDFD3B29E
 for <cake@lists.bufferbloat.net>; Fri, 27 Apr 2018 09:45:42 -0400 (EDT)
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023;
 t=1524836741; bh=erJwBAQ44xYbhWGv+dgEESDG1ko4rGyzY6B9VCCS0C4=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=n+pfWIACnd8kbugmJBXqTLtW/t7zM3bY92OdLaAUDli+gu6iDp5HczGdI/+4+BHkD
 ioqclRHEkRbiVeev9c+eBV50I1K+wvWfvkkOftLLjiGU7HgeII8HsrzRvNxIqmFq3j
 IOG5fZByGYYvsa356WYyKLaEz5GyLFPHfNXIYN6cbf61elFMH89ND3ksrUGhFjw1zl
 XDztYQGxscWCL06bztT8blz6yYUUHK1r7knOpulU+RUGSXB/dLvjelQSH6LxzyziIy
 x4+9/6fSSYrRxJLKFOuYXqKhWWkpKmyox2nNN4qOo7b6oahNwC1FbD0ssX7YRCrldC
 DpsZ+o/6CVR0A==
To: Eric Dumazet <eric.dumazet@gmail.com>, netdev@vger.kernel.org
Cc: cake@lists.bufferbloat.net, Dave Taht <dave.taht@gmail.com>
In-Reply-To: <673fc1b9-809c-2e14-a054-7eb8beb9a8fd@gmail.com>
References: <20180427121706.23273-1-toke@toke.dk>
 <efb401ac-bc79-cbc5-cd03-120803b65b4d@gmail.com> <87in8c4vn7.fsf@toke.dk>
 <673fc1b9-809c-2e14-a054-7eb8beb9a8fd@gmail.com>
Date: Fri, 27 Apr 2018 15:45:40 +0200
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <87fu3g4vaz.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Cake] [PATCH net-next v4] Add Common Applications Kept
	Enhanced (cake) qdisc
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2018 13:45:43 -0000

Eric Dumazet <eric.dumazet@gmail.com> writes:

> On 04/27/2018 06:38 AM, Toke H=C3=B8iland-J=C3=B8rgensen wrote:
>>=20
>> Ah, right. Will fix.
>>=20
>> Is it safe to dereference the iph pointer before calling
>> pskb_may_pull()?
>
> No, please take a look at ip_rcv() for a typical use case.

Will do, thanks.

-Toke